• Add missing module opening for reflection access
• Fixes reflection exception in ActionFactory#enableTooltips
• Enables PDF indexing functionality to work properly

Add missing javafx.controls module opening

• Added opens("com.sun.javafx.scene.control") statement to javafx-controls module configuration
• Includes explanatory comment referencing ActionFactory#enableTooltips requirement
• Resolves reflection exception encountered during PDF indexing operations

build-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts

Description

The new opens("com.sun.javafx.scene.control") is unqualified, so it grants deep-reflection access
to this internal JavaFX package to any module on the module path, not just JabRef. This weakens
encapsulation and expands reflective access beyond what ActionFactory requires for tooltips.

Code

build-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts[R492-493]

+        // required for ActionFactory#enableTooltips
+        opens("com.sun.javafx.scene.control")

Evidence

ActionFactory uses getDeclaredMethod + setAccessible(true) against
com.sun.javafx.scene.control.ContextMenuContent.MenuItemContainer, which requires the
javafx.controls module to open that package at runtime; however, the added opens(...) is
unqualified and therefore opens it to all modules. The build logic DSL in this repo already supports
qualified opens (package opened to a specific module), and JabRef’s consuming module name is
org.jabref, so the access can be narrowed.

build-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts[486-494]
jabgui/src/main/java/org/jabref/gui/actions/ActionFactory.java[56-69]
jabgui/src/main/java/module-info.java[1-18]
build-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts[455-461]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`javafx.controls` currently uses an **unqualified** `opens("com.sun.javafx.scene.control")`, which opens an internal JavaFX package to *all* modules. JabRef’s tooltip code needs deep reflection here, but that access can likely be limited to JabRef’s own module (`org.jabref`) to reduce reflective surface area.

### Issue Context
`org.jabref.gui.actions.ActionFactory#getAssociatedNode` reflects into `com.sun.javafx.scene.control.ContextMenuContent.MenuItemContainer` via `setAccessible(true)`, which requires `javafx.controls` to open `com.sun.javafx.scene.control`.

### Fix Focus Areas
- build-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts[486-494]

### Suggested change
Replace:
- `opens("com.sun.javafx.scene.control")`

With (minimum):
- `opens("com.sun.javafx.scene.control", "org.jabref")`

If tests or other runtime modules also reflect into this package, add them explicitly as additional qualified targets rather than keeping it unqualified.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools