Fix exception in ExtractReferences from pdf#15308
Merged
Merged
Conversation
Contributor
Review Summary by QodoFix thread safety exception in ExtractReferencesAction
WalkthroughsDescription• Fix IllegalStateException when extracting references from PDF • Wrap field update in JavaFX thread to prevent thread safety violation • Remove unused linkedFile instance variable from class • Add test data entries for reference extraction validation Diagramflowchart LR
A["Extract References Action"] -->|Previously| B["Direct Field Update<br/>on Worker Thread"]
B -->|Causes| C["IllegalStateException<br/>Event Thread Violation"]
A -->|Now| D["UiTaskExecutor Wrapper"]
D -->|Executes| E["Field Update<br/>on JavaFX Thread"]
E -->|Result| F["Thread Safe Operation"]
File Changes1. jabgui/src/main/java/org/jabref/gui/maintable/ExtractReferencesAction.java
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
subhramit
approved these changes
Mar 9, 2026
✅ All tests passed ✅🏷️ Commit: 4b80a96 Learn more about TestLens at testlens.app. |
Siedlerchr
added a commit
to statxc/jabref
that referenced
this pull request
Mar 10, 2026
* upstream/main: fix jbang (JabRef#15311) New Crowdin updates (JabRef#15310) Fix exception in ExtractReferences from pdf (JabRef#15308) feat: add --entry-type-pattern option to citationkeys generate command (JabRef#15072) Fix reflection excpetion, add missing (JabRef#15307)
FynnianB
pushed a commit
to FynnianB/jabref
that referenced
this pull request
Mar 14, 2026
* Fix exception in ExtraRefernces Exception * changelog * revert
FynnianB
pushed a commit
to FynnianB/jabref
that referenced
this pull request
Mar 19, 2026
* Fix exception in ExtraRefernces Exception * changelog * revert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues and pull requests
Fix
Closes _____
PR Description
Steps to test
Have an entry with pdf
Right click -> Extract references
No exception is thrown
Checklist
CHANGELOG.mdin a way that can be understood by the average user (if change is visible to the user)