Skip to content

fix jbang#15311

Merged
Siedlerchr merged 1 commit into
mainfrom
fix-jbang-keysuffixconverter
Mar 10, 2026
Merged

fix jbang#15311
Siedlerchr merged 1 commit into
mainfrom
fix-jbang-keysuffixconverter

Conversation

@palukku

@palukku palukku commented Mar 10, 2026

Copy link
Copy Markdown
Member

Fix jbang not finding KeySuffixConverter

PR Description

Steps to test

Checklist

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] I manually tested my changes in running JabRef (always required)
  • [.] I added JUnit tests for changes (if applicable)
  • [.] I added screenshots in the PR description (if change is visible to the user)
  • [.] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
  • [.] I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
  • [.] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

@palukku palukku marked this pull request as ready for review March 10, 2026 09:56
@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Add KeySuffixConverter to jbang launcher sources

🐞 Bug fix

Grey Divider

Walkthroughs

Description 
• Add missing KeySuffixConverter source to jbang launcher
• Resolves jbang compilation error for KeySuffixConverter class
Diagram 
flowchart LR
  A["JabKitLauncher.java"] -- "adds SOURCES directive" --> B["KeySuffixConverter.java"]
  B -- "enables jbang to find" --> C["KeySuffixConverter class"]
Loading

Grey Divider

File Changes

1. .jbang/JabKitLauncher.java 🐞 Bug fix +1/-0

Add KeySuffixConverter source directive

• Added missing //SOURCES directive for KeySuffixConverter.java
• Ensures jbang can locate and compile the KeySuffixConverter class
• Maintains consistency with other converter source declarations

.jbang/JabKitLauncher.java

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Mar 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@Siedlerchr Siedlerchr enabled auto-merge March 10, 2026 09:59
@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 10, 2026
@testlens-app

testlens-app Bot commented Mar 10, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 82d5fe1
▶️ Tests: 10126 executed
⚪️ Checks: 64/64 completed

Learn more about TestLens at testlens.app.

@github-actions github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Mar 10, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 10, 2026
@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 10, 2026
Merged via the queue into main with commit cff2993 Mar 10, 2026
65 checks passed
@Siedlerchr Siedlerchr deleted the fix-jbang-keysuffixconverter branch March 10, 2026 10:57
Siedlerchr added a commit to statxc/jabref that referenced this pull request Mar 10, 2026
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix/issue-15108
a478d64 
* upstream/main:
  fix jbang (JabRef#15311)
  New Crowdin updates (JabRef#15310)
  Fix exception in ExtractReferences from pdf (JabRef#15308)
  feat: add --entry-type-pattern option to citationkeys generate command (JabRef#15072)
  Fix reflection excpetion, add missing (JabRef#15307)
FynnianB pushed a commit to FynnianB/jabref that referenced this pull request Mar 14, 2026
@palukku @FynnianB
fix jbang (JabRef#15311)
113f89f
FynnianB pushed a commit to FynnianB/jabref that referenced this pull request Mar 19, 2026
@palukku @FynnianB
fix jbang (JabRef#15311)
d7307c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

status: to-be-merged PRs which are accepted and should go into the merge-queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@palukku @Siedlerchr