Skip to content

Fix: open javafx.scene.control.skin to controlsfx#15260

Merged
jjohannes merged 2 commits into
mainfrom
fix-open-javafx.scene.control.skin
Mar 3, 2026
Merged

Fix: open javafx.scene.control.skin to controlsfx#15260
jjohannes merged 2 commits into
mainfrom
fix-open-javafx.scene.control.skin

Conversation

@jjohannes

@jjohannes jjohannes commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

Related issues and pull requests

Follow up to #15194

PR Description

Fixes error:

image

Steps to test

Checklist

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] I manually tested my changes in running JabRef (always required)
  • [.] I added JUnit tests for changes (if applicable)
  • [.] I added screenshots in the PR description (if change is visible to the user)
  • [.] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
  • [.] I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
  • [.] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

@jjohannes jjohannes self-assigned this Mar 3, 2026
@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Open javafx.scene.control.skin module to ControlsFX

🐞 Bug fix

Grey Divider

Walkthroughs

Description 
• Opens javafx.scene.control.skin module to ControlsFX
• Resolves module access error in ControlsFX integration
• Adds module opening configuration in Gradle build logic
Diagram 
flowchart LR
  A["javafx.controls module"] -- "opens javafx.scene.control.skin" --> B["org.controlsfx.controls"]
  C["Gradle build configuration"] -- "updated" --> A
Loading

Grey Divider

File Changes

1. build-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts ⚙️ Configuration changes +1/-0

Add javafx.scene.control.skin module opening

• Added opens("javafx.scene.control.skin", "org.controlsfx.controls") directive
• Exposes internal JavaFX control skin package to ControlsFX module
• Resolves module visibility error preventing ControlsFX access

build-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@jjohannes jjohannes requested a review from koppor March 3, 2026 12:01
@jjohannes jjohannes added the dev: binaries Binary builds should be uploaded to builds.jabref.org label Mar 3, 2026
Siedlerchr
Siedlerchr previously approved these changes Mar 3, 2026
View reviewed changes
@jjohannes jjohannes enabled auto-merge March 3, 2026 12:12
koppor
koppor reviewed Mar 3, 2026
View reviewed changes
Comment thread build-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts Outdated
koppor
koppor reviewed Mar 3, 2026
View reviewed changes
Comment thread build-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts
@jjohannes jjohannes added this pull request to the merge queue Mar 3, 2026
@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

The build of this PR is available at https://builds.jabref.org/pull-15260/.

@testlens-app

testlens-app Bot commented Mar 3, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: a1e1727
▶️ Tests: 10103 executed
⚪️ Checks: 54/54 completed

Learn more about TestLens at testlens.app.

@github-actions github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Mar 3, 2026
Merged via the queue into main with commit a1c7f85 Mar 3, 2026
55 checks passed
@jjohannes jjohannes deleted the fix-open-javafx.scene.control.skin branch March 3, 2026 13:39
Siedlerchr added a commit that referenced this pull request Mar 5, 2026
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into dependabot/gradle/o…
85ebe90 
…rg.openrewrite.recipe-rewrite-recipe-bom-3.25.0

* upstream/main: (35 commits)
  Chore: add dependency-management.md (#15278)
  Chore(deps): Bump dev.langchain4j:langchain4j-bom in /versions (#15277)
  New Crowdin updates (#15274)
  Chore(deps): Bump actions/upload-artifact from 6 to 7 (#15271)
  Chore(deps): Bump actions/download-artifact from 7 to 8 (#15270)
  Chore(deps): Bump docker/login-action from 3 to 4 (#15268)
  Fix threading issues in citations relations tab (#15233)
  Fix: Citavi XML importer now preserves citation keys (#14658) (#15257)
  Preserve no break spaces in Latex to Unicode conversion (#15174)
  Fix: open javafx.scene.control.skin to controlsfx (#15260)
  Reduce complexity in dependencies setup (restore) (#15194)
  New translations jabref_en.properties (French) (#15256)
  Fix: exception dialog shows up when moving sidepanel down/up (#15248)
  Implement reset for Name Display Preferences (#15136)
  Chore(deps): Bump net.bytebuddy:byte-buddy in /versions (#15252)
  Chore(deps): Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#15253)
  Chore(deps): Bump io.zonky.test:embedded-postgres in /versions (#15254)
  Chore(deps): Bump net.ltgt.errorprone from 5.0.0 to 5.1.0 in /jablib (#15251)
  New Crowdin updates (#15247)
  Refined the "Select files to import" page in "Search for unlinked local files" dialog (#15110)
  ...
Siedlerchr added a commit that referenced this pull request Mar 9, 2026
@Siedlerchr
Fix reflection excpetion, add missing
bb4d7b1 
Follow up to #15260
@Siedlerchr Siedlerchr mentioned this pull request Mar 9, 2026
Merged
1 task
github-merge-queue Bot pushed a commit that referenced this pull request Mar 9, 2026
@Siedlerchr
Fix reflection excpetion, add missing (#15307)
b948fe0 
Follow up to #15260
FynnianB pushed a commit to FynnianB/jabref that referenced this pull request Mar 14, 2026
@Siedlerchr @FynnianB
Fix reflection excpetion, add missing (JabRef#15307)
86ccc83 
Follow up to JabRef#15260
FynnianB pushed a commit to FynnianB/jabref that referenced this pull request Mar 19, 2026
@Siedlerchr @FynnianB
Fix reflection excpetion, add missing (JabRef#15307)
cf16747 
Follow up to JabRef#15260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor left review comments

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

@jjohannes jjohannes

Labels

dev: binaries Binary builds should be uploaded to builds.jabref.org status: to-be-merged PRs which are accepted and should go into the merge-queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jjohannes @Siedlerchr @koppor