• Implement cooperative cancellation in citation relations tab
  - Pass cancellation token to search methods
  - Use cancel(false) for non-interruptible cancellation
  - Add mayInterruptIfRunning property to BackgroundTask
• Refactor MVStore initialization into MVStoreBase
  - Extract common MVStore setup logic
  - Add null checks for safe resource cleanup
  - Improve error handling with NotificationService
• Add cancellation checks in search operations
  - Check isCancelled after fetching citations/references
  - Return empty list if cancelled mid-operation

Add dialogService to SearchCitationsRelationsService

• Add dialogService parameter to SearchCitationsRelationsService constructor
• Pass NotificationService for error handling in citation relations initialization

jabgui/src/main/java/org/jabref/gui/JabRefGUI.java

Implement cooperative cancellation with null checks

• Replace cancel() with cancel(false) for cooperative cancellation throughout
• Add null checks before cancelling tasks in jumpToEntry and importEntries
• Pass isCancelled lambda to search methods for mid-operation cancellation checks
• Update JavaDoc reference to PreviewWithSourceTab class
• Remove this. qualifier from task assignments for consistency

jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java

Use cooperative cancellation in ViewModel

• Change searchTask.cancel(true) to cancel(false) for cooperative cancellation
• Prevent interruption of running search tasks

jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationsRelationsTabViewModel.java

Description

createBackgroundTask passes citingTask::isCancelled / citedByTask::isCancelled by reading a
mutable static field at execution time; if the field is nulled/replaced while the JavaFX task is
queued or running, the method-reference evaluation can NPE or bind cancellation checks to the wrong
task, causing incorrect early-return behavior and/or stale repository writes.

Code

jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java[R830-838]

+                citingTask = BackgroundTask.wrap(
+                        () -> this.searchCitationsRelationsService.searchCites(entry, bypassCache, citingTask::isCancelled)
               );
               yield citingTask;
           }
           case CitationFetcher.SearchType.CITED_BY -> {
-                this.citedByTask = BackgroundTask.wrap(
-                        () -> this.searchCitationsRelationsService.searchCitedBy(entry, bypassCache)
+                citedByTask = BackgroundTask.wrap(
+                        () -> this.searchCitationsRelationsService.searchCitedBy(entry, bypassCache, citedByTask::isCancelled)
               );

Evidence

The background callable evaluates citingTask::isCancelled / citedByTask::isCancelled when it
runs, meaning it depends on the then-current value of those static fields. Those fields are
explicitly set to null on entry rebind, and tasks are executed asynchronously via
executor.submit(task), so there is a real race window where the field can be null/reassigned
before the callable starts (or while other queued tasks start), resulting in NPE or checking the
wrong task’s cancelled state. The service then changes behavior (returns List.of() and skips
storing) based on that supplier.

jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java[825-841]
jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java[702-713]
jabgui/src/main/java/org/jabref/gui/util/UiTaskExecutor.java[100-125]
jablib/src/main/java/org/jabref/logic/citation/SearchCitationsRelationsService.java[87-99]
jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java[97-106]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`CitationRelationsTab#createBackgroundTask` uses `citingTask::isCancelled` / `citedByTask::isCancelled` inside the task callable. Because these are **static mutable fields** that are later set to `null`/overwritten, the callable can evaluate the method reference against `null` or the wrong task when it starts (tasks are queued on an executor), leading to NPEs or incorrect cancellation decisions.
### Issue Context
We need the `BooleanSupplier` passed to `SearchCitationsRelationsService` to reliably represent *the task that is currently executing*, regardless of what the UI thread does with `citingTask`/`citedByTask` fields.
### Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java[825-841]
- jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java[702-713]
### Implementation sketch
- Replace `BackgroundTask.wrap(() -> service.searchCites(..., citingTask::isCancelled))` with a task instance whose `call()` method uses `this::isCancelled`.
- Assign the created task to `citingTask`/`citedByTask` *after* creation.
- Ensure cancellation code paths don’t create a window where `citingTask` is set to null while queued tasks still depend on it.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Description

The @VisibleForTesting constructor now calls super(Path.of(""), ...), which MVStoreBase forwards
to .fileName(mvStorePath.toString()); for an empty path this is an empty string, which may cause
MVStore to attempt to open an invalid/ambiguous filename or fail during tests.

Code

jablib/src/main/java/org/jabref/logic/citation/repository/BibEntryCitationsAndReferencesRepositoryShell.java[R53-56]

+        super(Path.of(""), _ -> { }); // Dummy Path for testing
       this.citationsDao = citationsDao;
       this.referencesDao = referencesDao;
-        this.mvStore = null;
   }

Evidence

The test constructor explicitly uses Path.of(""). MVStoreBase always passes
mvStorePath.toString() to MVStore’s fileName(...) unless mvStorePath is null. There is no
guard to treat blank/empty filenames as in-memory stores, so the test path flows into MVStore open
logic.

jablib/src/main/java/org/jabref/logic/citation/repository/BibEntryCitationsAndReferencesRepositoryShell.java[48-56]
jablib/src/main/java/org/jabref/logic/ai/util/MVStoreBase.java[33-37]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`BibEntryCitationsAndReferencesRepositoryShell`’s `@VisibleForTesting` constructor calls `super(Path.of(""), ...)`. `MVStoreBase` forwards `path.toString()` to `MVStore.Builder.fileName(...)`, so an empty string is passed to MVStore, which can lead to failures or unintended filesystem behavior during tests.
### Issue Context
The intent of the `@VisibleForTesting` constructor is to avoid real disk IO and use mocks; it should not need to open a file-backed MVStore at all.
### Fix Focus Areas
- jablib/src/main/java/org/jabref/logic/citation/repository/BibEntryCitationsAndReferencesRepositoryShell.java[48-56]
- jablib/src/main/java/org/jabref/logic/ai/util/MVStoreBase.java[33-37]
### Implementation options
1) **Preferred:** Add a `protected MVStoreBase(NotificationService)` (or similar) that opens an in-memory store (`fileName(null)`), and use that from the testing constructor.
2) Add a guard in `MVStoreBase`:
 - compute `String fileName = mvStorePath == null ? null : mvStorePath.toString();`
 - if `fileName != null && fileName.isBlank()` then set it to `null`
 - pass `fileName` to `.fileName(...)`.
Either approach makes test behavior deterministic and avoids passing an empty filename to MVStore.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools