Conversation
Review Summary by QodoAdd French translations for file linking features
WalkthroughsDescription• Add French translations for file linking features • Translate new UI strings related to entry linking workflow • Update localization strings for file import operations Diagramflowchart LR
A["French Properties File"] -- "Add translations" --> B["File Linking UI Strings"]
A -- "Add translations" --> C["Entry Selection Strings"]
A -- "Add translations" --> D["Import Operations Strings"]
File Changes1. jablib/src/main/resources/l10n/JabRef_fr.properties
|
Code Review by Qodo
1. new translation wrong case
|
| Automatically\ open\ folders\ of\ attached\ files=Ouvrir automatiquement les répertoires des fichiers joints | ||
| Cannot\ open\ folder\ as\ the\ file\ is\ an\ online\ link.=Impossible d'ouvrir le dossier car le fichier est un lien en ligne. | ||
| Select\ entry\ to\ link=Sélectionner l'entrée à lier | ||
| new=nouveau |
There was a problem hiding this comment.
1. new translation wrong case 📘 Rule violation ✓ Correctness
The new French UI string new=nouveau is lowercased, which is inconsistent with typical UI label sentence-case/capitalization. This can make the UI look unpolished and inconsistent with other translated labels.
Agent Prompt
## Issue description
The French localization entry `new=nouveau` is lowercased and likely violates UI text capitalization/sentence-case conventions.
## Issue Context
This is user-facing UI text in a localization properties file; inconsistent capitalization makes UI labels look unpolished.
## Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_fr.properties[757-757]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| Do\ not\ link=Ne pas lier | ||
| File\ was\ linked\ to\ existing\ entry=Le fichier a été lié à une entrée existante | ||
| Import\ the\ file\ in\ a\ new\ entry=Importer le fichier dans une nouvelle entrée | ||
| Select\ an\ existing\ entry\ to\ link\ the\ file\ to=Sélectionnez une entrée existante pour lui lier le fichier |
There was a problem hiding this comment.
2. Inconsistent french imperative usage 📘 Rule violation ✓ Correctness
The new French strings mix infinitive (Sélectionner ...) and imperative (Sélectionnez ...) forms for similar prompts, and the phrasing pour lui lier le fichier is awkward/incorrect. This reduces consistency and clarity of user-facing text.
Agent Prompt
## Issue description
Two newly added French localization strings for similar actions use different grammatical moods (infinitive vs imperative) and one contains awkward/incorrect phrasing (`pour lui lier le fichier`).
## Issue Context
These are user-facing prompts; consistency and grammatical correctness are required.
## Fix Focus Areas
- jablib/src/main/resources/l10n/JabRef_fr.properties[756-756]
- jablib/src/main/resources/l10n/JabRef_fr.properties[3034-3034]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
✅ All tests passed ✅🏷️ Commit: fbdb210 Learn more about TestLens at testlens.app. |
…rg.openrewrite.recipe-rewrite-recipe-bom-3.25.0 * upstream/main: (35 commits) Chore: add dependency-management.md (#15278) Chore(deps): Bump dev.langchain4j:langchain4j-bom in /versions (#15277) New Crowdin updates (#15274) Chore(deps): Bump actions/upload-artifact from 6 to 7 (#15271) Chore(deps): Bump actions/download-artifact from 7 to 8 (#15270) Chore(deps): Bump docker/login-action from 3 to 4 (#15268) Fix threading issues in citations relations tab (#15233) Fix: Citavi XML importer now preserves citation keys (#14658) (#15257) Preserve no break spaces in Latex to Unicode conversion (#15174) Fix: open javafx.scene.control.skin to controlsfx (#15260) Reduce complexity in dependencies setup (restore) (#15194) New translations jabref_en.properties (French) (#15256) Fix: exception dialog shows up when moving sidepanel down/up (#15248) Implement reset for Name Display Preferences (#15136) Chore(deps): Bump net.bytebuddy:byte-buddy in /versions (#15252) Chore(deps): Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#15253) Chore(deps): Bump io.zonky.test:embedded-postgres in /versions (#15254) Chore(deps): Bump net.ltgt.errorprone from 5.0.0 to 5.1.0 in /jablib (#15251) New Crowdin updates (#15247) Refined the "Select files to import" page in "Search for unlinked local files" dialog (#15110) ...
No description provided.