Convert to jackson 3 by Siedlerchr · Pull Request #14259 · JabRef/jabref

Siedlerchr · 2025-11-08T18:38:29Z

Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/1083

Steps to test

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
[.] I manually tested my changes in running JabRef (always required)
[.] I added JUnit tests for changes (if applicable)
[.] I added screenshots in the PR description (if change is visible to the user)
[.] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
[.] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

Siedlerchr · 2025-11-09T19:32:37Z

stack overflow error in jbang wtf?

* main: change command imports Chore(deps): Bump org.openrewrite.rewrite from 7.19.0 to 7.20.0 (#14266) Chore(deps): Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.17.0 to 3.18.0 (#14265) Chore(deps): Bump com.google.errorprone:error_prone_core in /versions (#14269) Chore(deps): Bump io.github.thibaultmeyer:cuid in /versions (#14268) Chore(deps): Bump org.gradlex:java-module-testing in /build-logic (#14267) Chore(deps): Bump jablib/src/main/resources/csl-styles (#14264) Chore(deps): Bump appleboy/ssh-action from 1.2.2 to 1.2.3 (#14262) Fix: Ctrl+Shift+L now opens terminal in the active library directory (#14256) # Conflicts: # jabsrv/src/main/java/module-info.java # jabsrv/src/main/java/org/jabref/http/server/command/CommandResource.java

Siedlerchr · 2025-11-09T20:19:47Z

definitely something with the dep:
at dev.jbang.dependencies.DependencyUtil.looksLikeAPossibleGav(DependencyUtil.java:158)
at dev.jbang.source.parser.Directives.isGav(Directives.java:82)
at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:196)

koppor · 2025-11-09T20:25:40Z

I filed jbangdev/jbang#2281

* main: Fix calling JBang command (#14282) .jbang scripts should not be included inside themselves (#14278) Fix typos (#14277) Refactor importDatabase for better readability (#14274) fix jbang (#14276) Feat: Add definition links for TeX Files (#14260) Update preventing module commits (#14273) Fix JabKitLuancher Rename packages in jabkit to start with org.jabref.toolkit to avoid split packages between jabkit and jabgui (#14052). (#14271) Add doi-to-bibtex to examples and JabKit (#14244)

Siedlerchr · 2025-11-11T07:34:19Z

needs testing with LSP

* upstream/main: Fix NPE on startup (#14272)

* upstream/main: (30 commits) Chore(deps): Bump io.github.classgraph:classgraph from 4.8.181 to 4.8.184 in /versions (#14304) Chore(deps): Bump com.fasterxml:aalto-xml in /versions (#14311) Chore(deps): Bump commons-io:commons-io in /versions (#14310) Chore(deps): Bump org.apache.maven.plugins:maven-surefire-plugin (#14298) Disable fetcher-gui-test (#14308) Chore(deps): Bump com.dlsc.gemsfx:gemsfx in /versions (#14307) No labels for dependeabot updates Fix fallback window height from 786 to 768 (#14295) Chore(deps): Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (#14306) Chore(deps): Bump org.apache.maven.plugins:maven-compiler-plugin (#14302) Chore(deps): Bump org.apache.maven.plugins:maven-deploy-plugin (#14300) Chore(deps): Bump org.apache.maven.plugins:maven-clean-plugin (#14299) Chore(deps): Bump jablib/src/main/resources/csl-styles (#14296) Chore(deps): Bump com.vanniktech.maven.publish in /jablib (#14303) Chore(deps): Bump org.apache.maven.plugins:maven-project-info-reports-plugin (#14297) Update all dependencies (#14301) Prepare maven3 example project (#14294) Refactor StringUtilTest to use parameterized tests (#14126) Try to fix download of pr_number Fix workflow names ...

koppor · 2025-11-14T05:11:23Z

Now, JBang outputs

 CSLStyleLoader.java:16: error: package tools.jackson.core.type does not exist
import tools.jackson.core.type.TypeReference;

This is OK, because jablib on maven central is not updated with the new jackson dependencies

koppor · 2025-11-14T05:24:23Z

JabKitLauncher has a strange error when it is executed... - I am not sure what this is, but I would wait for a merge in main and see what happens...

 Error: Exception in thread "main" java.lang.NoClassDefFoundError: textFormatter/color/Color
	at org.jabref.toolkit.JabKit.initLogging(JabKit.java:157)
	at org.jabref.toolkit.JabKit.main(JabKit.java:63)
	at JabKitLauncher.main(JabKitLauncher.java:41)
Caused by: java.lang.ClassNotFoundException: textFormatter.color.Color
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:580)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:490)
``´

koppor · 2025-11-14T05:25:16Z

+//DEPS com.fasterxml.jackson.core:jackson-annotations:2.20
+//DEPS tools.jackson.core:jackson-core:3.0.2
+//DEPS tools.jackson.core:jackson-databind:3.0.2
+//DEPS tools.jackson.dataformat:jackson-dataformat-yaml:3.0.2


Maybe, this can be left out, because it will come in using the jablib SNAPSHOT from maven central.

koppor · 2025-11-14T05:26:15Z

    api("org.junit.jupiter:junit-jupiter")
    api("org.junit.platform:junit-platform-launcher")

+    api(platform("tools.jackson:jackson-bom:3.0.2"))


The version has to go to below to the constraints (doesn't it?)

I have absolutely no idea, because it's a bom and other boms are declared at the top as well

* upstream/main: Add smoke tests (#14338) Clean up packages in JabKit (#14335) Output binaries workflow decisions to summary (#14333) New translations jabref_en.properties (Portuguese, Brazilian) (#14332) Check for disk space only once (#14331) Chore(deps): Bump org.glassfish.jersey.core:jersey-server from 3.1.11 to 4.0.0 in /versions (#14305)

koppor

Let's try it out :)

* convert to jackson 3 * checkstyle * checkstyle * fix jbang and checkstlye * fix typo * fix jbang * fix jbang * fix jbang * fix jbang * fix artifat id * add jackson annotations * fix imports * fix imports * Add debug * fix imports * add jackson deps to jbang * fix import * fix imports * reveRT CSL CHANGE * fix imports * add to example * cahnge mscocde utils * fix lsp import * ad jackson annotaitons * ad jackson annotaitons * Try to fix .. * Fix variable --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

koppor · 2025-11-25T19:39:37Z

Migration guide: https://github.com/FasterXML/jackson/blob/main/jackson3/MIGRATING_TO_JACKSON_3.md

Siedlerchr added 11 commits November 8, 2025 19:37

convert to jackson 3

5c07d88

checkstyle

511f42a

checkstyle

f5f6682

fix jbang and checkstlye

2ab4cda

fix typo

9649cc3

fix jbang

1a2979b

fix jbang

da9133e

fix jbang

c07d71c

fix jbang

cc621ce

fix artifat id

b9fe2e4

add jackson annotations

398f1eb

Siedlerchr added 3 commits November 9, 2025 20:35

fix imports

431c9e9

fix imports

9b30927

koppor mentioned this pull request Nov 9, 2025

Add doi-to-bibtex to examples and JabKit #14244

Merged

3 tasks

Add debug

bbce853

Merge branch 'main' into jackson3

7c8f43d

Siedlerchr added 9 commits November 9, 2025 21:26

fix imports

f291512

add jackson deps to jbang

395fade

fix import

ee56c1e

fix imports

bf6b1dc

reveRT CSL CHANGE

d7b6e80

fix imports

b828262

add to example

a1ab067

cahnge mscocde utils

b4aaae4

Siedlerchr and others added 7 commits November 13, 2025 21:20

Merge remote-tracking branch 'upstream/main' into jackson3

f404793

* upstream/main: Fix NPE on startup (#14272)

fix lsp import

fcfebab

ad jackson annotaitons

5891f4b

ad jackson annotaitons

00f1f31

Merge branch 'main' into jackson3

62bdd16

Try to fix ..

99b55b7

Fix variable

f345a8f

koppor reviewed Nov 14, 2025

View reviewed changes

koppor and others added 2 commits November 14, 2025 06:28

Merge branch 'main' into jackson3

ed5520f

Merge branch 'main' into jackson3

bf99f76

Siedlerchr enabled auto-merge November 15, 2025 16:09

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 15, 2025

Siedlerchr added 2 commits November 16, 2025 21:24

Merge branch 'main' into jackson3

e63a95f

koppor approved these changes Nov 17, 2025

View reviewed changes

Siedlerchr added this pull request to the merge queue Nov 17, 2025

koppor changed the title ~~WIP convert to jackson 3~~ Convert to jackson 3 Nov 17, 2025

Merged via the queue into main with commit 29bdb09 Nov 17, 2025
60 of 62 checks passed

Siedlerchr deleted the jackson3 branch November 17, 2025 20:53

koppor mentioned this pull request Nov 25, 2025

Remove obsolete dependency #14433

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Convert to jackson 3#14259

Convert to jackson 3#14259
Siedlerchr merged 37 commits into
mainfrom
jackson3

Siedlerchr commented Nov 8, 2025

Uh oh!

Siedlerchr commented Nov 9, 2025

Uh oh!

Siedlerchr commented Nov 9, 2025

Uh oh!

koppor commented Nov 9, 2025

Uh oh!

Siedlerchr commented Nov 11, 2025

Uh oh!

koppor commented Nov 14, 2025

Uh oh!

koppor commented Nov 14, 2025

Uh oh!

koppor Nov 14, 2025

Uh oh!

koppor Nov 14, 2025

Uh oh!

Siedlerchr Nov 14, 2025

Uh oh!

koppor left a comment

Uh oh!

Uh oh!

koppor commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Siedlerchr commented Nov 8, 2025

Steps to test

Mandatory checks

Uh oh!

Siedlerchr commented Nov 9, 2025

Uh oh!

Siedlerchr commented Nov 9, 2025

Uh oh!

koppor commented Nov 9, 2025

Uh oh!

Siedlerchr commented Nov 11, 2025

Uh oh!

koppor commented Nov 14, 2025

Uh oh!

koppor commented Nov 14, 2025

Uh oh!

koppor Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

koppor Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

koppor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

koppor commented Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants