Skip to content

Clean up packages in JabKit#14335

Merged
calixtus merged 3 commits into
mainfrom
improve-jabkit-package-structure
Nov 17, 2025
Merged

Clean up packages in JabKit#14335
calixtus merged 3 commits into
mainfrom
improve-jabkit-package-structure

Conversation

@koppor

@koppor koppor commented Nov 16, 2025

Copy link
Copy Markdown
Member

Follow-up to #14271

I see that we need a @Command for jabkit, but also a "wrapper" around to initialiize. Currently, the class name is not consistent to the command - this fixes it.

  • entry point: JabKitLauncher
  • command "jabkit": JabKit

Also cleans up packages - removes cli; our toolkit is already the CLI.

Steps to test

  • Run JabKit Launcher
  • jbang .jbang/JabKitLauncher

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@koppor
Clean up packages in JabKit
add1432
@koppor
Fix namings
e6b2bab 
- entry point: JabKitLauncher
- command "jabkit": JabKit
@koppor koppor requested a review from calixtus November 16, 2025 22:55
@koppor

koppor commented Nov 17, 2025

Copy link
Copy Markdown
Member Author

Locally, JBang runs

$ jbang .jbang/JabKitLauncher.java
2025-11-17 10:41:31 [main] org.jabref.logic.preferences.JabRefCliPreferences.getFetcherKeysFromKeyring()
WARN: JabRef could not open the key store

@calixtus calixtus added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit c165a2a Nov 17, 2025
62 of 63 checks passed
@calixtus calixtus deleted the improve-jabkit-package-structure branch November 17, 2025 11:08
koppor added a commit that referenced this pull request Nov 17, 2025
@koppor
Magic merge commit for PR #14335
14f2dfb
Siedlerchr added a commit that referenced this pull request Nov 17, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into jackson3
c3ab787 
* upstream/main:
  Add smoke tests (#14338)
  Clean up packages in JabKit (#14335)
  Output binaries workflow decisions to summary (#14333)
  New translations jabref_en.properties (Portuguese, Brazilian) (#14332)
  Check for disk space only once (#14331)
  Chore(deps): Bump org.glassfish.jersey.core:jersey-server from 3.1.11 to 4.0.0 in /versions (#14305)
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
@koppor @merlinymy
Clean up packages in JabKit (JabRef#14335)
17c9589 
* Clean up packages in JabKit

* Fix namings

- entry point: JabKitLauncher
- command "jabkit": JabKit

* Fix main class name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koppor @calixtus