Skip to content

Check for disk space only once#14331

Merged
Siedlerchr merged 3 commits into
mainfrom
move-workflow-condition-check
Nov 16, 2025
Merged

Check for disk space only once#14331
Siedlerchr merged 3 commits into
mainfrom
move-workflow-condition-check

Conversation

@koppor

@koppor koppor commented Nov 16, 2025

Copy link
Copy Markdown
Member

This separates the job for disk space check to enable easy check why some binaries are not uploaded any more (and avoid partial updates)

Steps to test

Create binaries and see if they are still uploaded.

Check if binaries are still created even if they are not uploaded

See what happens if there is too little disk space (can be done after merge)

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@koppor

koppor commented Nov 16, 2025

Copy link
Copy Markdown
Member Author

Without "dev: binaries" label:

grafik grafik

@koppor koppor added the dev: binaries Binary builds should be uploaded to builds.jabref.org label Nov 16, 2025
@koppor

koppor commented Nov 16, 2025

Copy link
Copy Markdown
Member Author

With "dev: binaries"

grafik

@github-actions

Copy link
Copy Markdown
Contributor

The build of this PR is available at https://builds.jabref.org/pull/14331/merge.

@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 16, 2025
Merged via the queue into main with commit 1bae2ca Nov 16, 2025
56 of 64 checks passed
@Siedlerchr Siedlerchr deleted the move-workflow-condition-check branch November 16, 2025 20:56
Siedlerchr added a commit that referenced this pull request Nov 17, 2025
* upstream/main:
  Add smoke tests (#14338)
  Clean up packages in JabKit (#14335)
  Output binaries workflow decisions to summary (#14333)
  New translations jabref_en.properties (Portuguese, Brazilian) (#14332)
  Check for disk space only once (#14331)
  Chore(deps): Bump org.glassfish.jersey.core:jersey-server from 3.1.11 to 4.0.0 in /versions (#14305)
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
* Check for disk space only once

* Set 80% as limit

* Fix running of binaries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: binaries Binary builds should be uploaded to builds.jabref.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants