-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Package and Class name collision accross modules #14052
Copy link
Copy link
Labels
dev: code-qualityIssues related to code or architecture decisionsIssues related to code or architecture decisionsgood second issueIssues that involve a tour of two or three interweaved components in JabRefIssues that involve a tour of two or three interweaved components in JabRef📌 Pinned
Metadata
Metadata
Assignees
Labels
dev: code-qualityIssues related to code or architecture decisionsIssues related to code or architecture decisionsgood second issueIssues that involve a tour of two or three interweaved components in JabRefIssues that involve a tour of two or three interweaved components in JabRef📌 Pinned
Type
Fields
Give feedbackNo fields configured for task.
Projects
StatusShow more project fields
Done
Is your suggestion for improvement related to a problem? Please describe.
I observe at least one package and even class name collision between two JabRef Modules:
org.jabref.cli.ArgumentProcessorexists in jabgui and jabkit and both classes are quite different. They have completely different members, so this is more than just a shadowing hack.While technically possible, already the package name clash is bad style. So-called split packages are discouraged in the Java module system and can cause unforeseen issues.
From https://dev.java/learn/modules/intro/:
Describe the solution you'd like
Please refactor to avoid split packages as it is an unnecessary risk and source of trouble. The earlier this is done, the easier the change will be. I strongly recommend to adjust this before beta phase.