Skip to content

Initialize search bar auto-completion with real database context (no tab switch needed)#13816

Merged
Siedlerchr merged 7 commits into
JabRef:mainfrom
harii55:fix/11428-searchbar-autocomplete
Sep 4, 2025
Merged

Initialize search bar auto-completion with real database context (no tab switch needed)#13816
Siedlerchr merged 7 commits into
JabRef:mainfrom
harii55:fix/11428-searchbar-autocomplete

Conversation

@harii55

@harii55 harii55 commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Closes #11428

This PR ensures that the search bar's auto-completion is correctly initialized as soon as a database is opened, without requiring the user to switch tabs. The auto-completer is now updated immediately after the real database context is loaded, improving the user experience and resolving the issue where auto-completion was unavailable until a tab switch.

Steps to test

  1. Launch JabRef.
  2. Go to File → Open library… and open jablib/src/main/resources/Chocolate.bib.
  3. Wait until the Chocolate tab finishes loading (spinner disappears).
  4. Click the Global Search bar (top toolbar) and type s or sm.

Before
No suggestions appear at this step.

After
Auto-completion popup appears immediately.


Screenshot from 2025-09-02 21-31-58

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

Comment thread jabgui/src/main/java/org/jabref/gui/LibraryTab.java Outdated
Comment thread jabgui/src/main/java/org/jabref/gui/LibraryTab.java
Comment thread CHANGELOG.md Outdated
Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
Comment thread jabgui/src/main/java/org/jabref/gui/frame/JabRefFrame.java Outdated
@trag-bot

trag-bot Bot commented Sep 3, 2025

Copy link
Copy Markdown

@trag-bot didn't find any issues in the code! ✅✨

@harii55 harii55 requested a review from subhramit September 3, 2025 20:30
@subhramit subhramit requested a review from calixtus September 4, 2025 09:00
@Siedlerchr Siedlerchr enabled auto-merge September 4, 2025 10:04
@calixtus

calixtus commented Sep 4, 2025

Copy link
Copy Markdown
Member

Nice! Clean code, quick fix. Love it.

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 4, 2025
Merged via the queue into JabRef:main with commit 7d6485d Sep 4, 2025
37 checks passed
Siedlerchr added a commit that referenced this pull request Sep 8, 2025
* upstream/main: (54 commits)
  Split relativizeSymlinks parameterized tests in separate tests (#13782)
  Update the search syntax highlight for web search (#13801)
  Chore(deps): Bump ai.djl:bom from 0.33.0 to 0.34.0 in /versions (#13833)
  Fix typos in CHANGELOG.md (#13826)
  Chore(deps): Bump com.konghq:unirest-modules-gson in /versions (#13831)
  Chore(deps): Bump org.gradlex:extra-java-module-info in /build-logic (#13830)
  Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (#13832)
  Chore(deps): Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#13834)
  Chore(deps): Bump jablib/src/main/resources/csl-locales (#13829)
  Chore(deps): Bump jablib/src/main/resources/csl-styles (#13827)
  Chore(deps): Bump jablib/src/main/abbrv.jabref.org (#13828)
  add: CAYW endpoint formats (#13785)
  New Crowdin updates (#13823)
  chore(deps): update dependency org.kohsuke:github-api to v2.0-rc.5 (#13822)
  Add support for automatic ICORE conference ranking lookup [#13476] (#13699)
  New Crowdin updates (#13820)
  Initialize search bar auto-completion with real database context (no tab switch needed) (#13816)
  Fixes #13274: Allow cygwin-paths on Windows (#13297)
  Refine "REDACTED" replacement of API key value in web fetcher search URL (#13814)
  changed ISSNCleanup into NormalizeIssn, refactored respective tests #13748 (#13767)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-Completion in search bar not working until switching tabs

4 participants