Split relativizeSymlinks parameterized tests in separate tests#13782
Merged
Conversation
…ion and OpenSelectedEntriesFilesAction - Introduced OpenSingleExternalFileAction to handle single entry with one linked file - Introduced OpenSelectedEntriesFilesAction to handle multiple selection cases Fixes JabRef#13431
…13505) Bumps [org.junit.platform:junit-platform-launcher](https://github.com/junit-team/junit-framework) from 1.13.1 to 1.13.3. - [Release notes](https://github.com/junit-team/junit-framework/releases) - [Commits](https://github.com/junit-team/junit-framework/commits) --- updated-dependencies: - dependency-name: org.junit.platform:junit-platform-launcher dependency-version: 1.13.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
…resolution - Use real/canonical paths to ensure files are correctly recognized as within a directory, even through symlinks - Add and document unit tests covering symlinked and normal directory scenarios fixes JabRef#12995
…Path and remove unnecessary comments
…bref into fix-for-issue-12995
… simplicity, and ensured all edge cases from issue JabRef#12995 are now covered.
…bref into fix-for-issue-12995
…bref into fix-for-issue-12995
|
@trag-bot didn't find any issues in the code! ✅✨ |
Member
|
Please clean up the git history. |
Member
I think, its OK this time - diff is right. Next time @Muskan244 please base on latest |
Contributor
Author
|
Got it, thanks! I’ll rebase on the latest main in future PRs. |
Member
No need for rebase: git fetch upstream git checkout upstream/main git checkout -b newbranch (There are surely more easy steps, but this is what I do) |
Contributor
Author
|
Thanks for clarifying, I’ll use this approach from next time. |
Siedlerchr
approved these changes
Sep 8, 2025
Siedlerchr
added a commit
that referenced
this pull request
Sep 8, 2025
* upstream/main: (54 commits) Split relativizeSymlinks parameterized tests in separate tests (#13782) Update the search syntax highlight for web search (#13801) Chore(deps): Bump ai.djl:bom from 0.33.0 to 0.34.0 in /versions (#13833) Fix typos in CHANGELOG.md (#13826) Chore(deps): Bump com.konghq:unirest-modules-gson in /versions (#13831) Chore(deps): Bump org.gradlex:extra-java-module-info in /build-logic (#13830) Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (#13832) Chore(deps): Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#13834) Chore(deps): Bump jablib/src/main/resources/csl-locales (#13829) Chore(deps): Bump jablib/src/main/resources/csl-styles (#13827) Chore(deps): Bump jablib/src/main/abbrv.jabref.org (#13828) add: CAYW endpoint formats (#13785) New Crowdin updates (#13823) chore(deps): update dependency org.kohsuke:github-api to v2.0-rc.5 (#13822) Add support for automatic ICORE conference ranking lookup [#13476] (#13699) New Crowdin updates (#13820) Initialize search bar auto-completion with real database context (no tab switch needed) (#13816) Fixes #13274: Allow cygwin-paths on Windows (#13297) Refine "REDACTED" replacement of API key value in web fetcher search URL (#13814) changed ISSNCleanup into NormalizeIssn, refactored respective tests #13748 (#13767) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #13553 based on review by @koppor.
This PR improves the readability of the code by splitting relativizeSymlinks() parameterized test cases into separate test cases.
Steps to test
Gradle: ./gradlew test
Ensure all tests in FileUtilTest related to symlink handling pass without errors.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)