-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Make ISSNCleanup a Formatter #13748
Copy link
Copy link
Labels
component: cleanup-opsgood first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.size: small📍 AssignedAssigned by assign-issue-action (or manually assigned)Assigned by assign-issue-action (or manually assigned)
Metadata
Metadata
Assignees
Labels
component: cleanup-opsgood first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.size: small📍 AssignedAssigned by assign-issue-action (or manually assigned)Assigned by assign-issue-action (or manually assigned)
Type
Fields
Give feedbackNo fields configured for task.
Projects
StatusShow more project fields
Done
JabRef allows for fixing field content. Example: Use only one space instead of multiple ones in a field. These is called "formatters" in JabRef.
Example: org.jabref.logic.formatter.bibtexfields.NormalizeWhitespaceFormatter
The class
org.jabref.logic.cleanup.ISSNCleanupis such a formatter, but its implemetned as Cleanup. Which is wrong. --> CleanUps are used for multi-field operations.Task
org.jabref.logic.cleanup.ISSNCleanupto packageorg.jabref.logic.formatter.bibtexfieldsNormalizeIssnextends Formatter(removeimplements CleanupJob)org.jabref.logic.cleanup.FieldFormatterCleanups#DEFAULT_SAVE_ACTIONS(only for fieldorg.jabref.model.entry.field.StandardField#ISSN)Micro task:
Fix formatting in
jabgui/src/main/resources/org/jabref/gui/cleanup/CleanupPresetPanel.fxml- the indent is wrong. (from line 48 on)This is a follow-up to #1590.