-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Allow cygwin-paths on Windows #13274
Copy link
Copy link
Labels
component: JabKit [cli]good first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.platform: windows📌 Pinned📍 AssignedAssigned by assign-issue-action (or manually assigned)Assigned by assign-issue-action (or manually assigned)
Metadata
Metadata
Assignees
Labels
component: JabKit [cli]good first issueAn issue intended for project-newcomers. Varies in difficulty.An issue intended for project-newcomers. Varies in difficulty.platform: windows📌 Pinned📍 AssignedAssigned by assign-issue-action (or manually assigned)Assigned by assign-issue-action (or manually assigned)
Type
Fields
Give feedbackNo fields configured for task.
Projects
StatusShow more project fields
Done
I start git bash on Windows.
I run
I get
I think, we need to internally map these paths to Windows paths (if file not found)
/c/toC:\\/to\\Then, the above command will run
File path changing code nees to go into
org.jabref.logic.util.io.FileUtilMethod
convertCygwinPathToWindows.Should do conversion only if
org.jabref.logic.os.OS.WINDOWSis true otherwise, return identifiy of parameterTesting: A test case for Windows is needed.
Use
A separate test for non-windows, is needed, too