Skip to content

Fix CHANGELOG.md linting issues#10351

Merged
koppor merged 1 commit into
mainfrom
fix-changelog
Sep 8, 2023
Merged

Fix CHANGELOG.md linting issues#10351
koppor merged 1 commit into
mainfrom
fix-changelog

Conversation

@koppor

@koppor koppor commented Sep 8, 2023

Copy link
Copy Markdown
Member

I run the CHANGELOG.md linter heylogs on our CHANGELOG.md. The errors were as follows:

     8:47   error  Expecting HTTPS protocol                      https
   249:164  error  Expecting GitHub issue ref 8484, found 8448   github-issue-ref
   249:439  error  Expecting GitHub issue ref 6000, found 6002   github-issue-ref
   270:72   error  Expecting GitHub issue ref 9147, found 9175   github-issue-ref
   396:118  error  Expecting GitHub issue ref 8510, found 8150   github-issue-ref
   423:318  error  Expecting GitHub issue ref 7012, found 7102   github-issue-ref
   432:148  error  Expecting GitHub issue ref 7012, found 7102   github-issue-ref
   503:100  error  Expecting GitHub issue ref 7882, found 7892   github-issue-ref
   550:70   error  Expecting GitHub issue ref 72, found 7267     github-issue-ref
   580:134  error  Expecting GitHub issue ref 6267, found 1018   github-issue-ref
   734:77   error  Expecting GitHub issue ref 6604, found 6643   github-issue-ref
   877:91   error  Expecting GitHub issue ref 5622, found 56220  github-issue-ref
   996:109  error  Expecting HTTPS protocol                      https
  1022:111  error  Expecting GitHub issue ref 4745, found 4746   github-issue-ref
  1046:94   error  Expecting GitHub issue ref 4847, found 4874   github-issue-ref
  1064:111  error  Expecting HTTPS protocol                      https
  1065:98   error  Expecting HTTPS protocol                      https
  1095:161  error  Expecting GitHub issue ref 2016, found 4932   github-issue-ref
  1121:1    error  Missing ref link                              entry-for-every-versions

I fixed nearly all of them. I could not fix "Missing ref link", because we have "Older version" in the heading. (For others, I needed to propose patches to the lbrary - e.g., nbbrd/heylogs#140 ^^)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 8, 2023
@JabRef JabRef deleted a comment from github-actions Bot Sep 8, 2023
@koppor koppor merged commit 634d91d into main Sep 8, 2023
@koppor koppor deleted the fix-changelog branch September 8, 2023 21:45
@github-actions

github-actions Bot commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor mentioned this pull request Sep 8, 2023
Merged
6 tasks
Siedlerchr added a commit that referenced this pull request Sep 9, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into addAddContentToImage
0337872 
* upstream/main:
  Replacement localization (#10358)
  Add workaround for IDEA-317606
  Fix CHANGELOG.md linting issues (#10351)
  fix afterburner
  checkstyle
  add changelog
  Fix NPE when adding new aux group
  Add "--verbose" to MV generator (#10347)
  Fix dependencies (#10326)
  Add new openrewrite rules (#10342)
  New Crowdin updates (#10344)
  Rework duplicate checker tests (#10341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koppor @Siedlerchr