Rework duplicate checker tests#10341
Merged
Merged
Conversation
Contributor
|
Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues. More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html. |
Siedlerchr
previously approved these changes
Sep 7, 2023
Member
|
tests fail |
Member
Author
Fixed. |
Siedlerchr
approved these changes
Sep 7, 2023
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
added a commit
that referenced
this pull request
Sep 9, 2023
* upstream/main: Replacement localization (#10358) Add workaround for IDEA-317606 Fix CHANGELOG.md linting issues (#10351) fix afterburner checkstyle add changelog Fix NPE when adding new aux group Add "--verbose" to MV generator (#10347) Fix dependencies (#10326) Add new openrewrite rules (#10342) New Crowdin updates (#10344) Rework duplicate checker tests (#10341)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworking DuplicateCheckerTests to follow the one-assertion-per-test rule
Follow-up to #9769
(Can't continue on duplicate checker the next days; submitting the current work to enable others working on it)
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)