Fix dependencies#10326
Conversation
|
Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues. More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html. |
|
|
||
| implementation 'de.undercouch:citeproc-java:3.0.0-beta.2' | ||
| implementation('de.undercouch:citeproc-java:3.0.0-beta.2') { | ||
| exclude group: 'org.antlr' |
There was a problem hiding this comment.
This needs to be carefully tested I remembere that different asm versions were producing troubles when generating CSL citations at runtime
There was a problem hiding this comment.
My assumptions:
- The direct dependencies of
build.gradleare loaded first - In case a library with the same group and name exists, it is ignored.
|
Tested the build locally. Preview works. |
|
I would like to get this in - to have a better basis to think about a dependency on |
|
Seems like we really need to exclude the dependencies |
|
CAn you test #10339 (I updated afterburner fx) |
I merged |
remove exlcude, no longer necessay
…nto fix-dependency-conflicts * 'fix-dependency-conflicts' of github.com:JabRef/jabref: test updating javafx plugin but throws at runtime Revert "Add workaround for IDEA-317606 (#10322)" Add workaround for IDEA-317606 (#10322) New Crowdin updates (#10335) Add change in en.properties as well Correction of a typo in LinkedFileViewModel.java Fix devcontainer prebuilds (#10333) Add requires on org.freedesktop.dbus (#10332) Fix hint to menu
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
* upstream/main: Replacement localization (#10358) Add workaround for IDEA-317606 Fix CHANGELOG.md linting issues (#10351) fix afterburner checkstyle add changelog Fix NPE when adding new aux group Add "--verbose" to MV generator (#10347) Fix dependencies (#10326) Add new openrewrite rules (#10342) New Crowdin updates (#10344) Rework duplicate checker tests (#10341)
This refs #10274 (comment).
I checked the
RuntimeClasspath(!) and did not see anyasmthere. Thus, this does not fix . #10274, but at least improves the state of dependencies:I also removed the task
downloadDependencies, because dependency caching works better these days.Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)