Skip to content

Add new openrewrite rules#10342

Merged
Siedlerchr merged 2 commits into
mainfrom
openrewrite
Sep 7, 2023
Merged

Add new openrewrite rules#10342
Siedlerchr merged 2 commits into
mainfrom
openrewrite

Conversation

@koppor

@koppor koppor commented Sep 7, 2023

Copy link
Copy Markdown
Member

I went through the changelogs of OpenRewrite and added following rewrites:

No efffects:


Side comment: Created upstream issue openrewrite/rewrite-testing-frameworks#403, because matched is output multiple times when running

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the dev: code-quality Issues related to code or architecture decisions label Sep 7, 2023
Comment thread src/test/java/org/jabref/gui/theme/ThemeManagerTest.java Outdated
@github-actions

github-actions Bot commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.

More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html.

@github-actions

github-actions Bot commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 7, 2023
@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 7, 2023
Merged via the queue into main with commit b3372fa Sep 7, 2023
@Siedlerchr Siedlerchr deleted the openrewrite branch September 7, 2023 16:25
Siedlerchr added a commit that referenced this pull request Sep 9, 2023
* upstream/main:
  Replacement localization (#10358)
  Add workaround for IDEA-317606
  Fix CHANGELOG.md linting issues (#10351)
  fix afterburner
  checkstyle
  add changelog
  Fix NPE when adding new aux group
  Add "--verbose" to MV generator (#10347)
  Fix dependencies (#10326)
  Add new openrewrite rules (#10342)
  New Crowdin updates (#10344)
  Rework duplicate checker tests (#10341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants