Skip to content

Apr/f32 qa set1#9

Open
RooseweltMcW wants to merge 4 commits intoHazarathKumarM:hk/developfrom
RooseweltMcW:apr/f32_qa_set1
Open

Apr/f32 qa set1#9
RooseweltMcW wants to merge 4 commits intoHazarathKumarM:hk/developfrom
RooseweltMcW:apr/f32_qa_set1

Conversation

@RooseweltMcW
Copy link
Copy Markdown
Collaborator

F32 test suite QA golden output updates for 8 kernels
Remap - 79
Flip - 20
Glitch - 35
Ricap - 82
Non linear blend - 30
Gridmask - 83
color to greyscale - 86
color temperature - 45

kiritigowda and others added 4 commits August 11, 2025 13:54
* CMake Config - updates

* Git - Ignore old version files

* RPP - Find fix
* changed amdgpu link & removed resizing of images

* fixed images

---------

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Remap - 79
Flip - 20
Glitch - 35
Ricap - 82
Non linear blend - 30
Gridmask - 83
color to greyscale - 86
color temperature - 45
HazarathKumarM pushed a commit to RooseweltMcW/rpp that referenced this pull request Dec 22, 2025
HazarathKumarM added a commit that referenced this pull request Feb 13, 2026
* Travis CI - key error fix

* Fix Bug in ColorTwist (#6) (#8) (#9)

* Added golden outputs and resolved HOST backend

* Updated bin files for median filter and resize crop mirror

* Updated bin files

* Updated bin files for the next set of kernel F32 QA

* Updated bin files for jpeg_compression_distortion

* Fixed resize QA failures

* Fix for Resize bilinear F32 QA HOST and HIP

* Fix for lens correction QA f32 for HOST and HIP for 1e-4 precision

* Fixed HIP rcm QA

* updates for warp Affine F32 QA

* Fix for RCM QA match for U8 and F32 updates AVX

* Fix for lens correction AVX

* Removed space

* Fixed warp affine for every other varient with the updated changes

* Add fixes to match precision in quantization

* Fix Precision mismatches

* Update default cutoff to 1e-5 and specialized cutoff to 1e-4

* F32 QA Fix

* Made Quality percentage as arg from testsuite

* Resolved copilot comments

* Resolved the copilot comments

* Resolved Codex comments

* HOST and HIP - pinned buffers for respective API (ROCm#628)

* Removed memcpy and used hipHostMalloc for allocation : blend

* Removed memcpy and used hipHostMalloc for allocation : brightness

* Removed memcpy and used hipHostMalloc for allocation : color cast

* Removed memcpy and used hipHostMalloc for allocation : color twist

* Removed memcpy and used hipHostMalloc for allocation : contrast

* Removed memcpy and used hipHostMalloc for allocation : crop mirror normalize

* Removed memcpy and used hipHostMalloc for allocation : Exposure

* Removed memcpy and used hipHostMalloc for allocation : Gamma correction

* Removed memcpy and used hipHostMalloc for allocation : gaussian filter

* Removed memcpy and used hipHostMalloc for allocation : Noise

* Removed memcpy and used hipHostMalloc for allocation : Non linear blend

* Removed memcpy and used hipHostMalloc for allocation : Resize mirror normalize

* Removed memcpy and used hipHostMalloc for allocation : Water

* Added hipHostFree for all kernels in test suite

* Added hipHostFree for all kernels in test suite

* Removed memcpy and used hipHostMalloc for allocation : Flip, spatter, rcm, color temperature

* Resolved copilot review comments

* Updated version

* Removed unused parameter

* Updated version in cmakeList

* removed the host to device mem copies for warp affine and rotate

* Updated version

* Removed comment

* Updated Chnagelog file

* Update patch version from 2.2.0 to 2.2.1

* Update CHANGELOG

* Address copilot comments for HIP HOST consistent allocation

* Documentation changes for updated memcpy changes

* Update ricap outer API to use pinned memory and remove mem copy

* Fix memory allocation and deallocation for permutationTensor

* Update api/rppt_tensor_effects_augmentations.h

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix spelling of noiseProbability and saltProbability

* Fix deallocation

---------

Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* resolved review comments

* minor comment change

* Resolved copilot review comments

* Update src/modules/tensor/cpu/kernel/resize.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/modules/tensor/cpu/kernel/resize.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/modules/tensor/hip/kernel/jpeg_compression_distortion.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Updated test suite and resoled review comments

* Updated HIP for F32 QA reduction function cases

---------

Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com>
Co-authored-by: Lokesh Bonta <lokeswara@multicorewareinc.com>
Co-authored-by: sampath117 <snehaa@multicorewareinc.com>
Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: ManasaDattaT <tammisetti.manasadatta@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>
HazarathKumarM added a commit to RooseweltMcW/rpp that referenced this pull request Feb 18, 2026
* add support for dilate in HOST backend

* minor fix in changelog

* added golden outputs

remove commented code

* resolve build errors

* Add padding changes in HIP backend

* fix sigsev issues

* fix QA for 9x9 kernel

* Add if condition for pack function and template for unpack and signext function

* Fix the rename of preLoadRows and max  Comments

* Fix Fix remane of Loader and MorphVecLoader

* Fix empty space, dilate_row_hip_compute function, removed if & else and aligned indent R.

* Fix remove whitespace and restored all unnecessary changes.

* Fix remove precision line and reverted back to static cast.

* Fix remove empty line, rename of kernelSze & padPolicy and remove {} for single line condition

* Fix Indentation of IF condition.

* resolved review comments

* resolve review comments

* Test suite - Add QA pass/fail tests for F32 bit depth (ROCm#665)

* Travis CI - key error fix

* Fix Bug in ColorTwist (HazarathKumarM#6) (HazarathKumarM#8) (HazarathKumarM#9)

* Added golden outputs and resolved HOST backend

* Updated bin files for median filter and resize crop mirror

* Updated bin files

* Updated bin files for the next set of kernel F32 QA

* Updated bin files for jpeg_compression_distortion

* Fixed resize QA failures

* Fix for Resize bilinear F32 QA HOST and HIP

* Fix for lens correction QA f32 for HOST and HIP for 1e-4 precision

* Fixed HIP rcm QA

* updates for warp Affine F32 QA

* Fix for RCM QA match for U8 and F32 updates AVX

* Fix for lens correction AVX

* Removed space

* Fixed warp affine for every other varient with the updated changes

* Add fixes to match precision in quantization

* Fix Precision mismatches

* Update default cutoff to 1e-5 and specialized cutoff to 1e-4

* F32 QA Fix

* Made Quality percentage as arg from testsuite

* Resolved copilot comments

* Resolved the copilot comments

* Resolved Codex comments

* HOST and HIP - pinned buffers for respective API (ROCm#628)

* Removed memcpy and used hipHostMalloc for allocation : blend

* Removed memcpy and used hipHostMalloc for allocation : brightness

* Removed memcpy and used hipHostMalloc for allocation : color cast

* Removed memcpy and used hipHostMalloc for allocation : color twist

* Removed memcpy and used hipHostMalloc for allocation : contrast

* Removed memcpy and used hipHostMalloc for allocation : crop mirror normalize

* Removed memcpy and used hipHostMalloc for allocation : Exposure

* Removed memcpy and used hipHostMalloc for allocation : Gamma correction

* Removed memcpy and used hipHostMalloc for allocation : gaussian filter

* Removed memcpy and used hipHostMalloc for allocation : Noise

* Removed memcpy and used hipHostMalloc for allocation : Non linear blend

* Removed memcpy and used hipHostMalloc for allocation : Resize mirror normalize

* Removed memcpy and used hipHostMalloc for allocation : Water

* Added hipHostFree for all kernels in test suite

* Added hipHostFree for all kernels in test suite

* Removed memcpy and used hipHostMalloc for allocation : Flip, spatter, rcm, color temperature

* Resolved copilot review comments

* Updated version

* Removed unused parameter

* Updated version in cmakeList

* removed the host to device mem copies for warp affine and rotate

* Updated version

* Removed comment

* Updated Chnagelog file

* Update patch version from 2.2.0 to 2.2.1

* Update CHANGELOG

* Address copilot comments for HIP HOST consistent allocation

* Documentation changes for updated memcpy changes

* Update ricap outer API to use pinned memory and remove mem copy

* Fix memory allocation and deallocation for permutationTensor

* Update api/rppt_tensor_effects_augmentations.h

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix spelling of noiseProbability and saltProbability

* Fix deallocation

---------

Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* resolved review comments

* minor comment change

* Resolved copilot review comments

* Update src/modules/tensor/cpu/kernel/resize.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/modules/tensor/cpu/kernel/resize.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/modules/tensor/hip/kernel/jpeg_compression_distortion.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Updated test suite and resoled review comments

* Updated HIP for F32 QA reduction function cases

---------

Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com>
Co-authored-by: Lokesh Bonta <lokeswara@multicorewareinc.com>
Co-authored-by: sampath117 <snehaa@multicorewareinc.com>
Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: ManasaDattaT <tammisetti.manasadatta@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>

* Erode - HOST and HIP update (ROCm#666)

* added initial api support for erode

* added support for U8 and I8 bitdepths for 3, 5, 7, 9 kernel sizes

* added F16 and F32 bitdepth support

* added generic kernel support

* added golden outputs

removed commented code

* fix build errors

* Fix build and test_suite errors

* revert padding changes

* updated erode HIP kernel with latest changes

* Add F32 QA

* minor formatting fixes

* minor comment fix

* resolve copilot comments

* resolve review comments

* resolved review comments

* Add unpack templating changes and fix segmentation issue

* Fix PKD to PKD kernel 9  for Pack and Unpack changes.

* Add and template signext function

* Fix min Comments

* Fix one min Comments

* Add unroll and rename of preLoadRows

* Fix remane of Loader and MorphVecLoader

* Add empty line before comment

* Fix remove empty line, rename of kernelSze & padPolicy and remove {} for single line condition

* resolved review comments

* fix build warnings

---------

Co-authored-by: sampath1117 <sampath.rachumallu@multicorewareinc.com>
Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Mukesh Jayakodi <mukesh.jayakodi@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: HazarathKumarM <119284987+HazarathKumarM@users.noreply.github.com>
Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>

* fix build errors

---------

Co-authored-by: sampath1117 <sampath.rachumallu@multicorewareinc.com>
Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Mukesh Jayakodi <mukesh.jayakodi@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: HazarathKumarM <119284987+HazarathKumarM@users.noreply.github.com>
Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com>
Co-authored-by: Lokesh Bonta <lokeswara@multicorewareinc.com>
Co-authored-by: sampath117 <snehaa@multicorewareinc.com>
Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: ManasaDattaT <tammisetti.manasadatta@multicorewareinc.com>
Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants