Skip to content

Find RPP - standardize include files#596

Merged
kiritigowda merged 1 commit intoROCm:developfrom
kiritigowda:kg/rpp-find-fix
Aug 12, 2025
Merged

Find RPP - standardize include files#596
kiritigowda merged 1 commit intoROCm:developfrom
kiritigowda:kg/rpp-find-fix

Conversation

@kiritigowda
Copy link
Copy Markdown
Collaborator

@kiritigowda kiritigowda commented Aug 11, 2025

Motivation

Find RPP - standardize include files

Technical Details

Use ROCM_PATH/include as rpp include directory

Test Plan

All existing tests should play

Test Result

All tests should pass

Submission Checklist

@kiritigowda kiritigowda self-assigned this Aug 11, 2025
Copilot AI reviewed Aug 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the include file paths for RPP (ROCm Performance Primitives) headers by updating CMakeLists.txt files to use the standardized rpp/ subdirectory structure. The changes align with using ROCM_PATH/include as the standard RPP include directory.

  • Updates include paths from direct header references to rpp/ subdirectory structure
  • Modifies backend and audio augmentation support header checks across test suites
  • Ensures consistency across HOST, HIP, and general test suite configurations

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
utilities/test_suite/HOST/CMakeLists.txt Updates RPP header paths to use rpp/ subdirectory for backend and audio support checks
utilities/test_suite/HIP/CMakeLists.txt Updates RPP header paths to use rpp/ subdirectory for backend and audio support checks
utilities/test_suite/CMakeLists.txt Updates RPP header paths to use rpp/ subdirectory for backend and audio support checks

@kiritigowda
Copy link
Copy Markdown
Collaborator Author

kiritigowda commented Aug 12, 2025

Running all tests with updated include look up

Test project /home/user/_work/1/s/rpp-tests
    Start 1: rpp_qa_tests_tensor_image_host_all
1/8 Test #1: rpp_qa_tests_tensor_image_host_all ...   Passed  343.13 sec
    Start 2: rpp_qa_tests_tensor_voxel_host_all
2/8 Test #2: rpp_qa_tests_tensor_voxel_host_all ...   Passed   22.95 sec
    Start 3: rpp_qa_tests_tensor_audio_host_all
3/8 Test #3: rpp_qa_tests_tensor_audio_host_all ...   Passed    7.97 sec
    Start 4: rpp_qa_tests_tensor_misc_host_all
4/8 Test #4: rpp_qa_tests_tensor_misc_host_all ....   Passed    7.91 sec
    Start 5: rpp_qa_tests_tensor_image_hip_all
5/8 Test #5: rpp_qa_tests_tensor_image_hip_all ....   Passed  461.82 sec
    Start 6: rpp_qa_tests_tensor_voxel_hip_all
6/8 Test #6: rpp_qa_tests_tensor_voxel_hip_all ....   Passed   28.28 sec
    Start 7: rpp_qa_tests_tensor_audio_hip_all
7/8 Test #7: rpp_qa_tests_tensor_audio_hip_all ....   Passed   14.54 sec
    Start 8: rpp_qa_tests_tensor_misc_hip_all
8/8 Test #8: rpp_qa_tests_tensor_misc_hip_all .....   Passed   14.18 sec

100% tests passed, 0 tests failed out of 8

Total Test time (real) = 900.82 sec

@kiritigowda kiritigowda merged commit 18dfbc9 into ROCm:develop Aug 12, 2025
6 of 8 checks passed
@kiritigowda kiritigowda deleted the kg/rpp-find-fix branch August 12, 2025 21:41
ManasaDattaT pushed a commit to ManasaDattaT/rpp that referenced this pull request Dec 19, 2025
@kiritigowda
Find RPP - standardize include files (ROCm#596)
247da24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@rrawther rrawther Awaiting requested review from rrawther

@r-abishek r-abishek Awaiting requested review from r-abishek

@LakshmiKumar23 LakshmiKumar23 Awaiting requested review from LakshmiKumar23

Assignees

@kiritigowda kiritigowda

Labels

BugFix ci:precheckin enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kiritigowda