Apr/misc test suite by RooseweltMcW · Pull Request #8 · HazarathKumarM/rpp

RooseweltMcW · 2025-08-11T10:37:24Z

For 2D generate input for U8 and golden outputs
4D Float input file regenerate in range 0 -10 for F32
Modified test suite to support both F32 and U8 bitdepth
U8 input file generation 0 - 255 (2D, 4D)
Golden output generation for U8/4D F32

…ated and QA generated

…n for U8 3Dim and golden output for U8 3Dim

HazarathKumarM · 2025-08-11T10:39:42Z

utilities/test_suite/rpp_test_suite_misc.h

            }
+            case 4:
+            {
+                numValues = 18630;


Add some comment here

HazarathKumarM · 2025-08-11T10:40:24Z

utilities/test_suite/rpp_test_suite_misc.h

        int meanStdDevOutputStride = 0, axisMaskStride = 0;
        if(isMeanStd)
-            meanStdDevOutputStride = goldenOutputLength / (2 * sizeof(Rpp32f));
+            meanStdDevOutputStride = goldenOutputLength / 2;


why is it changed?

HazarathKumarM · 2025-08-11T10:40:44Z

utilities/test_suite/rpp_test_suite_misc.h

    int sampleLength = bufferLength / batchSize;
    int fileMatch = 0;
-    for(int i = 0; i < batchSize; i++)
+    for (int i = 0; i < batchSize; i++)


remove the space you added

HazarathKumarM · 2025-08-11T10:41:26Z

utilities/test_suite/rpp_test_suite_misc.h

    }

+    std::string bitDepthStr;
+    switch (bitDepth)


Add a comment here

Removed the switch case because it is being used in the Main function

HazarathKumarM · 2025-08-11T10:41:56Z

utilities/test_suite/rpp_test_suite_misc.h

+    funcName = funcName + "_" + bitDepthStr;
    std::string status = funcName + ": ";
-    cout << std::endl << "Results for Test case: " << funcName << std::endl;
+    std::cout << "\nResults for Test case: " << funcName << std::endl;


why this is changed?

HazarathKumarM · 2025-08-11T10:46:12Z

utilities/test_suite/HOST/Tensor_misc_host.cpp

    }

-    if(DEBUG_MODE)
+    if(DEBUG_MODE && bitDepth == 2)


it should just be DEBUG_MODE

HazarathKumarM · 2025-08-11T10:47:59Z

utilities/test_suite/HIP/Tensor_misc_hip.cpp


-    string func = funcName;
-    if (axisMaskCase)
+    std::string bitdepthStr;


add some comment here

HazarathKumarM · 2025-08-11T10:49:48Z

utilities/test_suite/HIP/Tensor_misc_hip.cpp

-    inputSecond = static_cast<Rpp32f *>(calloc(iBufferSizeSecondInBytes, 1));
-    output = static_cast<Rpp32f *>(calloc(oBufferSizeInBytes, 1));
+    // allocate memory for input / output
+    // Host pointers (pinned memory)


Don't allocate pinned memoryfor every thing input and output has to be HOST mem only

HazarathKumarM · 2025-08-11T10:51:09Z

utilities/test_suite/HIP/Tensor_misc_hip.cpp

    }
-
-    // Convert inputs to correponding bit depth specified by user
-    convert_input_bitdepth(inputF32, inputF32Second, input, inputSecond, bitDepth, iBufferSize, iBufferSizeSecond, iBufferSizeInBytes, iBufferSizeSecondInBytes, srcDescriptorPtrND, srcDescriptorPtrNDSecond, testCase);


please revert these changes, these changes will slow down the process

HazarathKumarM · 2025-08-11T10:52:56Z

src/modules/tensor/cpu/kernel/normalize.cpp

        for(Rpp32u k = 0; k < length[level]; k++)
        {
-            *dstPtrTemp = (((T2)*srcPtrTemp - meanPtr[idx]) * multiplierPtr[idx]) + shift;
+            if constexpr (std::is_same<T2, Rpp8u>::value)


remove {} brackets

…tion

Misc test suite updates

* Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

…eous test suite

…KumarM#9)

* Travis CI - key error fix * Fix Bug in ColorTwist (#6) (#8) (#9) * Added golden outputs and resolved HOST backend * Updated bin files for median filter and resize crop mirror * Updated bin files * Updated bin files for the next set of kernel F32 QA * Updated bin files for jpeg_compression_distortion * Fixed resize QA failures * Fix for Resize bilinear F32 QA HOST and HIP * Fix for lens correction QA f32 for HOST and HIP for 1e-4 precision * Fixed HIP rcm QA * updates for warp Affine F32 QA * Fix for RCM QA match for U8 and F32 updates AVX * Fix for lens correction AVX * Removed space * Fixed warp affine for every other varient with the updated changes * Add fixes to match precision in quantization * Fix Precision mismatches * Update default cutoff to 1e-5 and specialized cutoff to 1e-4 * F32 QA Fix * Made Quality percentage as arg from testsuite * Resolved copilot comments * Resolved the copilot comments * Resolved Codex comments * HOST and HIP - pinned buffers for respective API (ROCm#628) * Removed memcpy and used hipHostMalloc for allocation : blend * Removed memcpy and used hipHostMalloc for allocation : brightness * Removed memcpy and used hipHostMalloc for allocation : color cast * Removed memcpy and used hipHostMalloc for allocation : color twist * Removed memcpy and used hipHostMalloc for allocation : contrast * Removed memcpy and used hipHostMalloc for allocation : crop mirror normalize * Removed memcpy and used hipHostMalloc for allocation : Exposure * Removed memcpy and used hipHostMalloc for allocation : Gamma correction * Removed memcpy and used hipHostMalloc for allocation : gaussian filter * Removed memcpy and used hipHostMalloc for allocation : Noise * Removed memcpy and used hipHostMalloc for allocation : Non linear blend * Removed memcpy and used hipHostMalloc for allocation : Resize mirror normalize * Removed memcpy and used hipHostMalloc for allocation : Water * Added hipHostFree for all kernels in test suite * Added hipHostFree for all kernels in test suite * Removed memcpy and used hipHostMalloc for allocation : Flip, spatter, rcm, color temperature * Resolved copilot review comments * Updated version * Removed unused parameter * Updated version in cmakeList * removed the host to device mem copies for warp affine and rotate * Updated version * Removed comment * Updated Chnagelog file * Update patch version from 2.2.0 to 2.2.1 * Update CHANGELOG * Address copilot comments for HIP HOST consistent allocation * Documentation changes for updated memcpy changes * Update ricap outer API to use pinned memory and remove mem copy * Fix memory allocation and deallocation for permutationTensor * Update api/rppt_tensor_effects_augmentations.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix spelling of noiseProbability and saltProbability * Fix deallocation --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * resolved review comments * minor comment change * Resolved copilot review comments * Update src/modules/tensor/cpu/kernel/resize.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/cpu/kernel/resize.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/hip/kernel/jpeg_compression_distortion.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Updated test suite and resoled review comments * Updated HIP for F32 QA reduction function cases --------- Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com> Co-authored-by: Lokesh Bonta <lokeswara@multicorewareinc.com> Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: ManasaDattaT <tammisetti.manasadatta@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>

* add support for dilate in HOST backend * minor fix in changelog * added golden outputs remove commented code * resolve build errors * Add padding changes in HIP backend * fix sigsev issues * fix QA for 9x9 kernel * Add if condition for pack function and template for unpack and signext function * Fix the rename of preLoadRows and max Comments * Fix Fix remane of Loader and MorphVecLoader * Fix empty space, dilate_row_hip_compute function, removed if & else and aligned indent R. * Fix remove whitespace and restored all unnecessary changes. * Fix remove precision line and reverted back to static cast. * Fix remove empty line, rename of kernelSze & padPolicy and remove {} for single line condition * Fix Indentation of IF condition. * resolved review comments * resolve review comments * Test suite - Add QA pass/fail tests for F32 bit depth (ROCm#665) * Travis CI - key error fix * Fix Bug in ColorTwist (HazarathKumarM#6) (HazarathKumarM#8) (HazarathKumarM#9) * Added golden outputs and resolved HOST backend * Updated bin files for median filter and resize crop mirror * Updated bin files * Updated bin files for the next set of kernel F32 QA * Updated bin files for jpeg_compression_distortion * Fixed resize QA failures * Fix for Resize bilinear F32 QA HOST and HIP * Fix for lens correction QA f32 for HOST and HIP for 1e-4 precision * Fixed HIP rcm QA * updates for warp Affine F32 QA * Fix for RCM QA match for U8 and F32 updates AVX * Fix for lens correction AVX * Removed space * Fixed warp affine for every other varient with the updated changes * Add fixes to match precision in quantization * Fix Precision mismatches * Update default cutoff to 1e-5 and specialized cutoff to 1e-4 * F32 QA Fix * Made Quality percentage as arg from testsuite * Resolved copilot comments * Resolved the copilot comments * Resolved Codex comments * HOST and HIP - pinned buffers for respective API (ROCm#628) * Removed memcpy and used hipHostMalloc for allocation : blend * Removed memcpy and used hipHostMalloc for allocation : brightness * Removed memcpy and used hipHostMalloc for allocation : color cast * Removed memcpy and used hipHostMalloc for allocation : color twist * Removed memcpy and used hipHostMalloc for allocation : contrast * Removed memcpy and used hipHostMalloc for allocation : crop mirror normalize * Removed memcpy and used hipHostMalloc for allocation : Exposure * Removed memcpy and used hipHostMalloc for allocation : Gamma correction * Removed memcpy and used hipHostMalloc for allocation : gaussian filter * Removed memcpy and used hipHostMalloc for allocation : Noise * Removed memcpy and used hipHostMalloc for allocation : Non linear blend * Removed memcpy and used hipHostMalloc for allocation : Resize mirror normalize * Removed memcpy and used hipHostMalloc for allocation : Water * Added hipHostFree for all kernels in test suite * Added hipHostFree for all kernels in test suite * Removed memcpy and used hipHostMalloc for allocation : Flip, spatter, rcm, color temperature * Resolved copilot review comments * Updated version * Removed unused parameter * Updated version in cmakeList * removed the host to device mem copies for warp affine and rotate * Updated version * Removed comment * Updated Chnagelog file * Update patch version from 2.2.0 to 2.2.1 * Update CHANGELOG * Address copilot comments for HIP HOST consistent allocation * Documentation changes for updated memcpy changes * Update ricap outer API to use pinned memory and remove mem copy * Fix memory allocation and deallocation for permutationTensor * Update api/rppt_tensor_effects_augmentations.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix spelling of noiseProbability and saltProbability * Fix deallocation --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * resolved review comments * minor comment change * Resolved copilot review comments * Update src/modules/tensor/cpu/kernel/resize.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/cpu/kernel/resize.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/hip/kernel/jpeg_compression_distortion.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Updated test suite and resoled review comments * Updated HIP for F32 QA reduction function cases --------- Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com> Co-authored-by: Lokesh Bonta <lokeswara@multicorewareinc.com> Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: ManasaDattaT <tammisetti.manasadatta@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> * Erode - HOST and HIP update (ROCm#666) * added initial api support for erode * added support for U8 and I8 bitdepths for 3, 5, 7, 9 kernel sizes * added F16 and F32 bitdepth support * added generic kernel support * added golden outputs removed commented code * fix build errors * Fix build and test_suite errors * revert padding changes * updated erode HIP kernel with latest changes * Add F32 QA * minor formatting fixes * minor comment fix * resolve copilot comments * resolve review comments * resolved review comments * Add unpack templating changes and fix segmentation issue * Fix PKD to PKD kernel 9 for Pack and Unpack changes. * Add and template signext function * Fix min Comments * Fix one min Comments * Add unroll and rename of preLoadRows * Fix remane of Loader and MorphVecLoader * Add empty line before comment * Fix remove empty line, rename of kernelSze & padPolicy and remove {} for single line condition * resolved review comments * fix build warnings --------- Co-authored-by: sampath1117 <sampath.rachumallu@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Mukesh Jayakodi <mukesh.jayakodi@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: HazarathKumarM <119284987+HazarathKumarM@users.noreply.github.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> * fix build errors --------- Co-authored-by: sampath1117 <sampath.rachumallu@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Mukesh Jayakodi <mukesh.jayakodi@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: HazarathKumarM <119284987+HazarathKumarM@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com> Co-authored-by: Lokesh Bonta <lokeswara@multicorewareinc.com> Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: ManasaDattaT <tammisetti.manasadatta@multicorewareinc.com> Co-authored-by: hmaddise <HazarathKumar.Maddisetty@amd.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>

snehaa8 and others added 10 commits July 30, 2025 09:12

Initial commit with modified inputs for 2, 4 Dims U8 and F32 4Dim upd…

7594d7b

…ated and QA generated

Updated Roi for 3Dim and regenerated outputs for f32, input generatio…

5393521

…n for U8 3Dim and golden output for U8 3Dim

Fixed concat for 3Dim U8 bitdepth and generated QA for Host and Hip

074cda7

Fix for normalize HOST QA 4Dim both F32 and U8

b75df35

Fix for normalize 4Dim U8 and F32

b5f5915

Fix concat issue for 4Dim

d963a13

Updated test suite for all cases and fixed every issue

fca8cb8

Test Suite fix for segmentation fault and performance issue fix

7d5bce5

HIP backend modification

759e28a

comments removed

24659c5

HazarathKumarM reviewed Aug 11, 2025

View reviewed changes

snehaa8 and others added 19 commits August 12, 2025 02:58

Resolved review comments

8b56173

Updated HIP

754b70b

Concat fix and resolved review comments

99255fa

Removed layout condition

a0d4c83

Reverted concat to the previous version

62316ca

Modified concat with added dstStrides parameter to the 3d tensor func…

f5cc602

…tion

modified HOST backend

0dac7d5

Push compilation fixes

b39fc28

Fix compilation issues on HIP

b62f6b0

HIP Changes similar to HOST

3893928

Merge pull request #1 from Srihari-mcw/misc_test_suite_updates

1e86238

Misc test suite updates

Added modified bin files with precision values set to 20

ac2fe59

Further cleanup of files

e635d0a

Check with nullptr

4f39bc4

ROCm 7.1 - Changelog updates (ROCm#625)

460a2fc

Merge branch 'current_develop' into temp_test_branch

978d7ce

Fixes for copilot comment

6ef48b7

Initial updates for cutoff

6185209

Update cutoff checks

7e9975a

Srihari-mcw and others added 18 commits October 9, 2025 07:34

Minor updates to test suite

fd2e64b

CXX Compiler - Support TheRock (ROCm#630)

c4b8ef2

Resolved review comments

7e06e84

Updates for normalize

13bc33f

Fix minor bug

7832990

Fix issues with normalize compilation

653dee6

Updated comments for paramStride

af8658f

Updated comments for more clarity

f8131d2

Additional test case added

889585f

Merge branch 'current_develop' into apr/misc_test_suite

354c712

Incorporate BitDepthTestMode into all functions

f6b0fa7

Push some fixes

ab4ee7f

Fixes for log1p QA

554d969

Changes for more consistency

e9cbd30

Update switch case

07752b6

Update paramStride for 3D cases and also update performance miscellan…

3c51d3e

…eous test suite

HazarathKumarM pushed a commit to RooseweltMcW/rpp that referenced this pull request Dec 22, 2025

Fix Bug in ColorTwist (HazarathKumarM#6) (HazarathKumarM#8) (Hazarath…

73e6f31

…KumarM#9)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apr/misc test suite#8

Apr/misc test suite#8
RooseweltMcW wants to merge 47 commits intoHazarathKumarM:hk/developfrom
RooseweltMcW:apr/misc_test_suite

RooseweltMcW commented Aug 11, 2025

Uh oh!

HazarathKumarM Aug 11, 2025

Uh oh!

HazarathKumarM Aug 11, 2025

Uh oh!

HazarathKumarM Aug 11, 2025

Uh oh!

HazarathKumarM Aug 11, 2025

Uh oh!

RooseweltMcW Aug 11, 2025

Uh oh!

HazarathKumarM Aug 11, 2025

Uh oh!

HazarathKumarM Aug 11, 2025

Uh oh!

HazarathKumarM Aug 11, 2025

Uh oh!

HazarathKumarM Aug 11, 2025

Uh oh!

HazarathKumarM Aug 11, 2025

Uh oh!

HazarathKumarM Aug 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

RooseweltMcW commented Aug 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants