Merged
Conversation
Collaborator
kiritigowda
commented
Aug 4, 2025
- Find package rpp module
- Version file auto generate
Collaborator
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
LakshmiKumar23
approved these changes
Aug 6, 2025
Collaborator
Author
|
Need to align with rocDecode after fixing issue - ROCm/rocDecode#629 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the CMake configuration for the RPP (ROCm Performance Primitives) library by implementing proper package configuration support and automatic version file generation.
- Replaces manual library/include path searches with find_package mechanism
- Adds auto-generated CMake config and version files for better package discovery
- Updates header file installation paths and generates version info from CMake variables
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utilities/test_suite/HOST/CMakeLists.txt | Updates RPP discovery to use find_package and modernizes variable naming |
| utilities/test_suite/HIP/CMakeLists.txt | Similar updates to HOST version for HIP backend tests |
| utilities/test_suite/CMakeLists.txt | Enhanced package discovery with version checks and better error handling |
| cmake_modules/rpp-config.cmake.in | New CMake package configuration template |
| api/rpp_version.h.in | New template for auto-generated version header |
| api/rpp_version.h | Removes hardcoded version header (now generated) |
| CMakeLists.txt | Adds package configuration generation and updates installation paths |
rrawther
approved these changes
Aug 11, 2025
ManasaDattaT
pushed a commit
to ManasaDattaT/rpp
that referenced
this pull request
Dec 19, 2025
* CMake Config - updates * Git - Ignore old version files * RPP - Find fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.