chore(deps): bump eslint from 9.39.2 to 10.1.0#1708
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.2 to 10.1.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.2...v10.1.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.1.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Dependency Reviewโ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF ScorecardScorecard details
Scanned Files
|
|
@copilot fix all issues want to move to latest eslint, remove any incompatible plugins unless completly necessary. |
โฆ errors - Remove eslint-plugin-import (incompatible with ESLint 10, unused in flat config) - Remove eslint-plugin-react (incompatible with ESLint 10, unused in flat config) - Remove @typescript-eslint/eslint-plugin (transitive via typescript-eslint) - Remove @typescript-eslint/parser (transitive via typescript-eslint) - Update @eslint/js from ^9.39.2 to ^10.0.0 - Add npm overrides for eslint-plugin-react-hooks peer dep - Remove legacy .eslintrc.cjs (unused with flat config) - Fix 4 no-useless-assignment errors from new ESLint 10 rules Co-authored-by: pethers <1726836+pethers@users.noreply.github.com> Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/dcef49f3-353c-4167-a2e8-39086e36a91f
chore(deps): bump eslint from 9.39.2 to 10.1.0
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
Signed-off-by: James Pether Sรถrling <pethers@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the repositoryโs linting toolchain to ESLint 10.x and aligns the project configuration/dependency set with the flat-config setup already used in eslint.config.js.
Changes:
- Bump
eslintto^10.1.0and update@eslint/jsto^10.0.0, adding an override related toeslint-plugin-react-hooks. - Remove legacy
.eslintrc.cjsand drop unused ESLint-era plugins/parsers fromdevDependencies. - Minor TypeScript adjustments (variable initialization/type annotations) to satisfy updated lint/type analysis behavior.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/systems/vitalpoint/KoreanAnatomy.ts | Tweaks local variable initialization for effect intensity calculation. |
| src/systems/ai/AdaptiveDifficulty.ts | Adjusts message variable declaration in difficulty recommendation logic. |
| src/hooks/useSkeletalAnimation.ts | Refines local variable declarations used during animation selection. |
| src/audio/VariantSelector.ts | Refines local variable declaration for variant selection index. |
| package.json | Upgrades ESLint-related deps, removes legacy lint deps, adds override. |
| package-lock.json | Lockfile changes reflecting ESLint 10 upgrade and removed packages. |
| .eslintrc.cjs | Removes legacy ESLint config file. |
package.json
Outdated
| "devDependencies": { | ||
| "@aws-sdk/client-bedrock-runtime": "^3.1015.0", | ||
| "@eslint/js": "^9.39.2", | ||
| "@aws-sdk/client-bedrock-runtime": "^3.1014.0", |
There was a problem hiding this comment.
@aws-sdk/client-bedrock-runtime is being downgraded from ^3.1015.0 to ^3.1014.0, which is unrelated to the ESLint bump and could unintentionally remove fixes. Please revert this to the previous (or newer) version unless thereโs a specific reason to downgrade.
| "@aws-sdk/client-bedrock-runtime": "^3.1014.0", | |
| "@aws-sdk/client-bedrock-runtime": "^3.1015.0", |
| "overrides": { | ||
| "eslint-plugin-react-hooks": { | ||
| "eslint": "$eslint" | ||
| } |
There was a problem hiding this comment.
eslint-plugin-react-hooks@7.0.1 still declares a peer dependency on ESLint only up to ^9 (as reflected in package-lock). With eslint@^10.1.0 this becomes an unmet peer dependency that can break npm install/npm ci under strict peer-deps. Please resolve by upgrading to a react-hooks plugin release that supports ESLint 10, or otherwise ensure CI installs are guaranteed to succeed (the current override may not be sufficient).
| "eslint": "^10.1.0", | ||
| "eslint-plugin-react-hooks": "^7.0.1", | ||
| "eslint-plugin-react-refresh": "^0.5.2", |
There was a problem hiding this comment.
This PR removes .eslintrc.cjs, but knip.json still references it as the ESLint config (eslint.config: ['.eslintrc.cjs']). That will break npm run knip / npm run find:unused. Please update Knip to use eslint.config.js (flat config) or remove the stale reference.
๐ธ Automated UI Screenshots๐ Screenshots Captured (8)
๐ฆ Download Screenshots๐ฅ Download all screenshots from workflow artifacts
๐ค Generated by Playwright automation |
|
@copilot open a new pull request to apply changes based on the comments in this thread |
โฆconfig Co-authored-by: pethers <1726836+pethers@users.noreply.github.com> Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/3eb8fbf8-ac6d-400c-92b0-4678d4c21e89
fix: address ESLint 10 migration review comments
๐ธ Automated UI Screenshots๐ Screenshots Captured (8)
๐ฆ Download Screenshots๐ฅ Download all screenshots from workflow artifacts
๐ค Generated by Playwright automation |
|
@copilot analyse and fix This branch has conflicts that must be resolved package-lock.json |
# Conflicts: # package-lock.json # package.json
fix: resolve merge conflicts with main, add missing @testing-library/dom
|
โ Asset audit failed! Please check the workflow logs for missing asset references. |
|
@copilot analyse and fix |
โฆdencies Co-authored-by: pethers <1726836+pethers@users.noreply.github.com> Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/7c47dfb0-1f3a-451a-a816-3de9bc18b5cd
fix: sync package-lock.json after ESLint 10 merge
๐ธ Automated UI Screenshots๐ Screenshots Captured (8)
๐ฆ Download Screenshots๐ฅ Download all screenshots from workflow artifacts
๐ค Generated by Playwright automation |
Bumps eslint from 9.39.2 to 10.1.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
8351ec710.1.03270bc1Build: changelog update for 10.1.0a9f9ccechore: update dependency eslint-plugin-unicorn to ^63.0.0 (#20584)1f42bd7chore: updateprettierto 3.8.1 (#20651)c0a6f4achore: update dependency@โeslint/jsonto ^1.2.0 (#20652)cc43f79chore: update dependency c8 to v11 (#20650)2ce4635chore: update dependency@โeslint/jsonto v1 (#20649)f0406eechore: update dependency markdownlint-cli2 to ^0.21.0 (#20646)dbb4c95chore: remove trunk (#20478)ff4382bfeat: apply fix forno-varinTSModuleBlock(#20638)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)