Skip to content

fix: resolve merge conflicts with main, add missing @testing-library/dom#1721

Merged
pethers merged 17 commits intodependabot/npm_and_yarn/eslint-10.1.0from
copilot/sub-pr-1708
Mar 24, 2026
Merged

fix: resolve merge conflicts with main, add missing @testing-library/dom#1721
pethers merged 17 commits intodependabot/npm_and_yarn/eslint-10.1.0from
copilot/sub-pr-1708

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

ESLint 10 migration branch conflicted with main after PR #1718 (npm publishing setup) landed.

Merge conflict resolution

  • package.json: Kept @eslint/js: ^10.0.0 from ESLint 10 branch, merged in @react-three/{drei,fiber,postprocessing} devDependencies from main
  • package-lock.json: Regenerated from main's lockfile base + npm install

Missing peer dependency fix

  • Added @testing-library/dom explicitly to devDependencies — it's a peer dep of @testing-library/react that doesn't auto-install under --legacy-peer-deps (required for eslint-plugin-react-hooks ESLint 10 compat). Without it, 210 test files fail with Cannot find module '@testing-library/dom'.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 16 commits March 24, 2026 11:20
- Update package.json: rename to blacktrigram, add npm metadata, exports, peerDependencies, publishConfig
- Add tsconfig.lib.json for TypeScript declaration generation
- Add vite.lib.config.ts for Vite library mode bundling
- Add .npmignore to control npm package contents
- Add build:lib script for library build
- Add publish job to release.yml workflow (following EP MCP Server pattern)
- Update .gitignore to exclude lib/ build output
- Update eslint.config.js to ignore lib/ directory
- Update tsconfig.node.json to include vite.lib.config.ts

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/d41b4334-7914-41a8-85e3-7cabc868f149
…d fix npm pack verification

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/d41b4334-7914-41a8-85e3-7cabc868f149
…hing

- Update typedoc.json sidebarLinks to match riksdagsmonitor pattern with all
  architecture docs (Architecture, Security Architecture, Threat Model, Data
  Model, Flowchart, State Diagram, Mindmap, SWOT, Future Architecture, Future
  Security) and ISMS references (Secure Dev Policy, Open Source Policy)
- Update typedoc.json navigationLinks with npm Package and ISMS links
- Update release-drafter.yml with npm package section, provenance verification,
  architecture documentation links, correct API docs URL (blacktrigram.com/api/),
  and additional resources section

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/91ac18bc-ace4-465e-84b2-b7f3c5bd47ef
- Remove rm -rf lib/assets from build:lib to preserve CSS/assets for consumers
- Move React/Three.js/R3F/Drei from dependencies to devDependencies (keep as peerDependencies for library consumers)
- Fix peerDependencies.three from ^0.170.0 to ^0.183.0 to match actual version
- Remove non-existent CHANGELOG.md from files array

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/e51be5d8-c054-4b7e-94fb-63212a02eae3
…fix publish ref, clean npmignore

- Add @react-three/postprocessing and postprocessing to peerDependencies (and peerDependenciesMeta as optional)
- Fix publish job checkout ref to use release tag instead of 'main' for deterministic npm publishes
- Remove non-existent CHANGELOG.md from .npmignore allowlist
- Verified README.md, LICENSE, SECURITY.md are tracked in git and not in .gitignore

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/db64837b-0e92-4ef2-9a83-dd935b1f1950
… three/* externals, ignore-scripts publish

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/c76756d9-5a5f-4fb1-96fb-e97463bfd9af
…jectable asset base path

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/6c449b1b-7c23-4d3b-bbbb-744832c7eb3e
…add missing-slash test

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/1ac44a25-578b-473e-bb56-9be7afc3df34
…hing

feat: add npm package publishing support with typedoc and release-drafter improvements
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

Dependency Review

The following issues were found:

  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.
  • ⚠️ 13 packages with OpenSSF Scorecard issues.

View full job summary

# Conflicts:
#	package-lock.json
#	package.json
@github-actions github-actions bot added dependencies Dependency updates infrastructure CI/CD and build infrastructure config Configuration changes testing Testing improvements test-coverage-impact Impacts test coverage labels Mar 24, 2026
Copilot AI changed the title [WIP] Chore: Bump eslint from 9.39.2 to 10.1.0 fix: resolve merge conflicts with main, add missing @testing-library/dom Mar 24, 2026
Copilot AI requested a review from pethers March 24, 2026 15:16
@pethers pethers marked this pull request as ready for review March 24, 2026 15:22
@pethers pethers merged commit a3df7c0 into dependabot/npm_and_yarn/eslint-10.1.0 Mar 24, 2026
4 of 5 checks passed
@pethers pethers deleted the copilot/sub-pr-1708 branch March 27, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Configuration changes dependencies Dependency updates infrastructure CI/CD and build infrastructure test-coverage-impact Impacts test coverage testing Testing improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants