Skip to content

fix: sync package-lock.json after ESLint 10 merge#1722

Merged
pethers merged 2 commits intodependabot/npm_and_yarn/eslint-10.1.0from
copilot/sub-pr-1708-again
Mar 24, 2026
Merged

fix: sync package-lock.json after ESLint 10 merge#1722
pethers merged 2 commits intodependabot/npm_and_yarn/eslint-10.1.0from
copilot/sub-pr-1708-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

npm ci in CI fails with "package.json and package-lock.json are out of sync" β€” transitive deps (mocha and its dependency tree) were lost during the ESLint 10 merge conflict resolution.

  • Regenerated package-lock.json without --legacy-peer-deps so peer deps like mocha (required by cypress-junit-reporter) are properly resolved
  • Moved @testing-library/dom from dependencies to devDependencies β€” project convention is "dependencies": {} with runtime deps as peerDependencies only

⌨️ Start Copilot coding agent tasks without leaving your editor β€” available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

Dependency Review

The following issues were found:

  • βœ… 0 vulnerable package(s)
  • βœ… 0 package(s) with incompatible licenses
  • βœ… 0 package(s) with invalid SPDX license definitions
  • βœ… 0 package(s) with unknown licenses.
  • ⚠️ 4 packages with OpenSSF Scorecard issues.

View full job summary

@github-actions github-actions bot added dependencies Dependency updates infrastructure CI/CD and build infrastructure labels Mar 24, 2026
Copilot AI changed the title [WIP] Bump eslint from 9.39.2 to 10.1.0 fix: sync package-lock.json after ESLint 10 merge Mar 24, 2026
Copilot AI requested a review from pethers March 24, 2026 15:43
@github-actions
Copy link
Copy Markdown
Contributor

πŸ“Έ Automated UI Screenshots

πŸ“‹ Screenshots Captured (8)

# Screenshot
1 01-splash-screen.png - 01 splash screen.png
2 02-intro-screen-menu.png - 02 intro screen menu.png
3 03-intro-screen-archetype-selector.png - 03 intro screen archetype selector.png
4 04-controls-screen.png - 04 controls screen.png
5 05-philosophy-screen.png - 05 philosophy screen.png
6 06-training-screen.png - 06 training screen.png
7 07-combat-screen-practice.png - 07 combat screen practice.png
8 08-combat-screen-versus.png - 08 combat screen versus.png

πŸ“¦ Download Screenshots

πŸ“₯ Download all screenshots from workflow artifacts

Screenshots are preserved as workflow artifacts for 30 days.


πŸ€– Generated by Playwright automation

@pethers pethers marked this pull request as ready for review March 24, 2026 15:53
@pethers pethers merged commit 2442f80 into dependabot/npm_and_yarn/eslint-10.1.0 Mar 24, 2026
6 checks passed
@pethers pethers deleted the copilot/sub-pr-1708-again branch March 24, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency updates infrastructure CI/CD and build infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants