Skip to content

chore(deps): bump eslint from 9.39.2 to 10.1.0#1719

Merged
pethers merged 2 commits intodependabot/npm_and_yarn/eslint-10.1.0from
copilot/sub-pr-1708
Mar 24, 2026
Merged

chore(deps): bump eslint from 9.39.2 to 10.1.0#1719
pethers merged 2 commits intodependabot/npm_and_yarn/eslint-10.1.0from
copilot/sub-pr-1708

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

ESLint 10 upgrade was blocked by peer dependency conflicts from plugins that don't yet declare eslint@^10 support.

Removed incompatible/unused plugins

  • eslint-plugin-import β€” peer dep caps at ^9, not referenced in flat config
  • eslint-plugin-react β€” peer dep caps at ^9.7, not referenced in flat config
  • @typescript-eslint/eslint-plugin, @typescript-eslint/parser β€” redundant, already transitive deps of typescript-eslint
  • .eslintrc.cjs β€” legacy config unused since flat config adoption

Updated dependencies

  • @eslint/js ^9.39.2 β†’ ^10.0.0
  • Added npm overrides for eslint-plugin-react-hooks (stable 7.0.1 doesn't declare ^10 peer support yet)

Fixed no-useless-assignment errors

ESLint 10's recommended config enables no-useless-assignment, which flagged 4 variables initialized with values immediately overwritten by exhaustive branches:

// Before: initial value always overwritten
let variantIndex = 0;
switch (archetype) { /* every case + default assigns variantIndex */ }

// After: type-only declaration
let variantIndex: number;
switch (archetype) { /* every case + default assigns variantIndex */ }

Files fixed: VariantSelector.ts, useSkeletalAnimation.ts, AdaptiveDifficulty.ts, KoreanAnatomy.ts


πŸ’¬ Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

Dependency Review

βœ… No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA a286f57.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@eslint/js 10.0.1 🟒 6.5
Details
CheckScoreReason
Maintained🟒 1030 commit(s) and 18 issue activity found in the last 90 days -- score normalized to 10
Dangerous-Workflow🟒 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Code-Review🟒 7Found 18/24 approved changesets -- score normalized to 7
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Binary-Artifacts🟒 10no binaries found in the repo
Pinned-Dependencies⚠️ 1dependency not pinned by hash detected -- score normalized to 1
License🟒 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection🟒 5branch protection is not maximal on development and all release branches
Security-Policy🟒 10security policy file detected
Fuzzing⚠️ 0project is not fuzzed
SAST🟒 10SAST tool is run on all commits

Scanned Files

  • package-lock.json
  • package.json

… errors

- Remove eslint-plugin-import (incompatible with ESLint 10, unused in flat config)
- Remove eslint-plugin-react (incompatible with ESLint 10, unused in flat config)
- Remove @typescript-eslint/eslint-plugin (transitive via typescript-eslint)
- Remove @typescript-eslint/parser (transitive via typescript-eslint)
- Update @eslint/js from ^9.39.2 to ^10.0.0
- Add npm overrides for eslint-plugin-react-hooks peer dep
- Remove legacy .eslintrc.cjs (unused with flat config)
- Fix 4 no-useless-assignment errors from new ESLint 10 rules

Co-authored-by: pethers <1726836+pethers@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Hack23/blacktrigram/sessions/dcef49f3-353c-4167-a2e8-39086e36a91f
@github-actions github-actions bot added dependencies Dependency updates infrastructure CI/CD and build infrastructure audio Audio and sound effects needs-tests Needs test coverage labels Mar 24, 2026
Copilot AI changed the title [WIP] Bump eslint from 9.39.2 to 10.1.0 chore(deps): bump eslint from 9.39.2 to 10.1.0 Mar 24, 2026
Copilot AI requested a review from pethers March 24, 2026 12:26
@github-actions
Copy link
Copy Markdown
Contributor

πŸ“Έ Automated UI Screenshots

πŸ“‹ Screenshots Captured (8)

# Screenshot
1 01-splash-screen.png - 01 splash screen.png
2 02-intro-screen-menu.png - 02 intro screen menu.png
3 03-intro-screen-archetype-selector.png - 03 intro screen archetype selector.png
4 04-controls-screen.png - 04 controls screen.png
5 05-philosophy-screen.png - 05 philosophy screen.png
6 06-training-screen.png - 06 training screen.png
7 07-combat-screen-practice.png - 07 combat screen practice.png
8 08-combat-screen-versus.png - 08 combat screen versus.png

πŸ“¦ Download Screenshots

πŸ“₯ Download all screenshots from workflow artifacts

Screenshots are preserved as workflow artifacts for 30 days.


πŸ€– Generated by Playwright automation

@pethers pethers marked this pull request as ready for review March 24, 2026 12:46
@pethers pethers merged commit 68fe3b2 into dependabot/npm_and_yarn/eslint-10.1.0 Mar 24, 2026
9 checks passed
@pethers pethers deleted the copilot/sub-pr-1708 branch March 24, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audio Audio and sound effects dependencies Dependency updates infrastructure CI/CD and build infrastructure needs-tests Needs test coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants