Skip to content

fix: address ESLint 10 migration review comments#1720

Merged
pethers merged 2 commits intodependabot/npm_and_yarn/eslint-10.1.0from
copilot/sub-pr-1708
Mar 24, 2026
Merged

fix: address ESLint 10 migration review comments#1720
pethers merged 2 commits intodependabot/npm_and_yarn/eslint-10.1.0from
copilot/sub-pr-1708

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

Fixes three issues identified in the ESLint 10 migration PR (#1708) review.

  • Revert AWS SDK downgrade: @aws-sdk/client-bedrock-runtime was inadvertently downgraded from ^3.1015.0 to ^3.1014.0 β€” reverted
  • Fix knip config: knip.json still referenced deleted .eslintrc.cjs β€” updated to eslint.config.js (flat config)
  • eslint-plugin-react-hooks peer dep: Stable v7.0.1 only declares eslint ^3-^9. The existing npm overrides section resolves this correctly for ESLint 10; no action needed until a stable release adds ^10 support

πŸ’¬ Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

Dependency Review

βœ… No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 7af31db.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@aws-sdk/client-bedrock-runtime ^3.1015.0 UnknownUnknown

Scanned Files

  • package.json

@github-actions github-actions bot added dependencies Dependency updates infrastructure CI/CD and build infrastructure labels Mar 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

πŸ“Έ Automated UI Screenshots

πŸ“‹ Screenshots Captured (8)

# Screenshot
1 01-splash-screen.png - 01 splash screen.png
2 02-intro-screen-menu.png - 02 intro screen menu.png
3 03-intro-screen-archetype-selector.png - 03 intro screen archetype selector.png
4 04-controls-screen.png - 04 controls screen.png
5 05-philosophy-screen.png - 05 philosophy screen.png
6 06-training-screen.png - 06 training screen.png
7 07-combat-screen-practice.png - 07 combat screen practice.png
8 08-combat-screen-versus.png - 08 combat screen versus.png

πŸ“¦ Download Screenshots

πŸ“₯ Download all screenshots from workflow artifacts

Screenshots are preserved as workflow artifacts for 30 days.


πŸ€– Generated by Playwright automation

Copilot AI changed the title [WIP] chore(deps): bump eslint from 9.39.2 to 10.1.0 fix: address ESLint 10 migration review comments Mar 24, 2026
Copilot AI requested a review from pethers March 24, 2026 13:44
@github-actions
Copy link
Copy Markdown
Contributor

πŸ“Έ Automated UI Screenshots

πŸ“‹ Screenshots Captured (8)

# Screenshot
1 01-splash-screen.png - 01 splash screen.png
2 02-intro-screen-menu.png - 02 intro screen menu.png
3 03-intro-screen-archetype-selector.png - 03 intro screen archetype selector.png
4 04-controls-screen.png - 04 controls screen.png
5 05-philosophy-screen.png - 05 philosophy screen.png
6 06-training-screen.png - 06 training screen.png
7 07-combat-screen-practice.png - 07 combat screen practice.png
8 08-combat-screen-versus.png - 08 combat screen versus.png

πŸ“¦ Download Screenshots

πŸ“₯ Download all screenshots from workflow artifacts

Screenshots are preserved as workflow artifacts for 30 days.


πŸ€– Generated by Playwright automation

@pethers pethers marked this pull request as ready for review March 24, 2026 13:58
@pethers pethers merged commit a71e0ac into dependabot/npm_and_yarn/eslint-10.1.0 Mar 24, 2026
5 checks passed
@pethers pethers deleted the copilot/sub-pr-1708 branch March 24, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency updates infrastructure CI/CD and build infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants