Skip to content

changes for making snmp socket non-blocking#5061

Closed
sudhanshukumar22 wants to merge 737 commits intoFRRouting:masterfrom
sudhanshukumar22:master
Closed

changes for making snmp socket non-blocking#5061
sudhanshukumar22 wants to merge 737 commits intoFRRouting:masterfrom
sudhanshukumar22:master

Conversation

@sudhanshukumar22
Copy link
Copy Markdown
Contributor

@sudhanshukumar22 sudhanshukumar22 commented Sep 26, 2019 •
edited
Loading

Problem Description/Summary :

vtysh hangs on first try to enter after a reboot with BGP dynamic peers

Expected Behavior :

VTYSH should not hang

When we debug more into bgpd docker by doing gdb on its threads, we find the below thread of bgpd, which is causing the issue.
Thread 1 (Thread 0x7f1e1ec46d40 (LWP 47)):

#0 0x00007f1e1d762593 in recvfrom () from /lib/x86_64-linux-gnu/libpthread.so.0

#1 0x00007f1e1aadd09b in netsnmp_tcpbase_recv () from /usr/lib/x86_64-linux-gnu/libnetsnmp.so.30

#2 0x00007f1e1aad9617 in netsnmp_transport_recv () from /usr/lib/x86_64-linux-gnu/libnetsnmp.so.30

#3 0x00007f1e1aab2c07 in _sess_read () from /usr/lib/x86_64-linux-gnu/libnetsnmp.so.30

#4 0x00007f1e1aab3a29 in snmp_sess_read2 () from /usr/lib/x86_64-linux-gnu/libnetsnmp.so.30

#5 0x00007f1e1aab3a7b in snmp_read2 () from /usr/lib/x86_64-linux-gnu/libnetsnmp.so.30

#6 0x00007f1e1aab3acf in snmp_read () from /usr/lib/x86_64-linux-gnu/libnetsnmp.so.30

#7 0x00007f1e1b44d7ec in agentx_read (t=0x7fffa75f0080) at lib/agentx.c:63

#8 0x00007f1e1e7d6451 in thread_call (thread=0x7fffa75f0080) at lib/thread.c:1620

#9 0x00007f1e1e770699 in frr_run (master=0x559396ea60f0) at lib/libfrr.c:1011

#10 0x0000559395b4d953 in main (argc=5, argv=0x7fffa75f02b8) at bgpd/bgp_main.c:492

(gdb) bt

#0 0x00007f830c89d210 in __read_nocancel () from /lib/x86_64-linux-gnu/libpthread.so.0

#1 0x000056450e1e8238 in vtysh_client_run (vclient=0x56450e4a8b40 <vtysh_client+24768>, line=0x56450e21add0 "enable", callback=0x0, cbarg=0x0) at vtysh/vtysh.c:216

#2 0x000056450e1e8c6b in vtysh_client_run_all (head_client=0x56450e4a8b40 <vtysh_client+24768>, line=0x56450e21add0 "enable", continue_on_err=0, callback=0x0, cbarg=0x0) at vtysh/vtysh.c:356

#3 0x000056450e1e8ddb in vtysh_client_execute (head_client=0x56450e4a8b40 <vtysh_client+24768>, line=0x56450e21add0 "enable") at vtysh/vtysh.c:393

#4 0x000056450e1e9c82 in vtysh_execute_func (line=0x56450e21add0 "enable", pager=0) at vtysh/vtysh.c:598

#5 0x000056450e1e9dee in vtysh_execute_no_pager (line=0x56450e21add0 "enable") at vtysh/vtysh.c:619

#6 0x000056450e1f7d48 in vtysh_read_file (confp=0x56451000a9d0, top_cfg=1) at vtysh/vtysh_config.c:494

#7 0x000056450e1f7ef2 in vtysh_read_config (config_default_dir=0x56450e4edc20 <frr_config> "/etc/frr/frr.conf", top_cfg=1) at vtysh/vtysh_config.c:522

#8 0x000056450e1e5de4 in vtysh_apply_top_level_config () at vtysh/vtysh_main.c:301

#9 0x000056450e1e7842 in main (argc=2, argv=0x7ffc81e6f598, env=0x7ffc81e6f5b0) at vtysh/vtysh_main.c:692

The fix has been taken from the following link.
https://sourceforge.net/p/net-snmp/patches/1348/

polychaeta
polychaeta requested changes Sep 26, 2019
View reviewed changes
Copy link
Copy Markdown

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • One of your commits has an improperly formatted commit message
  • One of your commits is missing a Signed-off-by line; we can't accept your contribution until all of your commits have one
  • One of your commits does not have a blank line between the summary and body; this will break git log --oneline

If you are a new contributor to FRR, please see our contributing guidelines.

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Sep 26, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5061 6015a0f
Date 09/26/2019
Start 02:10:16
Finish 02:31:58
Run-Time 21:42
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-09-26-02:10:16.txt
Log autoscript-2019-09-26-02:11:08.log.bz2
Memory 435 418 360

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Sep 26, 2019

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9044/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-9044/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-09-26 06:41:37,276 ERROR: ******************************************************************************
2019-09-26 06:41:37,277 ERROR: Test Target Summary                                                  Pass Fail
2019-09-26 06:41:37,277 ERROR: ******************************************************************************
2019-09-26 06:41:37,277 ERROR: FILE: scripts/check_linux_vrf.py
2019-09-26 06:41:37,277 ERROR: FILE: scripts/adjacencies.py
2019-09-26 06:41:37,277 ERROR: FILE: scripts/check_routes.py
2019-09-26 06:41:37,277 ERROR: FILE: scripts/check_linux_mpls.py
2019-09-26 06:41:37,277 ERROR: FILE: scripts/scale_up.py
2019-09-26 06:41:37,277 ERROR: FILE: scripts/scale_down.py
2019-09-26 06:41:37,277 ERROR: 136  ce1    BGP routes removed +13.89 secs                           0    1
2019-09-26 06:41:37,277 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-09-26 06:41:37,281 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_scale_down": 1 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9044/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms
  • CentOS 7 rpm pkg check
  • Ubuntu 16.04 deb pkg check
  • IPv6 protocols on Ubuntu 14.04
  • Debian 10 deb pkg check
  • Topotest tests on Ubuntu 16.04 i386
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
  • IPv4 protocols on Ubuntu 14.04
  • Topology tests on Ubuntu 16.04 amd64
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Debian 9 deb pkg check
  • Ubuntu 12.04 deb pkg check
  • Static analyzer (clang)

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9044/artifact/TOPOU1804/MemoryLeaks/

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-9044/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-09-26 06:41:37,276 ERROR: ******************************************************************************
2019-09-26 06:41:37,277 ERROR: Test Target Summary                                                  Pass Fail
2019-09-26 06:41:37,277 ERROR: ******************************************************************************
2019-09-26 06:41:37,277 ERROR: FILE: scripts/check_linux_vrf.py
2019-09-26 06:41:37,277 ERROR: FILE: scripts/adjacencies.py
2019-09-26 06:41:37,277 ERROR: FILE: scripts/check_routes.py
2019-09-26 06:41:37,277 ERROR: FILE: scripts/check_linux_mpls.py
2019-09-26 06:41:37,277 ERROR: FILE: scripts/scale_up.py
2019-09-26 06:41:37,277 ERROR: FILE: scripts/scale_down.py
2019-09-26 06:41:37,277 ERROR: 136  ce1    BGP routes removed +13.89 secs                           0    1
2019-09-26 06:41:37,277 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-09-26 06:41:37,281 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_scale_down": 1 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9044/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Report for agentx.c | 70 issues
===============================================
< WARNING: please, no spaces at the start of a line
< #58: FILE: /tmp/f1-8424/agentx.c:58:
< WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
< #58: FILE: /tmp/f1-8424/agentx.c:58:
< WARNING: please, no spaces at the start of a line
< #59: FILE: /tmp/f1-8424/agentx.c:59:
< WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
< #59: FILE: /tmp/f1-8424/agentx.c:59:
< WARNING: please, no spaces at the start of a line
< #64: FILE: /tmp/f1-8424/agentx.c:64:
< WARNING: please, no spaces at the start of a line
< #65: FILE: /tmp/f1-8424/agentx.c:65:
< ERROR: that open brace { should be on the previous line
< #65: FILE: /tmp/f1-8424/agentx.c:65:
< ERROR: space required before the open parenthesis '('
< #65: FILE: /tmp/f1-8424/agentx.c:65:
< WARNING: please, no spaces at the start of a line
< #66: FILE: /tmp/f1-8424/agentx.c:66:
< ERROR: code indent should use tabs where possible
< #67: FILE: /tmp/f1-8424/agentx.c:67:
< WARNING: please, no spaces at the start of a line
< #67: FILE: /tmp/f1-8424/agentx.c:67:
< WARNING: please, no spaces at the start of a line
< #68: FILE: /tmp/f1-8424/agentx.c:68:
< WARNING: please, no spaces at the start of a line
< #70: FILE: /tmp/f1-8424/agentx.c:70:
< ERROR: that open brace { should be on the previous line
< #70: FILE: /tmp/f1-8424/agentx.c:70:
< ERROR: space required before the open parenthesis '('
< #70: FILE: /tmp/f1-8424/agentx.c:70:
< WARNING: please, no spaces at the start of a line
< #71: FILE: /tmp/f1-8424/agentx.c:71:
< ERROR: code indent should use tabs where possible
< #72: FILE: /tmp/f1-8424/agentx.c:72:
< WARNING: please, no spaces at the start of a line
< #72: FILE: /tmp/f1-8424/agentx.c:72:
< WARNING: please, no spaces at the start of a line
< #73: FILE: /tmp/f1-8424/agentx.c:73:
< WARNING: please, no spaces at the start of a line
< #74: FILE: /tmp/f1-8424/agentx.c:74:
< ERROR: that open brace { should be on the previous line
< #74: FILE: /tmp/f1-8424/agentx.c:74:
< ERROR: else should follow close brace '}'
< #74: FILE: /tmp/f1-8424/agentx.c:74:
< WARNING: please, no spaces at the start of a line
< #75: FILE: /tmp/f1-8424/agentx.c:75:
< ERROR: code indent should use tabs where possible
< #76: FILE: /tmp/f1-8424/agentx.c:76:
< WARNING: please, no spaces at the start of a line
< #76: FILE: /tmp/f1-8424/agentx.c:76:
< WARNING: please, no spaces at the start of a line
< #77: FILE: /tmp/f1-8424/agentx.c:77:
< WARNING: please, no spaces at the start of a line
< #83: FILE: /tmp/f1-8424/agentx.c:83:
< WARNING: C99 // comments do not match recommendation
< #83: FILE: /tmp/f1-8424/agentx.c:83:
< WARNING: please, no spaces at the start of a line
< #84: FILE: /tmp/f1-8424/agentx.c:84:
< ERROR: that open brace { should be on the previous line
< #84: FILE: /tmp/f1-8424/agentx.c:84:
< ERROR: space required before the open parenthesis '('
< #84: FILE: /tmp/f1-8424/agentx.c:84:
< WARNING: please, no spaces at the start of a line
< #85: FILE: /tmp/f1-8424/agentx.c:85:
< ERROR: code indent should use tabs where possible
< #86: FILE: /tmp/f1-8424/agentx.c:86:
< WARNING: please, no spaces at the start of a line
< #86: FILE: /tmp/f1-8424/agentx.c:86:
< WARNING: please, no spaces at the start of a line
< #87: FILE: /tmp/f1-8424/agentx.c:87:

CLANG Static Analyzer Summary

  • Github Pull Request 5061, comparing to Git base SHA 7e933bc

Fixed warnings:

  • Logic error: Dereference of null pointer in nhrpd.h, function notifier_call, line 79

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 1
  • New warnings: 13

13 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9044/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Sep 26, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5061 8d28b0d
Date 09/26/2019
Start 03:00:18
Finish 03:22:00
Run-Time 21:42
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-09-26-03:00:18.txt
Log autoscript-2019-09-26-03:01:11.log.bz2
Memory 419 394 360

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Sep 26, 2019

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9046/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for agentx.c | 70 issues
===============================================
< WARNING: please, no spaces at the start of a line
< #58: FILE: /tmp/f1-23937/agentx.c:58:
< WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
< #58: FILE: /tmp/f1-23937/agentx.c:58:
< WARNING: please, no spaces at the start of a line
< #59: FILE: /tmp/f1-23937/agentx.c:59:
< WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
< #59: FILE: /tmp/f1-23937/agentx.c:59:
< WARNING: please, no spaces at the start of a line
< #64: FILE: /tmp/f1-23937/agentx.c:64:
< WARNING: please, no spaces at the start of a line
< #65: FILE: /tmp/f1-23937/agentx.c:65:
< ERROR: that open brace { should be on the previous line
< #65: FILE: /tmp/f1-23937/agentx.c:65:
< ERROR: space required before the open parenthesis '('
< #65: FILE: /tmp/f1-23937/agentx.c:65:
< WARNING: please, no spaces at the start of a line
< #66: FILE: /tmp/f1-23937/agentx.c:66:
< ERROR: code indent should use tabs where possible
< #67: FILE: /tmp/f1-23937/agentx.c:67:
< WARNING: please, no spaces at the start of a line
< #67: FILE: /tmp/f1-23937/agentx.c:67:
< WARNING: please, no spaces at the start of a line
< #68: FILE: /tmp/f1-23937/agentx.c:68:
< WARNING: please, no spaces at the start of a line
< #70: FILE: /tmp/f1-23937/agentx.c:70:
< ERROR: that open brace { should be on the previous line
< #70: FILE: /tmp/f1-23937/agentx.c:70:
< ERROR: space required before the open parenthesis '('
< #70: FILE: /tmp/f1-23937/agentx.c:70:
< WARNING: please, no spaces at the start of a line
< #71: FILE: /tmp/f1-23937/agentx.c:71:
< ERROR: code indent should use tabs where possible
< #72: FILE: /tmp/f1-23937/agentx.c:72:
< WARNING: please, no spaces at the start of a line
< #72: FILE: /tmp/f1-23937/agentx.c:72:
< WARNING: please, no spaces at the start of a line
< #73: FILE: /tmp/f1-23937/agentx.c:73:
< WARNING: please, no spaces at the start of a line
< #74: FILE: /tmp/f1-23937/agentx.c:74:
< ERROR: that open brace { should be on the previous line
< #74: FILE: /tmp/f1-23937/agentx.c:74:
< ERROR: else should follow close brace '}'
< #74: FILE: /tmp/f1-23937/agentx.c:74:
< WARNING: please, no spaces at the start of a line
< #75: FILE: /tmp/f1-23937/agentx.c:75:
< ERROR: code indent should use tabs where possible
< #76: FILE: /tmp/f1-23937/agentx.c:76:
< WARNING: please, no spaces at the start of a line
< #76: FILE: /tmp/f1-23937/agentx.c:76:
< WARNING: please, no spaces at the start of a line
< #77: FILE: /tmp/f1-23937/agentx.c:77:
< WARNING: please, no spaces at the start of a line
< #83: FILE: /tmp/f1-23937/agentx.c:83:
< WARNING: C99 // comments do not match recommendation
< #83: FILE: /tmp/f1-23937/agentx.c:83:
< WARNING: please, no spaces at the start of a line
< #84: FILE: /tmp/f1-23937/agentx.c:84:
< ERROR: that open brace { should be on the previous line
< #84: FILE: /tmp/f1-23937/agentx.c:84:
< ERROR: space required before the open parenthesis '('
< #84: FILE: /tmp/f1-23937/agentx.c:84:
< WARNING: please, no spaces at the start of a line
< #85: FILE: /tmp/f1-23937/agentx.c:85:
< ERROR: code indent should use tabs where possible
< #86: FILE: /tmp/f1-23937/agentx.c:86:
< WARNING: please, no spaces at the start of a line
< #86: FILE: /tmp/f1-23937/agentx.c:86:
< WARNING: please, no spaces at the start of a line
< #87: FILE: /tmp/f1-23937/agentx.c:87:

CLANG Static Analyzer Summary

  • Github Pull Request 5061, comparing to Git base SHA 7e933bc

Fixed warnings:

  • Logic error: Dereference of null pointer in nhrpd.h, function notifier_call, line 79

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 1
  • New warnings: 13

13 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9046/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Sep 26, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5061 6df9928
Date 09/26/2019
Start 04:55:17
Finish 05:17:04
Run-Time 21:47
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-09-26-04:55:17.txt
Log autoscript-2019-09-26-04:56:11.log.bz2
Memory 434 432 360

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Sep 26, 2019

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9048/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:15: space before tab in indent.
    	flags = fcntl(THREAD_FD(t), F_GETFL, 0);
<stdin>:16: space before tab in indent.
    	if (-1 == flags){
<stdin>:17: space before tab in indent.
        	return -1;
<stdin>:18: space before tab in indent.
    	}
<stdin>:20: space before tab in indent.
    	if (flags & O_NONBLOCK){
warning: squelched 7 whitespace errors
warning: 12 lines add whitespace errors.
Report for agentx.c | 86 issues
===============================================
< ERROR: code indent should use tabs where possible
< #64: FILE: /tmp/f1-7913/agentx.c:64:
< WARNING: please, no space before tabs
< #64: FILE: /tmp/f1-7913/agentx.c:64:
< WARNING: please, no spaces at the start of a line
< #64: FILE: /tmp/f1-7913/agentx.c:64:
< ERROR: code indent should use tabs where possible
< #65: FILE: /tmp/f1-7913/agentx.c:65:
< WARNING: please, no space before tabs
< #65: FILE: /tmp/f1-7913/agentx.c:65:
< WARNING: please, no spaces at the start of a line
< #65: FILE: /tmp/f1-7913/agentx.c:65:
< ERROR: space required before the open brace '{'
< #65: FILE: /tmp/f1-7913/agentx.c:65:
< WARNING: braces {} are not necessary for single statement blocks
< #65: FILE: /tmp/f1-7913/agentx.c:65:
< ERROR: code indent should use tabs where possible
< #66: FILE: /tmp/f1-7913/agentx.c:66:
< WARNING: please, no space before tabs
< #66: FILE: /tmp/f1-7913/agentx.c:66:
< WARNING: please, no spaces at the start of a line
< #66: FILE: /tmp/f1-7913/agentx.c:66:
< ERROR: code indent should use tabs where possible
< #67: FILE: /tmp/f1-7913/agentx.c:67:
< WARNING: please, no space before tabs
< #67: FILE: /tmp/f1-7913/agentx.c:67:
< WARNING: please, no spaces at the start of a line
< #67: FILE: /tmp/f1-7913/agentx.c:67:
< ERROR: code indent should use tabs where possible
< #69: FILE: /tmp/f1-7913/agentx.c:69:
< WARNING: please, no space before tabs
< #69: FILE: /tmp/f1-7913/agentx.c:69:
< WARNING: please, no spaces at the start of a line
< #69: FILE: /tmp/f1-7913/agentx.c:69:
< ERROR: space required before the open brace '{'
< #69: FILE: /tmp/f1-7913/agentx.c:69:
< WARNING: braces {} are not necessary for any arm of this statement
< #69: FILE: /tmp/f1-7913/agentx.c:69:
< ERROR: code indent should use tabs where possible
< #70: FILE: /tmp/f1-7913/agentx.c:70:
< WARNING: please, no space before tabs
< #70: FILE: /tmp/f1-7913/agentx.c:70:
< WARNING: please, no spaces at the start of a line
< #70: FILE: /tmp/f1-7913/agentx.c:70:
< ERROR: code indent should use tabs where possible
< #71: FILE: /tmp/f1-7913/agentx.c:71:
< WARNING: please, no space before tabs
< #71: FILE: /tmp/f1-7913/agentx.c:71:
< WARNING: please, no spaces at the start of a line
< #71: FILE: /tmp/f1-7913/agentx.c:71:
< ERROR: code indent should use tabs where possible
< #72: FILE: /tmp/f1-7913/agentx.c:72:
< WARNING: please, no space before tabs
< #72: FILE: /tmp/f1-7913/agentx.c:72:
< WARNING: please, no spaces at the start of a line
< #72: FILE: /tmp/f1-7913/agentx.c:72:
< ERROR: else should follow close brace '}'
< #72: FILE: /tmp/f1-7913/agentx.c:72:
< ERROR: code indent should use tabs where possible
< #73: FILE: /tmp/f1-7913/agentx.c:73:
< WARNING: please, no space before tabs
< #73: FILE: /tmp/f1-7913/agentx.c:73:
< WARNING: please, no spaces at the start of a line
< #73: FILE: /tmp/f1-7913/agentx.c:73:
< ERROR: code indent should use tabs where possible
< #74: FILE: /tmp/f1-7913/agentx.c:74:
< WARNING: please, no space before tabs
< #74: FILE: /tmp/f1-7913/agentx.c:74:
< WARNING: please, no spaces at the start of a line
< #74: FILE: /tmp/f1-7913/agentx.c:74:
< ERROR: code indent should use tabs where possible
< #80: FILE: /tmp/f1-7913/agentx.c:80:
< WARNING: please, no space before tabs
< #80: FILE: /tmp/f1-7913/agentx.c:80:
< WARNING: please, no spaces at the start of a line
< #80: FILE: /tmp/f1-7913/agentx.c:80:
< ERROR: code indent should use tabs where possible
< #81: FILE: /tmp/f1-7913/agentx.c:81:
< WARNING: please, no space before tabs
< #81: FILE: /tmp/f1-7913/agentx.c:81:
< WARNING: please, no spaces at the start of a line
< #81: FILE: /tmp/f1-7913/agentx.c:81:
< ERROR: space required before the open brace '{'
< #81: FILE: /tmp/f1-7913/agentx.c:81:
< WARNING: braces {} are not necessary for single statement blocks
< #81: FILE: /tmp/f1-7913/agentx.c:81:

CLANG Static Analyzer Summary

  • Github Pull Request 5061, comparing to Git base SHA 5300176

Fixed warnings:

  • Logic error: Dereference of null pointer in nhrpd.h, function notifier_call, line 79

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 1
  • New warnings: 13

13 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9048/artifact/shared/static_analysis/index.html

donaldsharp
donaldsharp requested changes Sep 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@donaldsharp donaldsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Include in the actual commit message the reasoning laid out in the PR. This is a better place to keep this data.
  2. Fix the formating to be consistent with our code base( and this includes the reverse order if statements )
  3. merge and rebase to get a later version of frr as base, the ci is showing regressions that should not happen.

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Sep 27, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5061 7348476
Date 09/27/2019
Start 06:45:17
Finish 07:06:51
Run-Time 21:34
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-09-27-06:45:17.txt
Log autoscript-2019-09-27-06:46:04.log.bz2
Memory 430 431 360

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Sep 27, 2019

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9063/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for agentx.c | 14 issues
===============================================
< ERROR: space required before the open brace '{'
< #65: FILE: /tmp/f1-9303/agentx.c:65:
< WARNING: braces {} are not necessary for single statement blocks
< #65: FILE: /tmp/f1-9303/agentx.c:65:
< ERROR: space required before the open brace '{'
< #69: FILE: /tmp/f1-9303/agentx.c:69:
< WARNING: braces {} are not necessary for any arm of this statement
< #69: FILE: /tmp/f1-9303/agentx.c:69:
< ERROR: else should follow close brace '}'
< #72: FILE: /tmp/f1-9303/agentx.c:72:
< ERROR: space required before the open brace '{'
< #81: FILE: /tmp/f1-9303/agentx.c:81:
< WARNING: braces {} are not necessary for single statement blocks
< #81: FILE: /tmp/f1-9303/agentx.c:81:

CLANG Static Analyzer Summary

  • Github Pull Request 5061, comparing to Git base SHA 5c256b5

Fixed warnings:

  • Logic error: Dereference of null pointer in nhrpd.h, function notifier_call, line 79

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 1
  • New warnings: 13

13 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9063/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Sep 27, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5061 30f5e1c
Date 09/27/2019
Start 08:20:16
Finish 08:42:00
Run-Time 21:44
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-09-27-08:20:16.txt
Log autoscript-2019-09-27-08:21:07.log.bz2
Memory 423 435 360

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Sep 27, 2019

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9064/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for agentx.c | 8 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #65: FILE: /tmp/f1-31210/agentx.c:65:
< WARNING: braces {} are not necessary for any arm of this statement
< #69: FILE: /tmp/f1-31210/agentx.c:69:
< ERROR: space required before the open brace '{'
< #80: FILE: /tmp/f1-31210/agentx.c:80:
< WARNING: braces {} are not necessary for single statement blocks
< #80: FILE: /tmp/f1-31210/agentx.c:80:

@rwestphal
Copy link
Copy Markdown
Member

rwestphal commented Oct 1, 2019

Apart from Donald's points, this patch makes sense to me. Passing a blocking TCP socket to either select(2) or poll(2) is unsafe. Unsetting O_NONBLOCK temporarily for reads should be fine (then the blocking mode is used for writes, which are more difficult to handle asynchronously).

Ideally this problem should have been fixed on net-snmp library. Since they didn't do that I think it makes sense for us to have this workaround on our side.

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Oct 1, 2019

🚧 Basic BGPD CI results: Partial FAILURE, 1 tests failed

Results table
_ _
Result SUCCESS git merge/5061 6b4f152
Date 10/01/2019
Start 01:40:15
Finish 02:02:06
Run-Time 21:51
Total 1815
Pass 1814
Fail 1
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-10-01-01:40:15.txt
Log autoscript-2019-10-01-01:41:08.log.bz2
Memory 402 411 359

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Oct 1, 2019

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9095/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for agentx.c | 8 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #65: FILE: /tmp/f1-3446/agentx.c:65:
< WARNING: braces {} are not necessary for any arm of this statement
< #69: FILE: /tmp/f1-3446/agentx.c:69:
< ERROR: space required before the open brace '{'
< #80: FILE: /tmp/f1-3446/agentx.c:80:
< WARNING: braces {} are not necessary for single statement blocks
< #80: FILE: /tmp/f1-3446/agentx.c:80:

CLANG Static Analyzer Summary

  • Github Pull Request 5061, comparing to Git base SHA 698603c

Fixed warnings:

  • Logic error: Dereference of null pointer in nhrpd.h, function notifier_call, line 79

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 1
  • New warnings: 13

13 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9095/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Oct 1, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5061 c073d43
Date 10/01/2019
Start 03:40:16
Finish 04:02:07
Run-Time 21:51
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-10-01-03:40:16.txt
Log autoscript-2019-10-01-03:41:10.log.bz2
Memory 428 433 360

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Oct 1, 2019

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9096/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
<stdin>:16: trailing whitespace.
	if (-1 == flags) 
<stdin>:19: trailing whitespace.
	if (flags & O_NONBLOCK) 
<stdin>:21: trailing whitespace.
	else 
<stdin>:23: trailing whitespace.
	
warning: 4 lines add whitespace errors.
Report for agentx.c | 8 issues
===============================================
< ERROR: trailing whitespace
< #65: FILE: /tmp/f1-30628/agentx.c:65:
< ERROR: trailing whitespace
< #68: FILE: /tmp/f1-30628/agentx.c:68:
< ERROR: trailing whitespace
< #70: FILE: /tmp/f1-30628/agentx.c:70:
< ERROR: trailing whitespace
< #72: FILE: /tmp/f1-30628/agentx.c:72:

CLANG Static Analyzer Summary

  • Github Pull Request 5061, comparing to Git base SHA 698603c

Fixed warnings:

  • Logic error: Dereference of null pointer in nhrpd.h, function notifier_call, line 79

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 1
  • New warnings: 13

13 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9096/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Oct 1, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5061 d080ed5
Date 10/01/2019
Start 06:55:15
Finish 07:16:56
Run-Time 21:41
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-10-01-06:55:15.txt
Log autoscript-2019-10-01-06:56:09.log.bz2
Memory 427 411 360

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Oct 1, 2019

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9098/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

  • Github Pull Request 5061, comparing to Git base SHA 698603c

Fixed warnings:

  • Logic error: Dereference of null pointer in nhrpd.h, function notifier_call, line 79

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 1
  • New warnings: 13

13 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9098/artifact/shared/static_analysis/index.html

@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented Oct 4, 2019

  1. Include in the actual commit message the reasoning laid out in the PR. This is a better place to keep this data.
  2. Fix the formating to be consistent with our code base( and this includes the reverse order if statements )
  3. merge and rebase to get a later version of frr as base, the ci is showing regressions that should not happen.

Hi Donald,
I have done git pull and it shows up to date. Note that my local branch is also master. (remote branch is also master).
-bash-4.1$ git status -uno
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit (use -u to show untracked files)
-bash-4.1$ git status -uno
On branch master
Your branch is up-to-date with 'origin/master'.
nothing to commit (use -u to show untracked files)
-bash-4.1$ git pull
Already up-to-date.
-bash-4.1$
Can you tell me how I can proceed furthur ?

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Oct 4, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5061 f75cb8e
Date 10/04/2019
Start 01:25:16
Finish 01:47:09
Run-Time 21:53
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-10-04-01:25:16.txt
Log autoscript-2019-10-04-01:26:12.log.bz2
Memory 419 429 359

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Oct 4, 2019

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9131/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

  • Github Pull Request 5061, comparing to Git base SHA 698603c

Fixed warnings:

  • Logic error: Dereference of null pointer in nhrpd.h, function notifier_call, line 79

New warnings:

Static Analysis warning summary compared to base:

  • Fixed warnings: 1
  • New warnings: 13

13 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9131/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Oct 4, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5061 cd98b92
Date 10/04/2019
Start 10:05:17
Finish 10:26:59
Run-Time 21:42
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-10-04-10:05:17.txt
Log autoscript-2019-10-04-10:06:07.log.bz2
Memory 421 435 360

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Oct 4, 2019

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9140/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

  • Github Pull Request 5061, comparing to Git base SHA 1f6a6e0

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9140/artifact/shared/static_analysis/index.html

@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented Oct 5, 2019

Hi donald,
Please merge the changes. I have taken care of all review comments.

Thanks,
Sudhanshu

  1. Include in the actual commit message the reasoning laid out in the PR. This is a better place to keep this data.
  2. Fix the formating to be consistent with our code base( and this includes the reverse order if statements )
  3. merge and rebase to get a later version of frr as base, the ci is showing regressions that should not happen.

@rwestphal
Copy link
Copy Markdown
Member

rwestphal commented Oct 9, 2019

@sudhanshukumar22 Thanks for the updates. Your patch looks good to me, but there are still a few problems with this PR:

  • There are two merge commits that are unnecessary;
  • The commit with your code is duplicated somehow;
  • In your commit message, you need to add a space after lib:. Also, please update the commit message to include the full backtrace you provided in the PR text.

To fix these problems, I'd suggest you to do the following:

$ git reset --hard HEAD~4
$ git cherry-pick da87b6f0dc373795bfae595980ad3d0528beb342
$ git commit --amend # and edit the commit message accordingly

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Oct 10, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5061 eed1105
Date 10/10/2019
Start 00:45:16
Finish 01:07:00
Run-Time 21:44
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-10-10-00:45:16.txt
Log autoscript-2019-10-10-00:46:09.log.bz2
Memory 411 435 360

For details, please contact louberger

@eqvinox @sudhanshukumar22
bgpd/bmp: BMP implementation
d26c44c 
This implements BMP.  There's no fine-grained history here, the non-BMP
preparations are already split out from here so all that remains is BMP
proper.

Signed-off-by: David Lamparter <equinox@diac24.net>
sworleys and others added 23 commits October 9, 2019 22:17
@sworleys @sudhanshukumar22
lib: Decode vrf_id update appropriately from zapi
da2a203 
The vrf_id in `zsend_interface_vrf_update()` is encoded as
a long via `stream_putl()`, we should decode it as such
as well.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
@donaldsharp @sudhanshukumar22
sharpd: Start infrastructure to allow for redistribution testing
a3058fe 
Start the work in sharpd to allow the testing of redistribution
of routes.  Namely telling zebra to tell us about redistribution events
via the callback.

Future work here will allow sharpd to specify the redistribution
events it wants and to allow us to track that via counters.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp @sudhanshukumar22
zebra: Fix redistribution deletion for ZEBRA_ROUTE_ALL
dc6c0f9 
commit ee8a72f

broke the usage of ZEBRA_ROUTE_ALL as a valid redistribution
command.  This commit puts it back in.  LDP uses ZEBRA_ROUTE_ALL
as an option to say it is interested in all REDISTRIBUTION events.

Fixes: #5072
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@ashish12pant @sudhanshukumar22
tests: Fix topojson link local ipv6 address
525e720 
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Removed code that disabled link local ipv6 address on the interface
@ashish12pant @sudhanshukumar22
tests: Add topojson route-map for nexthop
4744ce5 
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Add route-map option for ipv6 nexthop

Fix typo in bgp configuration
@ashish12pant @sudhanshukumar22
tests: Modify json for bgp-ecmp-topo2
e265f66 
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>

Modified json files to configure route-map which prefer global
address
@ashish12pant @sudhanshukumar22
tests: Enabling bgp-ecmp-topo2 test cases
022f2b8 
Signed-off-by: Ashish Pant <ashish12pant@gmail.com>
@sudhanshukumar22
zebra: during shutdown processing, drop dplane results
a7c3ecc 
Don't process dataplane results in zebra during shutdown (after
sigint has been seen). The dplane continues to run in order to
clean up, but zebra main just drops results.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
@donaldsharp @sudhanshukumar22
doc: Add some additional warnings around Turning off bgp capabilities
9286e19 
FRR supports the ability to turn off the negotation of bgp capabilities.
Provide a few bread crumbs to the operator that it might not be as
useful as they would hope.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp @sudhanshukumar22
bgpd: Show to compiler that uint64_t -> uint32_t is ok here
08b4496 
We only have a uint32_t value here but clippy is wise and
gives us more data than we need. Tell the compiler we can
throw some stuff away.

This was found by inspecting CI results.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp @sudhanshukumar22
bgpd: bgp pointer may be null
80d946c 
The bgp pointer may not be actually found.  The debug
message that was using it could get the same value
another way.  Convert over

Fixes Coverity Scan Issue:

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@Frankkkkk @sudhanshukumar22
docker/debian: Make docker images lighter and with less layers
954896b 
Signed-off-by: Frank Villaro-Dixon <frank.villaro@infomaniak.com>
@ton31337 @sudhanshukumar22
bgpd: Use uint32_t for maximum-prefix
e405d37 
Currently we have unsigned long which is not what we defined
in CLI (1-4294967295).

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
@donaldsharp @sudhanshukumar22
lib, watchfrr: Add some additional status messages to systemd
1a3e2c1 
Allow systemd to be informed about operational state so operators can
infer a bit about what is going on with FRR from the systemd status
cli.

sharpd@robot ~/frr4> systemctl status frr
● frr.service - FRRouting
   Loaded: loaded (/usr/lib/systemd/system/frr.service; enabled; vendor preset: disabled)
   Active: active (running) since Thu 2019-10-03 21:09:04 EDT; 7s ago
     Docs: https://frrouting.readthedocs.io/en/latest/setup.html
  Process: 32455 ExecStart=/usr/lib/frr/frrinit.sh start (code=exited, status=0/SUCCESS)
   Status: "FRR Operational"
    Tasks: 12 (limit: 4915)
   Memory: 76.5M
   CGroup: /system.slice/frr.service
           ├─32468 /usr/lib/frr/watchfrr -d zebra bgpd staticd
           ├─32487 /usr/lib/frr/zebra -d -A 127.0.0.1 -s 90000000
           ├─32492 /usr/lib/frr/bgpd -d -A 127.0.0.1
           └─32500 /usr/lib/frr/staticd -d -A 127.0.0.1

Please note the `Status: ...` line above.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@qlyoung @sudhanshukumar22
lib: reject leading 0 in ipv4 decimal quad
a903cda 
inet_pton() is used to parse ipv4 addresses internally, therefore FRR
does not support octal notation for quads. The ipv4 cli token validator
should make sure that str2prefix() can parse tokens it allows, and
str2prefix uses inet_pton, so we have to disallow leading zeros in ipv4
quads.

In short, 1.1.1.01 is no longer valid and must be expressed as 1.1.1.1.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
@idryzhov @sudhanshukumar22
lib: fix typo
30a8d69 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
@idryzhov @sudhanshukumar22
*: remove redundant brackets in commands
ee2a434 
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
@sworleys @sudhanshukumar22
pbrd: Don't track ipv6 link locals
73b22e6 
Don't bother tracking ipv6 link locals to determine if a map
should be installed. Every interface has a route of `fe80::/64`
so its just going to return the arbitrarily first one it finds
when it resolves it and hands it back to us.

Instead, just track the interface we specify along with it.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
@donaldsharp @sudhanshukumar22
pimd: Fix zlog_warn when we mean debug and vice versa
46dead1 
There are several places in the pim where we are mixing up
zlog_warn w/ zlog_debug and vice versa.  If we are protecting
a zlog_warn w/ a debug is it really a warn?  If we have an actual
error situation we should also warn about it.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@rzalamena @sudhanshukumar22
configure.ac: fix memory sanitizer test
1b3358f 
We should test for `-fsanitize=memory` instead of `-fsanitize=thread`
when enabling memory sanitizer. While here, fix the error message.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
@rzalamena @sudhanshukumar22
doc: update topotests doc for address sanitizer
8e2038c 
Use the `--enable-address-sanitizer` option instead of the manual
version using environment flags.

This also avoids the problem of having to remember to skip clippy with
the custom flags:

```
make -C lib CFLAGS="-g -O2" LDFLAGS="-g" clippy
```

The snippet above is not needed with `--enable-address-sanitizer`!

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
@qlyoung @sudhanshukumar22
lib: fix gRPC northbound plugin build
faf5b78 
Some issues with our internal vector type being typedef'd as `vector`,
which conflicts with the C++ standard vector class...

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
@sudhanshukumar22
pull from master to my branch, this change is not to be taken
e5b390d
@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented Oct 10, 2019

Let me create a new pull request with the changes.

@LabN-CI
Copy link
Copy Markdown
Collaborator

LabN-CI commented Oct 10, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5061 e5b390d
Date 10/10/2019
Start 01:45:15
Finish 02:06:57
Run-Time 21:42
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-10-10-01:45:15.txt
Log autoscript-2019-10-10-01:46:06.log.bz2
Memory 429 434 360

For details, please contact louberger

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Oct 10, 2019

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9188/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

  • Github Pull Request 5061, comparing to Git base SHA d00d0f9

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9188/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Copy Markdown
Collaborator

NetDEF-CI commented Oct 10, 2019

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9189/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

  • Github Pull Request 5061, comparing to Git base SHA d00d0f9

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9189/artifact/shared/static_analysis/index.html

@sudhanshukumar22
Copy link
Copy Markdown
Contributor Author

sudhanshukumar22 commented Oct 10, 2019

Hi,
I have closed this pull request and created a new pull request
#5134

@sudhanshukumar22 sudhanshukumar22 mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polychaeta polychaeta Awaiting requested review from polychaeta

@donaldsharp donaldsharp Awaiting requested review from donaldsharp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.