[7.2] LDP label withdraw errors #5072
Description
Multiple LDP compliance tests fail at the stage of withdrawing the labels.
Not sure what exactly is going on, but in the bad case, looking at the ldpd.log, the messages for the LDP: zebra[in]: route delete 172.16.12.0/24 nexthop 192.168.2.1 ifindex 0 (static) are missing.
Bisect identified the following as the bad commit:
commit ee8a72f315013aecd45bc9c3aaf7ea81b2ca747a
Author: Mark Stapp <mjs@voltanet.io>
Date: Thu Sep 12 11:30:42 2019 -0400
zebra: revise redistribution delete to improve update case
When selecting a new best route, zebra sends a redist update
when the route is installed. There are cases where redist
clients may not see that redist add - clients who are not
subscribed to the new route type, e.g. In that case, attempt
to send a redist delete for the old/previous route type.
Revised the redist delete api to accomodate both cases;
also tightened up the const-ness of a few internal redist apis.
[7.2 version]
Signed-off-by: Mark Stapp <mjs@voltanet.io>