parser: accept non-words as first tokens & numbers as word tokens#6
Merged
donaldsharp merged 2 commits intoFRRouting:masterfrom Dec 16, 2016
Merged
Conversation
There seems to be no reason why numbers don't work as plain word tokens; this is useful to have "number choices" or constants, e.g. <128|192|256> for bit encryption lengths. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This removes an artificial restriction for the first token in a command's graph to be a WORD_TKN. The intention seems to be to prohibit empty paths through a command, and to restrict "explosion" of choices in the root node. The better approach to the former is to check for an empty path after the definition is parsed. The latter will happen anyway, by duplication of the command, which just makes it worse... Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Member
|
Thanks all! |
eqvinox
referenced
this pull request
in opensourcerouting/frr
Mar 25, 2017
Build Quagga without SSH support of RTRlib
This was referenced Sep 5, 2017
Merged
This was referenced May 14, 2018
Merged
cfra
referenced
this pull request
in opensourcerouting/frr
Nov 29, 2018
This was referenced Jun 16, 2025
This was referenced Oct 7, 2025
2 tasks
This was referenced Jan 13, 2026
This was referenced Feb 4, 2026
Merged
Merged
Merged
Merged
Merged
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.