Merge branch 'dev/osr/fixes_plus_vty_keywords'#5
Merged
donaldsharp merged 13 commits intomasterfrom Dec 16, 2016
Merged
Conversation
This makes grammar_sandbox a workable tool again, updating it for the recent changes. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This re-adds "{foo WORD|bar WORD}" keyword-argument support to the CLI
parser. Note that token graphs may now contain loops for this purpose;
therefore the matching functions retain a history of already-matched
tokens. Each token can thus only be consumed once.
And then LINE... gets its special treatment with allowrepeat.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
If <Tab> processing finds that there is only 1 candidate, but that candidate is not a WORD_TKN that we can tab-complete on, the status would remain at CMD_COMPLETE_FULL_MATCH, but the resulting list of possible completions is empty. This then SEGVs in lib/vty.c where it tries to access the first element of the list, assuming FULL_MATCH always has 1 element there... Signed-off-by: David Lamparter <equinox@opensourcerouting.org> Cc: Quentin Young <qlyoung@cumulusnetworks.com>
Now that we have keyword argument support in the matcher again, this needs to be updated because argv[] will be 1:1 user input without mangling or reordering. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This was SEGV'ing the test in bgp_master_init() since QOBJ_REG was used without qobj_init() being called first. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
exit 0 exits the entire testrunner... Oops. Also, "unresolved" breaks too many things, so make this a pass. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
PRIu64 is "u", we need "x", so PRIx64... Signed-off-by: David Lamparter <equinox@opensourcerouting.org> Cc: Donald Sharp <sharpd@cumulusnetworks.com>
bison-2.7.x really wants "foo" for api.prefix while bison-3.0.x really
wants {foo} ... great.
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This shuffles the code blocks in command_parser.y to match file output order, then adjusts things to make the include handling less messy. (also dropped unused DECIMAL_STRLEN_MAX define.) This should hopefully fix the build on NetBSD 6. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
bgp_master_init is called first thing in main(), so we need to wedge a qobj_init() call in there... this needs some improvement... Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
struct graph_node isn't quite the right place to control matcher behaviour. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
bison conditionally writes its output to different files based on the filenames specified in the source code. This could be disabled, however... flex changes its output filenames when "prefix" is specified. And ylwrap from <1.11 doesn't understand how to handle the header file... ...so this requires automake 1.12 which can deal with this properly. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
564d443 to
a6cf5da
Compare
Member
|
Thanks! |
This was referenced Sep 5, 2017
Merged
Merged
This was referenced May 14, 2018
This was referenced Jun 16, 2025
This was referenced Oct 7, 2025
2 tasks
This was referenced Jan 13, 2026
This was referenced Feb 4, 2026
Merged
Merged
Merged
Merged
Merged
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is finally green on this (except clang static-analysis box which has no flex&bison installed).