Skip to content

Conversation

@saintentropy
Copy link
Contributor

Purpose

The purpose of this PR is to cherry pick the changes that are required for Refinery support in the 2.0.2 Dynamo branch. The following PR's from master are included in this PR.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@mjkkirschner

FYIs

@sm6srw @QilongTang @alfarok

saintentropy and others added 30 commits February 24, 2018 23:15
* Bump Up Patch Version

* Add version

* Update comments and version baseline

* Address Comments
CubicMillimeter To CubicMeter conversion
Revert "CubicMillimeter To CubicMeter conversion"
* fix crash, compilation of static property

* code cleanup

* add test

* add test graph
…ent (DynamoDS#8648)

* fix for additional input port

* fixes for output ports

* update tests

* added test, code cleanup

* address review comments
…lass name (DynamoDS#8661)


* fix for compiling property method as function pointer

* code cleanup

* add tests
* Update failing tests (DynamoDS#8663)

* update tests
* merge LibG binaries with Geometry.Approximate()
[PTAL] Update Dynamo samples from xml to json
set unsaved changes false when initializing json custom node
After investigating the errors in the EngOps check it was thought that these changes could not have caused the current failures. Other PRs have also shown the same issues. Given all of that, this PR is being merged.
* update LibG binaries for ASM224 branch
set unsavedChanges to false for json customNodes
Add RegisterForTrace attribute as alternate trigger in Json serialization
saintentropy and others added 15 commits October 16, 2018 13:59
* POC

* Cleanup code.

* Add command line option -g for generating geometry json file.

* Remove filtering

* Fix node state flags at load time.

* Use UpdateValue for setting isVisible on node model. Revert set to private.

* Remove filtering.

* Clean up holder code.

* Cleanup converter code. Use node model defaults as starting point.

* Preload the same libraries for CLI as for Sandbox.

* Add color support

* Simplify json

* Update file format.

* Remove property expressions.

* Restore comment.

* Restore Cef Settings

* Add unit test for CLI geometry option.

* Remove comment.

* Don't extend CommandLineRunner.

* Use var when possible.

* Remove commented out code.

* Use DynamoViewModel in CLI.

* Use DefaultWatch3DViewModel for CLI.

* Add new project DynamoWPFCLI.

* Let CommandLineRunnerWPF inherit from CommandLineRunner.

* Fix review comments.

* Fix unstable unit tests.

* Remove Dispose method.

* Add comments
* POC

* Cleanup code.

* Add command line option -g for generating geometry json file.

* Remove filtering

* Fix node state flags at load time.

* Use UpdateValue for setting isVisible on node model. Revert set to private.

* Remove filtering.

* Clean up holder code.

* Cleanup converter code. Use node model defaults as starting point.

* Preload the same libraries for CLI as for Sandbox.

* Add color support

* Simplify json

* Update file format.

* Remove property expressions.

* Restore comment.

* Restore Cef Settings

* Add unit test for CLI geometry option.

* Remove comment.

* Don't extend CommandLineRunner.

* Use var when possible.

* Remove commented out code.

* Use DynamoViewModel in CLI.

* Use DefaultWatch3DViewModel for CLI.

* Add new project DynamoWPFCLI.

* Let CommandLineRunnerWPF inherit from CommandLineRunner.

* Fix review comments.

* Fix unstable unit tests.

* Remove Dispose method.

* Add comments

* First pass

* Formatting fixes.

* Remove XML stuff.

* Some final adjustments.

* Add more comments.

* Move comment.

* Only store the geometry array.

* Refactor.

* Add interface

* Make interface internal

* Rename implmentation.

* Allow internal access for CLI

* Move default implementation to core.

* Make setters private

* Address review comments.
…GS API (DynamoDS#9170)

* Fix typo

* Obsolete the existing property

* Update test

* remove expression body syntax

* Add serialization test with typo
…, part Deux (DynamoDS#9178)

* Don't culture format value strings.

* Assume value strings are formated with `InvariantCulture`

* Add tests

* More work on tests

* Clarify switching of cultures
@mjkkirschner
Copy link
Member

This seems fine to me - lets figure out why the build is failing and make sure the tests pass - I still have not added the missing test dlls to the self serve.

@mjkkirschner
Copy link
Member

@saintentropy I've kicked this off with the right branch.

@saintentropy saintentropy merged commit 4ecc983 into DynamoDS:RC2.0.2_master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants