-
Notifications
You must be signed in to change notification settings - Fork 668
Cherry Picks for Refinery support in Dynamo 2.0.2 #9198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
saintentropy
merged 45 commits into
DynamoDS:RC2.0.2_master
from
saintentropy:RefineryCherryPicks
Oct 24, 2018
Merged
Cherry Picks for Refinery support in Dynamo 2.0.2 #9198
saintentropy
merged 45 commits into
DynamoDS:RC2.0.2_master
from
saintentropy:RefineryCherryPicks
Oct 24, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump Up Patch Version * Add version * Update comments and version baseline * Address Comments
CubicMillimeter To CubicMeter conversion
Revert "CubicMillimeter To CubicMeter conversion"
Fix the units bug
Fix the test from PR : DynamoDS#8655
* fix crash, compilation of static property * code cleanup * add test * add test graph
…ent (DynamoDS#8648) * fix for additional input port * fixes for output ports * update tests * added test, code cleanup * address review comments
…lass name (DynamoDS#8661) * fix for compiling property method as function pointer * code cleanup * add tests
* Update failing tests (DynamoDS#8663) * update tests
* merge LibG binaries with Geometry.Approximate()
[PTAL] Update Dynamo samples from xml to json
Update license
…syntax (DynamoDS#8670) (DynamoDS#8674) * fix crash with ColorRange1D node * add test
…-fix scroll bar fix in incanvas search
After investigating the errors in the EngOps check it was thought that these changes could not have caused the current failures. Other PRs have also shown the same issues. Given all of that, this PR is being merged.
* update LibG binaries for ASM224 branch
set unsavedChanges to false for json customNodes
Add RegisterForTrace attribute as alternate trigger in Json serialization
* POC * Cleanup code. * Add command line option -g for generating geometry json file. * Remove filtering * Fix node state flags at load time. * Use UpdateValue for setting isVisible on node model. Revert set to private. * Remove filtering. * Clean up holder code. * Cleanup converter code. Use node model defaults as starting point. * Preload the same libraries for CLI as for Sandbox. * Add color support * Simplify json * Update file format. * Remove property expressions. * Restore comment. * Restore Cef Settings * Add unit test for CLI geometry option. * Remove comment. * Don't extend CommandLineRunner. * Use var when possible. * Remove commented out code. * Use DynamoViewModel in CLI. * Use DefaultWatch3DViewModel for CLI. * Add new project DynamoWPFCLI. * Let CommandLineRunnerWPF inherit from CommandLineRunner. * Fix review comments. * Fix unstable unit tests. * Remove Dispose method. * Add comments
* POC * Cleanup code. * Add command line option -g for generating geometry json file. * Remove filtering * Fix node state flags at load time. * Use UpdateValue for setting isVisible on node model. Revert set to private. * Remove filtering. * Clean up holder code. * Cleanup converter code. Use node model defaults as starting point. * Preload the same libraries for CLI as for Sandbox. * Add color support * Simplify json * Update file format. * Remove property expressions. * Restore comment. * Restore Cef Settings * Add unit test for CLI geometry option. * Remove comment. * Don't extend CommandLineRunner. * Use var when possible. * Remove commented out code. * Use DynamoViewModel in CLI. * Use DefaultWatch3DViewModel for CLI. * Add new project DynamoWPFCLI. * Let CommandLineRunnerWPF inherit from CommandLineRunner. * Fix review comments. * Fix unstable unit tests. * Remove Dispose method. * Add comments * First pass * Formatting fixes. * Remove XML stuff. * Some final adjustments. * Add more comments. * Move comment. * Only store the geometry array. * Refactor. * Add interface * Make interface internal * Rename implmentation. * Allow internal access for CLI * Move default implementation to core. * Make setters private * Address review comments.
…GS API (DynamoDS#9170) * Fix typo * Obsolete the existing property * Update test * remove expression body syntax * Add serialization test with typo
…, part Deux (DynamoDS#9178) * Don't culture format value strings. * Assume value strings are formated with `InvariantCulture` * Add tests * More work on tests * Clarify switching of cultures
Member
|
This seems fine to me - lets figure out why the build is failing and make sure the tests pass - I still have not added the missing test dlls to the self serve. |
Member
|
@saintentropy I've kicked this off with the right branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to cherry pick the changes that are required for Refinery support in the 2.0.2 Dynamo branch. The following PR's from master are included in this PR.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs
@sm6srw @QilongTang @alfarok