set unsavedChanges to false for json customNodes #8679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/QNTM-3715
unable to publish a json customnode - it actually appears this does not effect xml dyfs - so the dyf file included with the task is not useful for testing - just FYI.
when we initialize a customNode without opening it we need to set
unsavedChangesto false, since we directly set the category, and setting the category marks the workspace as modified. This does not happen for XML based workspaces as this is all done inside the workspace and workspaceInfo constructors - for JSONcustomNodeWorkspaceswe set the category in thecustomNode manager.I have added a test.
I still need to run the self serve CI.
When this is good we should cherry pick it.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang (if you have time)
FYIs
@smangarole @Racel