Skip to content

Conversation

@mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Mar 22, 2018

Purpose

https://jira.autodesk.com/browse/QNTM-3715

unable to publish a json customnode - it actually appears this does not effect xml dyfs - so the dyf file included with the task is not useful for testing - just FYI.

when we initialize a customNode without opening it we need to set unsavedChanges to false, since we directly set the category, and setting the category marks the workspace as modified. This does not happen for XML based workspaces as this is all done inside the workspace and workspaceInfo constructors - for JSON customNodeWorkspaces we set the category in the customNode manager.

I have added a test.

I still need to run the self serve CI.

When this is good we should cherry pick it.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@QilongTang (if you have time)

FYIs

@smangarole @Racel

set unsaved changes false when initializing json custom node
@ColinDayOrg
Copy link
Contributor

Seems fine to me.

@QilongTang
Copy link
Contributor

Code LGTM But I have a side note: can you change the version of dyf to be 2.0.0.xxxx to avoid trouble when cherry picking in to RC branch? RC branch should not contain files from future version of Dynamo.

@mjkkirschner mjkkirschner mentioned this pull request Mar 23, 2018
@mjkkirschner mjkkirschner merged commit c03f698 into DynamoDS:master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants