[ 2.0 Release Cut ] Bump Up Master Patch Version #8647

QilongTang · 2018-03-12T20:03:50Z

Please Note:

Before submitting the PR, please review How to Contribute to Dynamo
Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
PRs will be reviewed from oldest to newest
If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

QNTM-3571
Cut the Release branch

According to semantic versioning:
Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backwards compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated.

This PR only increment patch version of Dynamo master branch, because above requirements are not true yet to Dynamo master branch. Also doing this since we do not have Json migration working yet to avoid intermediate json.

After this change,
Daily builds will be DynamoRevit2.0.1.xxxx.exe
RC builds will be DynamoRevit2.0.0.xxxx.exe
Graphs saved will have block with a slightly higher version

  "View": {
    "Dynamo": {
      "ScaleFactor": 1.0,
      "HasRunWithoutCrash": true,
      "IsVisibleInDynamoLibrary": true,
      "Version": "2.0.1.2821",
      "RunType": "Automatic",
      "RunPeriod": "1000"
    }

Declarations

Check these if you believe they are true

The code base is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@ramramps @mjkkirschner

FYIs

@smangarole @kronz @jnealb

ramramps · 2018-03-12T20:06:48Z

src/AssemblySharedInfoGenerator/AssemblySharedInfo.tt

 int MinorVersion = 0;
-int BuildNumber = 0;
+int BuildNumber = 1;
 int RevisionNumber = ((int)(DateTime.UtcNow - new DateTime(2017,1,1)).TotalDays)*10+((int)DateTime.UtcNow.Hour)/3;


should it say 2018?

@ramramps Not now, it will scrw us on the number and all the existing 2.0 beta packages on nuget. Will not change this date until next major release I believe

@QilongTang can you put that information in the code as a comment or TODO.

QilongTang · 2018-03-12T22:50:55Z

Merging in as well as the Revit changes so that BRE team can start to work on installers delivery.

* Add RegisterFroTrace attribute as a trigger in Json serialization of trace * PR comment * [ 2.0 Release Cut ] Bump Up Master Patch Version (#8647) * Bump Up Patch Version * Add version * Update comments and version baseline * Address Comments * CubicMillimeterToCubicMeter conversion * Revert "CubicMillimeter To CubicMeter conversion" * Fix the units bug * Remove thread sleep * missed the test * Fix static property compilation and crash (#8649) * fix crash, compilation of static property * code cleanup * add test * add test graph * QNTM-3646: Fix creation of unwanted input port for list index-assignment (#8648) * fix for additional input port * fixes for output ports * update tests * added test, code cleanup * address review comments * QNTM-3279: Fix for crash when trying to directly call properties on class name (#8661) * fix for compiling property method as function pointer * code cleanup * add tests * Cherry-pick #8663 (#8664) * Update failing tests (#8663) * update tests * Merge LibG binaries with Geometry.Approximate API (#8666) * merge LibG binaries with Geometry.Approximate() * Update license * scroll bar fix in incanvas search * QNTM-3641: Prevent ColorRange node from crashing with old style List syntax (#8670) (#8674) * fix crash with ColorRange1D node * add test * add test set unsaved changes false when initializing json custom node * Update changes from librarie.js to fix QNTM-3710 (#8678) After investigating the errors in the EngOps check it was thought that these changes could not have caused the current failures. Other PRs have also shown the same issues. Given all of that, this PR is being merged. * address comments * Update LibG binaries for ASM224 branch (#8681) * update LibG binaries for ASM224 branch * PR comment * QNTM-3841 Add geometry creation option to Dynamo CLI (#8775) * POC * Cleanup code. * Add command line option -g for generating geometry json file. * Remove filtering * Fix node state flags at load time. * Use UpdateValue for setting isVisible on node model. Revert set to private. * Remove filtering. * Clean up holder code. * Cleanup converter code. Use node model defaults as starting point. * Preload the same libraries for CLI as for Sandbox. * Add color support * Simplify json * Update file format. * Remove property expressions. * Restore comment. * Restore Cef Settings * Add unit test for CLI geometry option. * Remove comment. * Don't extend CommandLineRunner. * Use var when possible. * Remove commented out code. * Use DynamoViewModel in CLI. * Use DefaultWatch3DViewModel for CLI. * Add new project DynamoWPFCLI. * Let CommandLineRunnerWPF inherit from CommandLineRunner. * Fix review comments. * Fix unstable unit tests. * Remove Dispose method. * Add comments * Fix type check * Apply same fix to NodeInputData * Add serialization tests * Fix typo in Extansion. * QNTM-4278 DynamoWPFCLI should use CoGs geometry format (#8887) * POC * Cleanup code. * Add command line option -g for generating geometry json file. * Remove filtering * Fix node state flags at load time. * Use UpdateValue for setting isVisible on node model. Revert set to private. * Remove filtering. * Clean up holder code. * Cleanup converter code. Use node model defaults as starting point. * Preload the same libraries for CLI as for Sandbox. * Add color support * Simplify json * Update file format. * Remove property expressions. * Restore comment. * Restore Cef Settings * Add unit test for CLI geometry option. * Remove comment. * Don't extend CommandLineRunner. * Use var when possible. * Remove commented out code. * Use DynamoViewModel in CLI. * Use DefaultWatch3DViewModel for CLI. * Add new project DynamoWPFCLI. * Let CommandLineRunnerWPF inherit from CommandLineRunner. * Fix review comments. * Fix unstable unit tests. * Remove Dispose method. * Add comments * First pass * Formatting fixes. * Remove XML stuff. * Some final adjustments. * Add more comments. * Move comment. * Only store the geometry array. * Refactor. * Add interface * Make interface internal * Rename implmentation. * Allow internal access for CLI * Move default implementation to core. * Make setters private * Address review comments. * match Revit CEF intitializtion settings * match Revit CEF intitializtion settings * match Revit CEF intitializtion settings * QNTM-5580 - Correct Typo in the Dynamo json serialization to match CoGS API (#9170) * Fix typo * Obsolete the existing property * Update test * remove expression body syntax * Add serialization test with typo * AVP NumberInputNode deserialization * add testing * QNTM-5568 Refinery needs to support culture invariance for number fmt, part Deux (#9178) * Don't culture format value strings. * Assume value strings are formated with `InvariantCulture` * Add tests * More work on tests * Clarify switching of cultures

QilongTang added 2 commits March 9, 2018 15:55

Bump Up Patch Version

875a9cb

Add version

5b66009

ramramps reviewed Mar 12, 2018

View reviewed changes

Update comments and version baseline

29a0d0f

QilongTang mentioned this pull request Mar 12, 2018

Bump Up D4R Version DynamoDS/DynamoRevit#1956

Merged

5 tasks

Address Comments

9ce4de9

QilongTang merged commit 92c5538 into master Mar 12, 2018

QilongTang deleted the BumpUpVersion branch March 12, 2018 22:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ 2.0 Release Cut ] Bump Up Master Patch Version #8647

[ 2.0 Release Cut ] Bump Up Master Patch Version #8647

Uh oh!

QilongTang commented Mar 12, 2018 •

edited

Loading

Uh oh!

ramramps Mar 12, 2018

Uh oh!

QilongTang Mar 12, 2018

Uh oh!

ramramps Mar 12, 2018

Uh oh!

mjkkirschner Mar 12, 2018

Uh oh!

QilongTang commented Mar 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[ 2.0 Release Cut ] Bump Up Master Patch Version #8647

[ 2.0 Release Cut ] Bump Up Master Patch Version #8647

Uh oh!

Conversation

QilongTang commented Mar 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Declarations

Reviewers

FYIs

Uh oh!

ramramps Mar 12, 2018

Choose a reason for hiding this comment

Uh oh!

QilongTang Mar 12, 2018

Choose a reason for hiding this comment

Uh oh!

ramramps Mar 12, 2018

Choose a reason for hiding this comment

Uh oh!

mjkkirschner Mar 12, 2018

Choose a reason for hiding this comment

Uh oh!

QilongTang commented Mar 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

QilongTang commented Mar 12, 2018 •

edited

Loading