QNTM-3646: Fix creation of unwanted input port for list index-assignment #8648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparajit-pratap
commented
Mar 12, 2018
| else | ||
| return identiferNode; | ||
| //if (identiferNode.ArrayDimensions != null) | ||
| // return null; |
Contributor
Author
There was a problem hiding this comment.
Identifiers with array dimensions such as a[0] = x; were not considered "defined variables." I'm not sure due to what reason. I have removed this restriction so that these list identifiers can also be renamed uniquely in the code block node.
aparajit-pratap
commented
Mar 12, 2018
| </data> | ||
| <data name="MessageFailedToAutocomple" xml:space="preserve"> | ||
| <value>Failed to perform code block autocomplete with exception:</value> | ||
| </data> |
Contributor
Author
There was a problem hiding this comment.
Removing unused resources.
aparajit-pratap
commented
Mar 12, 2018
| { | ||
| "path": "DSCoreNodes.DSCore.DayOfWeek", | ||
| "iconUrl": "./dist/resources/DSCore.DayOfWeek.png" | ||
| } |
Contributor
Author
There was a problem hiding this comment.
More resource cleanup.
Contributor
There was a problem hiding this comment.
Again, no idea why this its to be removed.
Collaborator
|
@kronz @aparajit-pratap @smangarole @mjkkirschner @Racel The first candidate for cherry-picking? |
aparajit-pratap
commented
Mar 13, 2018
| { | ||
| var identiferNode = leftNode as IdentifierNode; | ||
| if (identiferNode.ArrayDimensions != null) | ||
| return null; |
Contributor
Author
There was a problem hiding this comment.
Identifiers with array dimensions such as a[0] = x; were not considered "defined variables." I'm not sure due to what reason. I have removed this restriction so that these list identifiers can also be renamed uniquely in the code block node.
pboyer
reviewed
Mar 14, 2018
| SRQEQS2sBCFFGiGVlbnAysCPTPALO8sSLPbBa5bwfuKaJRKJX/SWhYshcnZYLETk7LBYiMjZYbEQkbOT | ||
| 57mLIXJ2WCxE5OywWIjI2WGxEJGzw2IhImeHxZiHQd9LZP1hY0w2xkTWHzbGbAZOk7G7zqYt5ayzFyi2 | ||
| G/eq65Zy1tkLaO/rlXuWpTuOhp8zZP1hY0w9LMrPLl8vV6DPkfWHjTH1iPjY71x1OX+dI+sPG2Pqkebr | ||
| b4t561xENj56RIblBfTdN+Lx+OgRuXf9z9fi8UQi8W9k2RtEJDMphK5UYQAAAABJRU5ErkJggg== |
Contributor
There was a problem hiding this comment.
I have no idea why this change is here or whether its appropriate.
pboyer
reviewed
Mar 14, 2018
| definedVariables.Add(Statement.GetDefinedVariableNames( | ||
| statement, onlyTopLevel)); | ||
| } | ||
| return statements.Select(Statement.GetDefinedVariableNames).ToList(); |
Contributor
There was a problem hiding this comment.
If you're calling ToList() and the method is internal, why not simply make the return argument List? The IEnumerable abstraction actually loses valuable information for the caller.
Contributor
|
LGTM |
aparajit-pratap
added a commit
to aparajit-pratap/Dynamo
that referenced
this pull request
Mar 15, 2018
…ent (DynamoDS#8648) * fix for additional input port * fixes for output ports * update tests * added test, code cleanup * address review comments
saintentropy
added a commit
that referenced
this pull request
Oct 24, 2018
* Add RegisterFroTrace attribute as a trigger in Json serialization of trace * PR comment * [ 2.0 Release Cut ] Bump Up Master Patch Version (#8647) * Bump Up Patch Version * Add version * Update comments and version baseline * Address Comments * CubicMillimeterToCubicMeter conversion * Revert "CubicMillimeter To CubicMeter conversion" * Fix the units bug * Remove thread sleep * missed the test * Fix static property compilation and crash (#8649) * fix crash, compilation of static property * code cleanup * add test * add test graph * QNTM-3646: Fix creation of unwanted input port for list index-assignment (#8648) * fix for additional input port * fixes for output ports * update tests * added test, code cleanup * address review comments * QNTM-3279: Fix for crash when trying to directly call properties on class name (#8661) * fix for compiling property method as function pointer * code cleanup * add tests * Cherry-pick #8663 (#8664) * Update failing tests (#8663) * update tests * Merge LibG binaries with Geometry.Approximate API (#8666) * merge LibG binaries with Geometry.Approximate() * Update license * scroll bar fix in incanvas search * QNTM-3641: Prevent ColorRange node from crashing with old style List syntax (#8670) (#8674) * fix crash with ColorRange1D node * add test * add test set unsaved changes false when initializing json custom node * Update changes from librarie.js to fix QNTM-3710 (#8678) After investigating the errors in the EngOps check it was thought that these changes could not have caused the current failures. Other PRs have also shown the same issues. Given all of that, this PR is being merged. * address comments * Update LibG binaries for ASM224 branch (#8681) * update LibG binaries for ASM224 branch * PR comment * QNTM-3841 Add geometry creation option to Dynamo CLI (#8775) * POC * Cleanup code. * Add command line option -g for generating geometry json file. * Remove filtering * Fix node state flags at load time. * Use UpdateValue for setting isVisible on node model. Revert set to private. * Remove filtering. * Clean up holder code. * Cleanup converter code. Use node model defaults as starting point. * Preload the same libraries for CLI as for Sandbox. * Add color support * Simplify json * Update file format. * Remove property expressions. * Restore comment. * Restore Cef Settings * Add unit test for CLI geometry option. * Remove comment. * Don't extend CommandLineRunner. * Use var when possible. * Remove commented out code. * Use DynamoViewModel in CLI. * Use DefaultWatch3DViewModel for CLI. * Add new project DynamoWPFCLI. * Let CommandLineRunnerWPF inherit from CommandLineRunner. * Fix review comments. * Fix unstable unit tests. * Remove Dispose method. * Add comments * Fix type check * Apply same fix to NodeInputData * Add serialization tests * Fix typo in Extansion. * QNTM-4278 DynamoWPFCLI should use CoGs geometry format (#8887) * POC * Cleanup code. * Add command line option -g for generating geometry json file. * Remove filtering * Fix node state flags at load time. * Use UpdateValue for setting isVisible on node model. Revert set to private. * Remove filtering. * Clean up holder code. * Cleanup converter code. Use node model defaults as starting point. * Preload the same libraries for CLI as for Sandbox. * Add color support * Simplify json * Update file format. * Remove property expressions. * Restore comment. * Restore Cef Settings * Add unit test for CLI geometry option. * Remove comment. * Don't extend CommandLineRunner. * Use var when possible. * Remove commented out code. * Use DynamoViewModel in CLI. * Use DefaultWatch3DViewModel for CLI. * Add new project DynamoWPFCLI. * Let CommandLineRunnerWPF inherit from CommandLineRunner. * Fix review comments. * Fix unstable unit tests. * Remove Dispose method. * Add comments * First pass * Formatting fixes. * Remove XML stuff. * Some final adjustments. * Add more comments. * Move comment. * Only store the geometry array. * Refactor. * Add interface * Make interface internal * Rename implmentation. * Allow internal access for CLI * Move default implementation to core. * Make setters private * Address review comments. * match Revit CEF intitializtion settings * match Revit CEF intitializtion settings * match Revit CEF intitializtion settings * QNTM-5580 - Correct Typo in the Dynamo json serialization to match CoGS API (#9170) * Fix typo * Obsolete the existing property * Update test * remove expression body syntax * Add serialization test with typo * AVP NumberInputNode deserialization * add testing * QNTM-5568 Refinery needs to support culture invariance for number fmt, part Deux (#9178) * Don't culture format value strings. * Assume value strings are formated with `InvariantCulture` * Add tests * More work on tests * Clarify switching of cultures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix creation of unwanted input port for list index-assignment and restore corresponding missing output port.
Github issue: #8634
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@pboyer
FYI
@kronz @jnealb