Skip to content

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Mar 15, 2018

Cherry-pick #8649 and #8648

@QilongTang need a review before I can merge this. GitHub will not allow me to otherwise. Thanks.

* fix crash, compilation of static property

* code cleanup

* add test

* add test graph
…ent (DynamoDS#8648)

* fix for additional input port

* fixes for output ports

* update tests

* added test, code cleanup

* address review comments
@QilongTang QilongTang self-assigned this Mar 15, 2018
@QilongTang QilongTang added this to the 2.0 milestone Mar 15, 2018
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramramps ramramps merged commit 2acbc0d into DynamoDS:RC2.0.0_master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants