AVP NumberInputNode deserialization #8900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
Member
|
test? |
Contributor
Author
|
@mjkkirschner added test cases for deserialization of input values of 1, 1.0, 1.1 where 1 was originally failing |
Contributor
|
@alfarok Thank you for doing that 😉 |
Collaborator
|
@alfarok @mjkkirschner @QilongTang @mrahmaniasl @saintentropy @nonoesp @varvaratou Is there a JIRA task for this? |
Contributor
Author
Collaborator
|
@alfarok No, thanks, we just need to track the task for Refinery as the fix affects the project (and is not in 2.0.1) |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses the Dynamo deserialization of a
NumberInputnode that was originally serialized in AVP. TheNumberInputnode in AVP defines theInputValueproperty of typenumber. If the value is an integer (1, 1.0, 1.00, etc) the value is always serialized as 1 (without any decimals). Upon deserialization in Dynamo an error was being thrown while attempting to parse the expecteddoublevalue. This change resolves the issue and enables proper deserialization/execution.Testing
3 unit tests added verifying proper deserialization of number nodes containing values of 1, 1.0, 1.1
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@ramramps