[react] React 18 types#56210
Conversation
|
Considering the pivotal argument for the implicit children change is that all the other excess props are rejected so why would we treat children any differently. 
I get it. You like it simple, generic, elegant. Exceptions hurt, are ugly and nobody likes them. But the thing is, whether we like them or not doesn't change the actual engine this is supposed to annotate and it is this exact change that makes children implicit. It blatantly ignores and obfuscates behaviour that's an integral part of the API. Apart from that, the only purpose this served was that of an impediment to updating react to 18. This whole endeavour is quite simply flabberghasting. |
|
Still, if your component doesn't use |
Overwhelmed by compile errors after upgrading to
@types/react@^18.0.0? Check out https://github.com/eps1lon/types-react-codemod.Upgrading to React 18 with TypeScript
Breaking Changes
Removal of implicit children
For components that do implement
childrenbut relied on their implicit declaration fromReact.FunctionComponentorReact.Component:interface Props { + children?: React.ReactNode; } class SomeClassComponents React.Component<Props> { render() { return <div>{this.props.children}</div> } } const SomeFunctionComponent: React.FunctionComponent<Props> = props => <div>{props.children}</div>Please check Removal Of Implicit Children for the rationale.
I may have a solution to bring these back on-demand without patching the published types (watch #59751)
Remove
{}fromReactFragmentThis was never correct and mostly required to interop with implicit
children.this.contextbecomesunknownWas
anybefore. The community mostly prefersunknownby default (anywould silently be unsound).Restore old behavior:
class Component extends React.Component { + context: any; render() { return this.context.value; } } ### `noImplicitAny` and `useCallback` Enabling `noImplicitAny` in `tsconfig` (on by default with `strict: true`) will not type-check if an explicit type is omitted in `useCallback`. ```diff + // @ts-expect-error -- `event` as implicitly type 'any' useCallback((event) => {})Remove deprecated types
Bringing the terminology more in line with how they're called in the React docs and repository.
Issues
Closes #46691
Closes #34237
Closes #56026
Closes #52873
Follow-up:
react-dom/node-streamentrypoint from v17 since that no longer exists there either ([react-dom] Remove /node-stream entrypoint #59747)createMutableSourcefrom/experimental([react] Remove unstable_createMutableSource #59746)react-dom/serveras mentioned in [react] React 18 types #56210 (comment) ([react-dom] AddrenderToPipeableStreamandrenderToReadableStream#59748)react-test-rendererfor React 18 ([react-test-renderer] Publish as v18 #59813