@gaearon Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• react — on npm, on unpkg

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ❌ No merge conflicts
• ❌ Continuous integration tests have failed
• 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned, and therefore closed!

{
  "type": "info",
  "now": "-",
  "pr_number": 56026,
  "author": "gaearon",
  "headCommitOid": "554ac320c29b72afa36183a829d8410b95fe4444",
  "lastPushDate": "2021-10-14T19:29:47.000Z",
  "lastActivityDate": "2021-10-14T19:29:47.000Z",
  "hasMergeConflict": true,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react",
      "kind": "edit",
      "files": [
        {
          "path": "types/react/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "johnnyreilly",
        "bbenezech",
        "pzavolinsky",
        "ericanderson",
        "DovydasNavickas",
        "theruther4d",
        "guilhermehubner",
        "ferdaber",
        "jrakotoharisoa",
        "pascaloliv",
        "hotell",
        "franklixuefei",
        "Jessidhia",
        "saranshkataria",
        "lukyth",
        "eps1lon",
        "zieka",
        "dancerphil",
        "dimitropoulos",
        "disjukr",
        "vhfmag",
        "hellatan",
        "priyanshurav"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "jonny22094",
      "date": "2021-10-05T13:59:24.000Z",
      "abbrOid": "442d681"
    },
    {
      "type": "stale",
      "reviewer": "geovanasilva",
      "date": "2021-09-28T14:40:14.000Z",
      "abbrOid": "442d681"
    },
    {
      "type": "stale",
      "reviewer": "renatorib",
      "date": "2021-09-28T14:38:57.000Z",
      "abbrOid": "442d681"
    },
    {
      "type": "stale",
      "reviewer": "ValentinMumble",
      "date": "2021-09-28T14:31:13.000Z",
      "abbrOid": "442d681"
    }
  ],
  "mainBotCommentID": 929285295,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/554ac320c29b72afa36183a829d8410b95fe4444/checks?check_suite_id=4057588120"
}

Hey @gaearon,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

(Note I don't really understand if that was the only reason it's there. Maybe there's some subtler fix. Just wanted to surface this.)

possibly related

#33346
#34530

I think we always wanted to remove that but by this point so many downstream packages depend on the previous behavior that nobody wanted to spent time fixing all of them. Would be awesome if someone would do that. Just a heads up that this may take a while.

Hopefully no package depends on 0.13 typings. Otherwise we'll have to add typings for that which still include {}.

@gaearon The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Looked at some failures and we may need to wait for the removal of implicit children (scheduled for React 18 typings #46691) for this fix to work.

The blocker is things like declare const Component: ComponentType<Props> where children of Component implements render-props. Unfortunately, ComponentType implicitly adds { children?: ReactNode }. We end up with props typed as { children: () => ReactNode } & { children?: React: ReactNode }. There is no valid intersection of a function with ReactNode anymore with this change so the render-props are rejected ultimately.

Added this PR to the list of things we want to land with React 18 typings.

@gaearon Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@gaearon The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@gaearon Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@gaearon I haven't seen any activity on this PR in more than three weeks, and it still has problems that prevent it from being merged. The PR will be closed on Nov 13th (in a week) if the issues aren't addressed.

@gaearon To keep things tidy, we have to close PRs that aren't mergeable and don't have activity in the last month. No worries, though — please open a new PR if you'd like to continue with this change. Thank you!