[react] Remove unstable_createMutableSource #59746
Conversation
vite-plugin-react-svg's dependencies require 1. 'lib' to include 'dom' 2. The minimum typescript version to be 4.0.
05c9184 to
1883e40
Compare
| // Definitions by: Priyanshu Rav <https://github.com/priyanshurav> | ||
| // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped | ||
| // Minimum TypeScript Version: 3.8 | ||
| // Minimum TypeScript Version: 4.0 |
| "module": "commonjs", | ||
| "lib": [ | ||
| "es6" | ||
| "es6", "dom" |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. react (unpkg)was missing the following properties:
|
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59746,
"author": "eps1lon",
"headCommitOid": "1883e40ff826f08765d62aa3055f46d282902636",
"mergeBaseOid": "dac9b82160ab002f77a400383d2663c264041080",
"lastPushDate": "2022-04-09T15:53:40.000Z",
"lastActivityDate": "2022-04-09T17:49:48.000Z",
"mergeOfferDate": "2022-04-09T16:32:28.000Z",
"mergeRequestDate": "2022-04-09T17:49:48.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/experimental.d.ts",
"kind": "definition"
},
{
"path": "types/react/test/experimental.tsx",
"kind": "test"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "vite-plugin-react-svg",
"kind": "edit",
"files": [
{
"path": "types/vite-plugin-react-svg/index.d.ts",
"kind": "definition"
},
{
"path": "types/vite-plugin-react-svg/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"priyanshurav"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "johnnyreilly",
"date": "2022-04-09T16:31:44.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 1094079752,
"ciResult": "pass"
} |
|
🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav — please review this PR in the next few days. Be sure to explicitly select |
|
Ready to merge |
Was removed in facebook/react#24209