[react-test-renderer] Publish as v18 #59813
Conversation
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. react-test-renderer (unpkg)was missing the following properties:
|
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
@eps1lon: I see that you have added yourself as an owner, are you sure you want to become an owner? Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 59813,
"author": "eps1lon",
"headCommitOid": "896c9d23be7c5c5abb8777c709fa05bc6fb52830",
"mergeBaseOid": "fca9dca5950b744c1286a86a1622d6c566d4ed84",
"lastPushDate": "2022-04-11T05:38:44.000Z",
"lastActivityDate": "2022-04-12T05:50:52.000Z",
"mergeOfferDate": "2022-04-12T05:44:22.000Z",
"mergeRequestDate": "2022-04-12T05:50:52.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react-test-renderer",
"kind": "edit",
"files": [
{
"path": "types/react-test-renderer/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-test-renderer/v17/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-test-renderer/v17/react-test-renderer-tests.ts",
"kind": "test"
},
{
"path": "types/react-test-renderer/v17/shallow/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-test-renderer/v17/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/react-test-renderer/v17/tslint.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
}
],
"owners": [
"arvitaly",
"lochbrunner",
"johnnyreilly",
"jgoz",
"Jessidhia",
"maddhruv"
],
"addedOwners": [
"eps1lon"
],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "johnnyreilly",
"date": "2022-04-12T05:43:42.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "jgoz",
"date": "2022-04-12T04:13:41.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 1094577905,
"ciResult": "pass"
} |
|
🔔 @arvitaly @lochbrunner @johnnyreilly @jgoz @Jessidhia @maddhruv — please review this PR in the next few days. Be sure to explicitly select |
|
@eps1lon: Everything looks good here. I am ready to merge this PR (at 896c9d2) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@arvitaly, @lochbrunner, @johnnyreilly, @jgoz, @Jessidhia, @maddhruv: you can do this too.) |
|
Ready to merge |
https://unpkg.com/browse/react-test-renderer@18.0.0/
No runtime breaking changes found in https://github.com/facebook/react/blob/main/CHANGELOG.md#1800-march-29-2022 and there were no type-related breaking changes planned for
react-test-renderer