Skip to content

Bump protobuf Bazel dep to 34.1.#48228

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/bump-protobuf-34.1
Mar 23, 2026
Merged

Bump protobuf Bazel dep to 34.1.#48228
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/bump-protobuf-34.1

Conversation

@rdesgroppes
Copy link
Copy Markdown
Contributor

@rdesgroppes rdesgroppes commented Mar 23, 2026

What does this PR do?

Following #46948, this is to update the protobuf Bazel module dependency from 29.1 to 34.1.

Motivation

Several transitive dependencies now require protobuf >= 34.0, causing Renovate to fail updating MODULE.bazel.lock:

ERROR: For repository 'protobuf', the root module requires module version protobuf@29.1, but got protobuf@34.0.bcr.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off

Bumping to 34.1 satisfies that constraint and also aligns with the recent:

Describe how you validated your changes

Built @protobuf//:protobuf locally.

Additional Notes

  • the existing patch (add -lstdc++ to //conditions:default link opts) applies cleanly to 34.1 without modification,
  • 34.0 wouldn't be enough, since it's strictly less than 34.0.bcr.1.

@rdesgroppes rdesgroppes requested a review from a team as a code owner March 23, 2026 16:10
@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 23, 2026
@rdesgroppes rdesgroppes changed the title Bump protobuf Bazel dep from to 34.1. Bump protobuf Bazel dep to 34.1. Mar 23, 2026
@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-build labels Mar 23, 2026
@github-actions github-actions bot added the medium review PR review might take time label Mar 23, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80fee27f8e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

### What does this PR do?
Following #46948, this is to update the `protobuf` Bazel module
dependency from 29.1 to 34.1.

### Motivation
Several transitive dependencies now require `protobuf` >= 34.0.bcr.1,
causing `Renovate` to fail updating `MODULE.bazel.lock` (see
#48223 (comment)).

Bumping to 34.1 satisfies that constraint.

### Describe how you validated your changes
Built `@protobuf//:protobuf` locally.

### Additional Notes
The existing patch (add `-lstdc++` to `//conditions:default` link opts)
applies cleanly to 34.1 without modification.
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/bump-protobuf-34.1 branch from 80fee27 to 7abcfaf Compare March 23, 2026 16:19
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor cc12a65a:

Results for datadog-agent_7.79.0~devel.git.72.7abcfaf.pipeline.104024084-1_amd64.deb:

No change detected

@rdesgroppes
Copy link
Copy Markdown
Contributor Author

Thanks, @aiuto!

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor cc12a65
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 752.787 MiB
agent_deb_amd64_fips 709.746 MiB
agent_heroku_amd64 313.153 MiB
agent_msi 604.642 MiB
agent_rpm_amd64 752.771 MiB
agent_rpm_amd64_fips 709.730 MiB
agent_rpm_arm64 731.146 MiB
agent_rpm_arm64_fips 691.127 MiB
agent_suse_amd64 752.771 MiB
agent_suse_amd64_fips 709.730 MiB
agent_suse_arm64 731.146 MiB
agent_suse_arm64_fips 691.127 MiB
docker_agent_amd64 813.094 MiB
docker_agent_arm64 816.232 MiB
docker_agent_jmx_amd64 1004.009 MiB
docker_agent_jmx_arm64 995.926 MiB
docker_cluster_agent_amd64 205.320 MiB
docker_cluster_agent_arm64 219.677 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 39.230 MiB
docker_dogstatsd_arm64 37.445 MiB
dogstatsd_deb_amd64 29.874 MiB
dogstatsd_deb_arm64 28.026 MiB
dogstatsd_rpm_amd64 29.874 MiB
dogstatsd_suse_amd64 29.874 MiB
iot_agent_deb_amd64 43.262 MiB
iot_agent_deb_arm64 40.309 MiB
iot_agent_deb_armhf 41.052 MiB
iot_agent_rpm_amd64 43.262 MiB
iot_agent_suse_amd64 43.262 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 +26.13 KiB (0.01% increase) 174.797 → 174.823 → 178.360
agent_deb_amd64_fips -15.31 KiB (0.01% reduction) 165.400 → 165.385 → 172.790
agent_heroku_amd64 neutral 74.981 MiB → 79.970
agent_msi +8.0 KiB (0.01% increase) 138.336 → 138.344 → 146.220
agent_rpm_amd64 -23.16 KiB (0.01% reduction) 177.652 → 177.629 → 181.830
agent_rpm_amd64_fips +27.54 KiB (0.02% increase) 167.650 → 167.677 → 173.370
agent_rpm_arm64 -10.37 KiB (0.01% reduction) 159.632 → 159.622 → 163.060
agent_rpm_arm64_fips -19.7 KiB (0.01% reduction) 151.481 → 151.462 → 156.170
agent_suse_amd64 -23.16 KiB (0.01% reduction) 177.652 → 177.629 → 181.830
agent_suse_amd64_fips +27.54 KiB (0.02% increase) 167.650 → 167.677 → 173.370
agent_suse_arm64 -10.37 KiB (0.01% reduction) 159.632 → 159.622 → 163.060
agent_suse_arm64_fips -19.7 KiB (0.01% reduction) 151.481 → 151.462 → 156.170
docker_agent_amd64 neutral 268.247 MiB → 272.480
docker_agent_arm64 neutral 255.442 MiB → 261.060
docker_agent_jmx_amd64 neutral 336.900 MiB → 341.100
docker_agent_jmx_arm64 neutral 320.082 MiB → 325.620
docker_cluster_agent_amd64 neutral 71.930 MiB → 72.920
docker_cluster_agent_arm64 neutral 67.505 MiB → 68.220
docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.169 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.484 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.890 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.775 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.902 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.902 MiB → 8.800
iot_agent_deb_amd64 -2.59 KiB (0.02% reduction) 11.397 → 11.394 → 12.040
iot_agent_deb_arm64 -2.12 KiB (0.02% reduction) 9.700 → 9.698 → 10.450
iot_agent_deb_armhf neutral 9.935 MiB → 10.620
iot_agent_rpm_amd64 -2.24 KiB (0.02% reduction) 11.412 → 11.410 → 12.060
iot_agent_suse_amd64 -2.24 KiB (0.02% reduction) 11.412 → 11.410 → 12.060

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Mar 23, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0566b50e-0eae-48d9-ad09-1e11030ea932

Baseline: 3697d3b
Comparison: d3d2691
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.45 [-0.63, +5.53] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.45 [-0.63, +5.53] 1 Logs
otlp_ingest_metrics memory utilization +0.51 [+0.35, +0.67] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.36 [+0.24, +0.48] 1 Logs
ddot_metrics memory utilization +0.21 [+0.03, +0.40] 1 Logs
ddot_metrics_sum_delta memory utilization +0.18 [+0.01, +0.35] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.18 [+0.03, +0.32] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.17 [-0.05, +0.40] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.15 [+0.09, +0.21] 1 Logs
ddot_logs memory utilization +0.13 [+0.07, +0.20] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.03, +0.13] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.03 [-0.40, +0.46] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.19, +0.22] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.52, +0.52] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.11, +0.11] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.22, +0.19] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.41, +0.37] 1 Logs
quality_gate_idle memory utilization -0.09 [-0.14, -0.03] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization -0.35 [-0.45, -0.25] 1 Logs
file_tree memory utilization -0.43 [-0.48, -0.38] 1 Logs
quality_gate_logs % cpu utilization -0.44 [-1.99, +1.10] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -0.51 [-0.55, -0.47] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization -0.51 [-0.58, -0.44] 1 Logs
quality_gate_metrics_logs memory utilization -1.19 [-1.43, -0.96] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 680 ≥ 26
docker_containers_memory memory_usage 10/10 275.79MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 660 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 173.81MiB ≤ 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 2 ≤ 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 498.75MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 206.99MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 379.29 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 409.42MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit d3d2691 into main Mar 23, 2026
261 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/bump-protobuf-34.1 branch March 23, 2026 18:01
@github-actions github-actions bot added this to the 7.79.0 milestone Mar 23, 2026
rdesgroppes added a commit that referenced this pull request Mar 23, 2026
### What does this PR do?

Upgrades the Bazel toolchain from 8.6.0 to 9.0.1.

### Motivation

9.0.1 ships two upstream fixes that directly benefit our build:

- bazelbuild/bazel#28606: NPE when `--repo_env` is set to an env var
  that has no value — contributed by Datadog (Joseph Gette).
- bazelbuild/bazel#26842: `DefaultSyscallCache` incorrectly treated
  `BUILD` files and `build` directories as the same entry on
  case-insensitive / normalizing filesystems (e.g. Linux container on
  a macOS host), causing spurious build failures.

### Describe how you validated your changes

`bazel test //...` passes.

### Additional Notes

Groundwork landed in advance:
- #47716: Bump `rules_cc` with explicit loads for Bazel 9
- #47745: Fix `rules_cc` leftovers from #47716 for Bazel 9
- #47982: Add explicit `cc_static_library` import for Bazel 9
- #48016: Add explicit `py_binary` import for Bazel 9
- #48071: Bump `rules_foreign_cc` for Bazel 9 fixes
- #48082: Bump `rules_python` to 1.9.0 and fix misuses spotted on Windows
- #48183: Fix Python hermetic toolchain check for Bazel 9
- #48186: Disable `repo_contents_cache` when in-workspace for Bazel 9
- #48228: Bump `protobuf` Bazel dep to 34.1
rdesgroppes added a commit that referenced this pull request Mar 24, 2026
### What does this PR do?

Upgrades the Bazel toolchain from 8.6.0 to 9.0.1.

### Motivation

9.0.1 ships two upstream fixes that directly benefit our build:

- bazelbuild/bazel#28606: NPE when `--repo_env` is set to an env var
  that has no value — contributed by Datadog (Joseph Gette).
- bazelbuild/bazel#26842: `DefaultSyscallCache` incorrectly treated
  `BUILD` files and `build` directories as the same entry on
  case-insensitive / normalizing filesystems (e.g. Linux container on
  a macOS host), causing spurious build failures.

### Describe how you validated your changes

`bazel test //...` passes.

### Additional Notes

Groundwork landed in advance:
- #47716: Bump `rules_cc` with explicit loads for Bazel 9
- #47745: Fix `rules_cc` leftovers from #47716 for Bazel 9
- #47982: Add explicit `cc_static_library` import for Bazel 9
- #48016: Add explicit `py_binary` import for Bazel 9
- #48071: Bump `rules_foreign_cc` for Bazel 9 fixes
- #48082: Bump `rules_python` to 1.9.0 and fix misuses spotted on Windows
- #48183: Fix Python hermetic toolchain check for Bazel 9
- #48186: Disable `repo_contents_cache` when in-workspace for Bazel 9
- #48228: Bump `protobuf` Bazel dep to 34.1
gh-worker-dd-mergequeue-cf854d bot pushed a commit that referenced this pull request Mar 24, 2026
### What does this PR do?
Upgrade `bazel` from 8.6.0 to 9.0.1.

### Motivation
Bazel 9.0.1 ships upstream fixes that directly benefit our build & developer experience:
- bazelbuild/bazel#26842: `BUILD` files and `build` directories were incorrectly treated as the same entry on case-insensitive filesystems (e.g., Linux container running on a macOS host), causing spurious build failures (esp. for `rloader` we had to `gazelle`-exclude because of that),
- bazelbuild/bazel#27695: a contribution of ours (also available in 8.6.0 as bazelbuild/bazel#28367) - nice to have when sharing a folder between a Linux host and a Windows VM through `virtiofs`,
- bazelbuild/bazel#28640: another contribution of ours (@JSGette) - critical because it what preventing us from switching to Bazel 9 (ADMS config).

### Describe how you validated your changes
`bazel test //...` passes.

### Additional Notes
Groundwork landed in advance:
- #47716
- #47745
- #47982
- #48016
- #48071
- #48082
- #48183
- #48186
- #48200 (>= Bazel 9 min)
- #48201 (>= Bazel 9 min)
- #48228 (>= Bazel 9 min)

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
aya-shimizu24 pushed a commit that referenced this pull request Mar 24, 2026
### What does this PR do?
Following #46948, this is to update the `protobuf` Bazel module dependency from 29.1 to 34.1.

### Motivation
Several transitive dependencies now require `protobuf` >= 34.0, causing `Renovate` to [fail updating](#48223 (comment)) `MODULE.bazel.lock`:
> ERROR: For repository 'protobuf', the root module requires module version protobuf@29.1, but got protobuf@34.0.bcr.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off

Bumping to 34.1 satisfies that constraint and also aligns with the recent:
- #46948.

### Describe how you validated your changes
Built `@protobuf//:protobuf` locally.

### Additional Notes
- the existing patch (add `-lstdc++` to `//conditions:default` link opts) applies cleanly to 34.1 without modification,
- `34.0` wouldn't be enough, since it's **strictly less than** `34.0.bcr.1`.

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
aya-shimizu24 pushed a commit that referenced this pull request Mar 24, 2026
### What does this PR do?
Upgrade `bazel` from 8.6.0 to 9.0.1.

### Motivation
Bazel 9.0.1 ships upstream fixes that directly benefit our build & developer experience:
- bazelbuild/bazel#26842: `BUILD` files and `build` directories were incorrectly treated as the same entry on case-insensitive filesystems (e.g., Linux container running on a macOS host), causing spurious build failures (esp. for `rloader` we had to `gazelle`-exclude because of that),
- bazelbuild/bazel#27695: a contribution of ours (also available in 8.6.0 as bazelbuild/bazel#28367) - nice to have when sharing a folder between a Linux host and a Windows VM through `virtiofs`,
- bazelbuild/bazel#28640: another contribution of ours (@JSGette) - critical because it what preventing us from switching to Bazel 9 (ADMS config).

### Describe how you validated your changes
`bazel test //...` passes.

### Additional Notes
Groundwork landed in advance:
- #47716
- #47745
- #47982
- #48016
- #48071
- #48082
- #48183
- #48186
- #48200 (>= Bazel 9 min)
- #48201 (>= Bazel 9 min)
- #48228 (>= Bazel 9 min)

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely pushed a commit that referenced this pull request Mar 27, 2026
### What does this PR do?
Following #46948, this is to update the `protobuf` Bazel module dependency from 29.1 to 34.1.

### Motivation
Several transitive dependencies now require `protobuf` >= 34.0, causing `Renovate` to [fail updating](#48223 (comment)) `MODULE.bazel.lock`:
> ERROR: For repository 'protobuf', the root module requires module version protobuf@29.1, but got protobuf@34.0.bcr.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off

Bumping to 34.1 satisfies that constraint and also aligns with the recent:
- #46948.

### Describe how you validated your changes
Built `@protobuf//:protobuf` locally.

### Additional Notes
- the existing patch (add `-lstdc++` to `//conditions:default` link opts) applies cleanly to 34.1 without modification,
- `34.0` wouldn't be enough, since it's **strictly less than** `34.0.bcr.1`.

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely pushed a commit that referenced this pull request Mar 27, 2026
### What does this PR do?
Upgrade `bazel` from 8.6.0 to 9.0.1.

### Motivation
Bazel 9.0.1 ships upstream fixes that directly benefit our build & developer experience:
- bazelbuild/bazel#26842: `BUILD` files and `build` directories were incorrectly treated as the same entry on case-insensitive filesystems (e.g., Linux container running on a macOS host), causing spurious build failures (esp. for `rloader` we had to `gazelle`-exclude because of that),
- bazelbuild/bazel#27695: a contribution of ours (also available in 8.6.0 as bazelbuild/bazel#28367) - nice to have when sharing a folder between a Linux host and a Windows VM through `virtiofs`,
- bazelbuild/bazel#28640: another contribution of ours (@JSGette) - critical because it what preventing us from switching to Bazel 9 (ADMS config).

### Describe how you validated your changes
`bazel test //...` passes.

### Additional Notes
Groundwork landed in advance:
- #47716
- #47745
- #47982
- #48016
- #48071
- #48082
- #48183
- #48186
- #48200 (>= Bazel 9 min)
- #48201 (>= Bazel 9 min)
- #48228 (>= Bazel 9 min)

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely pushed a commit that referenced this pull request Mar 27, 2026
### What does this PR do?
Following #46948, this is to update the `protobuf` Bazel module dependency from 29.1 to 34.1.

### Motivation
Several transitive dependencies now require `protobuf` >= 34.0, causing `Renovate` to [fail updating](#48223 (comment)) `MODULE.bazel.lock`:
> ERROR: For repository 'protobuf', the root module requires module version protobuf@29.1, but got protobuf@34.0.bcr.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off

Bumping to 34.1 satisfies that constraint and also aligns with the recent:
- #46948.

### Describe how you validated your changes
Built `@protobuf//:protobuf` locally.

### Additional Notes
- the existing patch (add `-lstdc++` to `//conditions:default` link opts) applies cleanly to 34.1 without modification,
- `34.0` wouldn't be enough, since it's **strictly less than** `34.0.bcr.1`.

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely pushed a commit that referenced this pull request Mar 27, 2026
### What does this PR do?
Upgrade `bazel` from 8.6.0 to 9.0.1.

### Motivation
Bazel 9.0.1 ships upstream fixes that directly benefit our build & developer experience:
- bazelbuild/bazel#26842: `BUILD` files and `build` directories were incorrectly treated as the same entry on case-insensitive filesystems (e.g., Linux container running on a macOS host), causing spurious build failures (esp. for `rloader` we had to `gazelle`-exclude because of that),
- bazelbuild/bazel#27695: a contribution of ours (also available in 8.6.0 as bazelbuild/bazel#28367) - nice to have when sharing a folder between a Linux host and a Windows VM through `virtiofs`,
- bazelbuild/bazel#28640: another contribution of ours (@JSGette) - critical because it what preventing us from switching to Bazel 9 (ADMS config).

### Describe how you validated your changes
`bazel test //...` passes.

### Additional Notes
Groundwork landed in advance:
- #47716
- #47745
- #47982
- #48016
- #48071
- #48082
- #48183
- #48186
- #48200 (>= Bazel 9 min)
- #48201 (>= Bazel 9 min)
- #48228 (>= Bazel 9 min)

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants