Fix `rules_cc` leftovers from #47716 for Bazel 9 by rdesgroppes · Pull Request #47745 · DataDog/datadog-agent

rdesgroppes · 2026-03-11T22:09:58Z

What does this PR do?

Completes the full rules_cc migration started in #47716, covering the cases I missed: our own .bzl rule files and the gcc-toolchain external dependency.

Motivation

#47716 covered our BUILD.bazel files but left other files still relying on injected globals, absent from Bazel 9+.

Additional Notes

The additional patch to gcc-toolchain will disappear once f0rmiga/gcc-toolchain#217 gets merged.

### What does this PR do? Completes the full `rules_cc` migration started in #47716, covering the cases that were missed: our own .bzl rule files and the `gcc-toolchain` external dependency. ### Motivation #47716 covered `BUILD.bazel` files but left several `.bzl` files still relying on injected globals, absent from Bazel 9+. ### Additional Notes The additional patch to `gcc-toolchain` will disappear once f0rmiga/gcc-toolchain#217 gets merged.

agent-platform-auto-pr · 2026-03-11T23:04:07Z

Files inventory check summary

File checks results against ancestor 29de6847:

Results for datadog-agent_7.78.0~devel.git.524.f2c32a2.pipeline.102040430-1_amd64.deb:

No change detected

agent-platform-auto-pr · 2026-03-11T23:17:26Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor fdf4c61
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	746.875 MiB
✅	agent_deb_amd64_fips	705.203 MiB
✅	agent_heroku_amd64	311.742 MiB
✅	agent_msi	609.816 MiB
✅	agent_rpm_amd64	746.858 MiB
✅	agent_rpm_amd64_fips	705.186 MiB
✅	agent_rpm_arm64	724.726 MiB
✅	agent_rpm_arm64_fips	686.072 MiB
✅	agent_suse_amd64	746.858 MiB
✅	agent_suse_amd64_fips	705.186 MiB
✅	agent_suse_arm64	724.726 MiB
✅	agent_suse_arm64_fips	686.072 MiB
✅	docker_agent_amd64	807.196 MiB
✅	docker_agent_arm64	809.869 MiB
✅	docker_agent_jmx_amd64	998.111 MiB
✅	docker_agent_jmx_arm64	989.564 MiB
✅	docker_cluster_agent_amd64	203.665 MiB
✅	docker_cluster_agent_arm64	218.100 MiB
✅	docker_cws_instrumentation_amd64	7.138 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_dogstatsd_amd64	38.631 MiB
✅	docker_dogstatsd_arm64	36.939 MiB
✅	dogstatsd_deb_amd64	29.855 MiB
✅	dogstatsd_deb_arm64	28.008 MiB
✅	dogstatsd_rpm_amd64	29.855 MiB
✅	dogstatsd_suse_amd64	29.855 MiB
✅	iot_agent_deb_amd64	43.068 MiB
✅	iot_agent_deb_arm64	40.130 MiB
✅	iot_agent_deb_armhf	40.870 MiB
✅	iot_agent_rpm_amd64	43.068 MiB
✅	iot_agent_suse_amd64	43.068 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-10.86 KiB (0.01% reduction)	174.427 → 174.416 → 177.700
✅	agent_deb_amd64_fips	+28.36 KiB (0.02% increase)	165.350 → 165.378 → 172.230
✅	agent_heroku_amd64	neutral	75.170 MiB → 79.970
✅	agent_msi	-4.0 KiB (0.00% reduction)	138.027 → 138.023 → 146.220
✅	agent_rpm_amd64	+34.89 KiB (0.02% increase)	176.407 → 176.442 → 180.780
✅	agent_rpm_amd64_fips	-9.47 KiB (0.01% reduction)	168.115 → 168.105 → 173.370
✅	agent_rpm_arm64	+20.55 KiB (0.01% increase)	159.252 → 159.272 → 161.610
✅	agent_rpm_arm64_fips	-46.71 KiB (0.03% reduction)	151.437 → 151.392 → 155.910
✅	agent_suse_amd64	+34.89 KiB (0.02% increase)	176.407 → 176.442 → 180.780
✅	agent_suse_amd64_fips	-9.47 KiB (0.01% reduction)	168.115 → 168.105 → 173.370
✅	agent_suse_arm64	+20.55 KiB (0.01% increase)	159.252 → 159.272 → 161.610
✅	agent_suse_arm64_fips	-46.71 KiB (0.03% reduction)	151.437 → 151.392 → 155.910
✅	docker_agent_amd64	+2.26 KiB (0.00% increase)	267.115 → 267.117 → 271.240
✅	docker_agent_arm64	+3.57 KiB (0.00% increase)	254.428 → 254.431 → 259.800
✅	docker_agent_jmx_amd64	-6.33 KiB (0.00% reduction)	335.774 → 335.768 → 339.870
✅	docker_agent_jmx_arm64	+15.47 KiB (0.00% increase)	319.064 → 319.079 → 324.390
✅	docker_cluster_agent_amd64	neutral	71.290 MiB → 72.920
✅	docker_cluster_agent_arm64	neutral	66.927 MiB → 68.220
✅	docker_cws_instrumentation_amd64	neutral	2.997 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.728 MiB → 3.090
✅	docker_dogstatsd_amd64	neutral	14.949 MiB → 15.820
✅	docker_dogstatsd_arm64	neutral	14.282 MiB → 14.830
✅	dogstatsd_deb_amd64	neutral	7.888 MiB → 8.790
✅	dogstatsd_deb_arm64	neutral	6.772 MiB → 7.710
✅	dogstatsd_rpm_amd64	neutral	7.899 MiB → 8.800
✅	dogstatsd_suse_amd64	neutral	7.899 MiB → 8.800
✅	iot_agent_deb_amd64	neutral	11.355 MiB → 12.040
✅	iot_agent_deb_arm64	neutral	9.666 MiB → 10.450
✅	iot_agent_deb_armhf	neutral	9.899 MiB → 10.620
✅	iot_agent_rpm_amd64	neutral	11.374 MiB → 12.060
✅	iot_agent_suse_amd64	neutral	11.374 MiB → 12.060

cit-pr-commenter-54b7da · 2026-03-11T23:28:47Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0d15e072-1cd7-4c5f-ab30-42502238cbba

Baseline: 88d4c44
Comparison: a8601db
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-2.80	[-5.78, +0.18]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.08	[-0.56, +2.72]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.30	[+0.14, +0.46]	1	Logs
➖	ddot_logs	memory utilization	+0.22	[+0.17, +0.28]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.06	[+0.02, +0.10]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	+0.05	[-0.33, +0.44]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.03	[-0.40, +0.46]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.01	[-0.16, +0.19]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.08, +0.10]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.18, +0.17]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.08, +0.07]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.04	[-0.49, +0.41]	1	Logs
➖	quality_gate_idle	memory utilization	-0.08	[-0.13, -0.03]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.09	[-0.32, +0.13]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.12	[-0.29, +0.05]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.15	[-0.23, -0.06]	1	Logs
➖	file_tree	memory utilization	-0.29	[-0.35, -0.23]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.32	[-0.46, -0.18]	1	Logs
➖	ddot_metrics	memory utilization	-0.33	[-0.51, -0.14]	1	Logs
➖	docker_containers_memory	memory utilization	-0.34	[-0.43, -0.26]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.35	[-0.40, -0.29]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-0.97	[-1.21, -0.72]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-2.30	[-2.44, -2.16]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-2.80	[-5.78, +0.18]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	717 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	272.93MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	741 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.22GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	172.92MiB ≤ 175MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	496.79MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	204.03MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	338.67 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	402.54MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.

### What does this PR do? Upgrades the Bazel toolchain from 8.6.0 to 9.0.1. ### Motivation 9.0.1 ships two upstream fixes that directly benefit our build: - bazelbuild/bazel#28606: NPE when `--repo_env` is set to an env var that has no value — contributed by Datadog (Joseph Gette). - bazelbuild/bazel#26842: `DefaultSyscallCache` incorrectly treated `BUILD` files and `build` directories as the same entry on case-insensitive / normalizing filesystems (e.g. Linux container on a macOS host), causing spurious build failures. ### Describe how you validated your changes `bazel test //...` passes. ### Additional Notes Groundwork landed in advance: - #47716: Bump `rules_cc` with explicit loads for Bazel 9 - #47745: Fix `rules_cc` leftovers from #47716 for Bazel 9 - #47982: Add explicit `cc_static_library` import for Bazel 9 - #48016: Add explicit `py_binary` import for Bazel 9 - #48071: Bump `rules_foreign_cc` for Bazel 9 fixes - #48082: Bump `rules_python` to 1.9.0 and fix misuses spotted on Windows - #48183: Fix Python hermetic toolchain check for Bazel 9 - #48186: Disable `repo_contents_cache` when in-workspace for Bazel 9 - #48228: Bump `protobuf` Bazel dep to 34.1

@JSGette

### What does this PR do? Upgrade `bazel` from 8.6.0 to 9.0.1. ### Motivation Bazel 9.0.1 ships upstream fixes that directly benefit our build & developer experience: - bazelbuild/bazel#26842: `BUILD` files and `build` directories were incorrectly treated as the same entry on case-insensitive filesystems (e.g., Linux container running on a macOS host), causing spurious build failures (esp. for `rloader` we had to `gazelle`-exclude because of that), - bazelbuild/bazel#27695: a contribution of ours (also available in 8.6.0 as bazelbuild/bazel#28367) - nice to have when sharing a folder between a Linux host and a Windows VM through `virtiofs`, - bazelbuild/bazel#28640: another contribution of ours (@JSGette) - critical because it what preventing us from switching to Bazel 9 (ADMS config). ### Describe how you validated your changes `bazel test //...` passes. ### Additional Notes Groundwork landed in advance: - #47716 - #47745 - #47982 - #48016 - #48071 - #48082 - #48183 - #48186 - #48200 (>= Bazel 9 min) - #48201 (>= Bazel 9 min) - #48228 (>= Bazel 9 min) Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>

@JSGette

### What does this PR do? Upgrade `bazel` from 8.6.0 to 9.0.1. ### Motivation Bazel 9.0.1 ships upstream fixes that directly benefit our build & developer experience: - bazelbuild/bazel#26842: `BUILD` files and `build` directories were incorrectly treated as the same entry on case-insensitive filesystems (e.g., Linux container running on a macOS host), causing spurious build failures (esp. for `rloader` we had to `gazelle`-exclude because of that), - bazelbuild/bazel#27695: a contribution of ours (also available in 8.6.0 as bazelbuild/bazel#28367) - nice to have when sharing a folder between a Linux host and a Windows VM through `virtiofs`, - bazelbuild/bazel#28640: another contribution of ours (@JSGette) - critical because it what preventing us from switching to Bazel 9 (ADMS config). ### Describe how you validated your changes `bazel test //...` passes. ### Additional Notes Groundwork landed in advance: - #47716 - #47745 - #47982 - #48016 - #48071 - #48082 - #48183 - #48186 - #48200 (>= Bazel 9 min) - #48201 (>= Bazel 9 min) - #48228 (>= Bazel 9 min) Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>

@JSGette

### What does this PR do? Upgrade `bazel` from 8.6.0 to 9.0.1. ### Motivation Bazel 9.0.1 ships upstream fixes that directly benefit our build & developer experience: - bazelbuild/bazel#26842: `BUILD` files and `build` directories were incorrectly treated as the same entry on case-insensitive filesystems (e.g., Linux container running on a macOS host), causing spurious build failures (esp. for `rloader` we had to `gazelle`-exclude because of that), - bazelbuild/bazel#27695: a contribution of ours (also available in 8.6.0 as bazelbuild/bazel#28367) - nice to have when sharing a folder between a Linux host and a Windows VM through `virtiofs`, - bazelbuild/bazel#28640: another contribution of ours (@JSGette) - critical because it what preventing us from switching to Bazel 9 (ADMS config). ### Describe how you validated your changes `bazel test //...` passes. ### Additional Notes Groundwork landed in advance: - #47716 - #47745 - #47982 - #48016 - #48071 - #48082 - #48183 - #48186 - #48200 (>= Bazel 9 min) - #48201 (>= Bazel 9 min) - #48228 (>= Bazel 9 min) Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>

@JSGette

### What does this PR do? Upgrade `bazel` from 8.6.0 to 9.0.1. ### Motivation Bazel 9.0.1 ships upstream fixes that directly benefit our build & developer experience: - bazelbuild/bazel#26842: `BUILD` files and `build` directories were incorrectly treated as the same entry on case-insensitive filesystems (e.g., Linux container running on a macOS host), causing spurious build failures (esp. for `rloader` we had to `gazelle`-exclude because of that), - bazelbuild/bazel#27695: a contribution of ours (also available in 8.6.0 as bazelbuild/bazel#28367) - nice to have when sharing a folder between a Linux host and a Windows VM through `virtiofs`, - bazelbuild/bazel#28640: another contribution of ours (@JSGette) - critical because it what preventing us from switching to Bazel 9 (ADMS config). ### Describe how you validated your changes `bazel test //...` passes. ### Additional Notes Groundwork landed in advance: - #47716 - #47745 - #47982 - #48016 - #48071 - #48082 - #48183 - #48186 - #48200 (>= Bazel 9 min) - #48201 (>= Bazel 9 min) - #48228 (>= Bazel 9 min) Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>

rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 11, 2026

dd-octo-sts bot added internal Identify a non-fork PR team/agent-build labels Mar 11, 2026

github-actions bot added the medium review PR review might take time label Mar 11, 2026

rdesgroppes force-pushed the regis.desgroppes/prereq-rules-cc-explicit-loads branch from 41fe483 to f2c32a2 Compare March 11, 2026 22:38

rdesgroppes marked this pull request as ready for review March 11, 2026 22:46

rdesgroppes requested a review from a team as a code owner March 11, 2026 22:46

aiuto approved these changes Mar 12, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d bot merged commit a8601db into main Mar 12, 2026
260 checks passed

gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/prereq-rules-cc-explicit-loads branch March 12, 2026 14:54

github-actions bot added this to the 7.78.0 milestone Mar 12, 2026

rdesgroppes mentioned this pull request Mar 23, 2026

Bump bazel to 9.0.1 #47742

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `rules_cc` leftovers from #47716 for Bazel 9#47745

Fix `rules_cc` leftovers from #47716 for Bazel 9#47745
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/prereq-rules-cc-explicit-loads

rdesgroppes commented Mar 11, 2026 •

edited

Loading

Uh oh!

agent-platform-auto-pr bot commented Mar 11, 2026

Uh oh!

agent-platform-auto-pr bot commented Mar 11, 2026

Uh oh!

cit-pr-commenter-54b7da bot commented Mar 11, 2026 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rdesgroppes commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Uh oh!

agent-platform-auto-pr bot commented Mar 11, 2026

Files inventory check summary

Results for datadog-agent_7.78.0~devel.git.524.f2c32a2.pipeline.102040430-1_amd64.deb:

Uh oh!

agent-platform-auto-pr bot commented Mar 11, 2026

Static quality checks

Uh oh!

cit-pr-commenter-54b7da bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rdesgroppes commented Mar 11, 2026 •

edited

Loading

cit-pr-commenter-54b7da bot commented Mar 11, 2026 •

edited

Loading