Skip to content

Add explicit py_binary import for Bazel 9#48016

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/prereq-py-binary-load
Mar 19, 2026
Merged

Add explicit py_binary import for Bazel 9#48016
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/prereq-py-binary-load

Conversation

@rdesgroppes
Copy link
Copy Markdown
Contributor

@rdesgroppes rdesgroppes commented Mar 19, 2026

What does this PR do?

Adds an explicit load for py_binary from @rules_python//python:defs.bzl to deps/openssl_fips.BUILD.bazel.

Motivation

In Bazel 9, py_binary is no longer auto-loaded from Bazel's native namespace:

ERROR: deps/openssl_fips.BUILD.bazel:140:1:
    name 'py_binary' is not defined (did you mean 'cc_binary'?)

The load is transparent on Bazel 8, where the rule is still auto-loaded, so this change is safe to land before the Bazel 9 upgrade.

Describe how you validated your changes

bazel run -- @openssl_fips//:install --destdir=/tmp/opt/datadog-agent succeeds.

### What does this PR do?
Adds an explicit `load` for `py_binary` from
`@rules_python//python:defs.bzl` to `deps/openssl_fips.BUILD.bazel`.

### Motivation
In Bazel 9, `py_binary` is no longer auto-loaded from Bazel's native
namespace:
```
ERROR: deps/openssl_fips.BUILD.bazel:140:1:
    name 'py_binary' is not defined (did you mean 'cc_binary'?)
```
The `load` is transparent on Bazel 8, where the rule is still
auto-loaded, so this change is safe to land before the Bazel 9 upgrade.

### Describe how you validated your changes
`bazel run -- @openssl_fips//:install --destdir=/tmp/opt/datadog-agent`
passes.
@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 19, 2026
@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-build labels Mar 19, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 19, 2026
@rdesgroppes rdesgroppes marked this pull request as ready for review March 19, 2026 00:53
@rdesgroppes rdesgroppes requested a review from a team as a code owner March 19, 2026 00:53
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor c3804faf:

Results for datadog-agent_7.78.0~devel.git.703.15fc1e3.pipeline.103414889-1_amd64.deb:

No change detected

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor c3804fa
📊 Static Quality Gates Dashboard
🔗 SQG Job

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 748.999 MiB
agent_deb_amd64_fips 707.352 MiB
agent_heroku_amd64 312.820 MiB
agent_msi 602.525 MiB
agent_rpm_amd64 748.982 MiB
agent_rpm_amd64_fips 707.336 MiB
agent_rpm_arm64 727.486 MiB
agent_rpm_arm64_fips 688.798 MiB
agent_suse_amd64 748.982 MiB
agent_suse_amd64_fips 707.336 MiB
agent_suse_arm64 727.486 MiB
agent_suse_arm64_fips 688.798 MiB
docker_agent_amd64 809.329 MiB
docker_agent_arm64 812.635 MiB
docker_agent_jmx_amd64 1000.245 MiB
docker_agent_jmx_arm64 992.329 MiB
docker_cluster_agent_amd64 203.704 MiB
docker_cluster_agent_arm64 218.167 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 39.215 MiB
docker_dogstatsd_arm64 37.445 MiB
dogstatsd_deb_amd64 29.855 MiB
dogstatsd_deb_arm64 28.007 MiB
dogstatsd_rpm_amd64 29.855 MiB
dogstatsd_suse_amd64 29.855 MiB
iot_agent_deb_amd64 43.062 MiB
iot_agent_deb_arm64 40.124 MiB
iot_agent_deb_armhf 40.860 MiB
iot_agent_rpm_amd64 43.062 MiB
iot_agent_suse_amd64 43.062 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -12.6 KiB (0.01% reduction) 174.226 → 174.214 → 177.700
agent_deb_amd64_fips -19.63 KiB (0.01% reduction) 165.191 → 165.172 → 172.230
agent_heroku_amd64 -8.48 KiB (0.01% reduction) 74.899 → 74.891 → 79.970
agent_msi -28.0 KiB (0.02% reduction) 137.742 → 137.715 → 146.220
agent_rpm_amd64 +56.15 KiB (0.03% increase) 177.070 → 177.125 → 180.780
agent_rpm_amd64_fips -18.96 KiB (0.01% reduction) 167.195 → 167.177 → 173.370
agent_rpm_arm64 neutral 159.580 MiB → 161.610
agent_rpm_arm64_fips -21.77 KiB (0.01% reduction) 151.236 → 151.215 → 155.910
agent_suse_amd64 +56.15 KiB (0.03% increase) 177.070 → 177.125 → 180.780
agent_suse_amd64_fips -18.96 KiB (0.01% reduction) 167.195 → 167.177 → 173.370
agent_suse_arm64 neutral 159.580 MiB → 161.610
agent_suse_arm64_fips -21.77 KiB (0.01% reduction) 151.236 → 151.215 → 155.910
docker_agent_amd64 -3.67 KiB (0.00% reduction) 267.230 → 267.226 → 271.240
docker_agent_arm64 +14.04 KiB (0.01% increase) 254.486 → 254.500 → 259.800
docker_agent_jmx_amd64 neutral 335.877 MiB → 339.870
docker_agent_jmx_arm64 +5.69 KiB (0.00% increase) 319.127 → 319.132 → 324.390
docker_cluster_agent_amd64 neutral 71.293 MiB → 72.920
docker_cluster_agent_arm64 neutral 66.925 MiB → 68.220
docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.159 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.479 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.886 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.772 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.896 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.896 MiB → 8.800
iot_agent_deb_amd64 neutral 11.351 MiB → 12.040
iot_agent_deb_arm64 neutral 9.663 MiB → 10.450
iot_agent_deb_armhf neutral 9.895 MiB → 10.620
iot_agent_rpm_amd64 -2.17 KiB (0.02% reduction) 11.369 → 11.367 → 12.060
iot_agent_suse_amd64 -2.17 KiB (0.02% reduction) 11.369 → 11.367 → 12.060

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Mar 19, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 0bb0fbb8-dead-4892-ad55-f12ea30ae768

Baseline: d3c15fd
Comparison: 8fa1992
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -5.10 [-8.07, -2.12] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.32 [-0.26, +2.90] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.29 [+0.19, +0.40] 1 Logs
file_tree memory utilization +0.20 [+0.15, +0.25] 1 Logs
quality_gate_idle_all_features memory utilization +0.17 [+0.13, +0.21] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.06 [-0.40, +0.52] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.04, +0.11] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.03 [-0.17, +0.22] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.01 [-0.37, +0.40] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.20, +0.21] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.00 [-0.43, +0.44] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.14, +0.10] 1 Logs
ddot_metrics_sum_delta memory utilization -0.03 [-0.20, +0.14] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.11 [-0.25, +0.04] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.28 [-0.34, -0.23] 1 Logs
quality_gate_idle memory utilization -0.29 [-0.34, -0.24] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.31 [-0.48, -0.13] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.50 [-0.72, -0.27] 1 Logs
quality_gate_metrics_logs memory utilization -0.53 [-0.77, -0.29] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.80 [-0.96, -0.65] 1 Logs
otlp_ingest_logs memory utilization -1.05 [-1.16, -0.95] 1 Logs
ddot_logs memory utilization -1.14 [-1.21, -1.07] 1 Logs
tcp_syslog_to_blackhole ingress throughput -2.84 [-3.06, -2.63] 1 Logs
docker_containers_cpu % cpu utilization -5.10 [-8.07, -2.12] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 707 ≥ 26
docker_containers_memory memory_usage 10/10 274.06MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 738 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 9/10 175.98MiB > 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 2 ≤ 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 490.79MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 202.38MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 396.76 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 416.38MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@rdesgroppes
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Mar 19, 2026

View all feedbacks in Devflow UI.

2026-03-19 07:38:15 UTC ℹ️ Start processing command /merge


2026-03-19 07:38:19 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-03-19 08:11:38 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 8fa1992 into main Mar 19, 2026
295 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/prereq-py-binary-load branch March 19, 2026 08:11
@github-actions github-actions bot added this to the 7.78.0 milestone Mar 19, 2026
rdesgroppes added a commit that referenced this pull request Mar 23, 2026
### What does this PR do?

Upgrades the Bazel toolchain from 8.6.0 to 9.0.1.

### Motivation

9.0.1 ships two upstream fixes that directly benefit our build:

- bazelbuild/bazel#28606: NPE when `--repo_env` is set to an env var
  that has no value — contributed by Datadog (Joseph Gette).
- bazelbuild/bazel#26842: `DefaultSyscallCache` incorrectly treated
  `BUILD` files and `build` directories as the same entry on
  case-insensitive / normalizing filesystems (e.g. Linux container on
  a macOS host), causing spurious build failures.

### Describe how you validated your changes

`bazel test //...` passes.

### Additional Notes

Groundwork landed in advance:
- #47716: Bump `rules_cc` with explicit loads for Bazel 9
- #47745: Fix `rules_cc` leftovers from #47716 for Bazel 9
- #47982: Add explicit `cc_static_library` import for Bazel 9
- #48016: Add explicit `py_binary` import for Bazel 9
- #48071: Bump `rules_foreign_cc` for Bazel 9 fixes
- #48082: Bump `rules_python` to 1.9.0 and fix misuses spotted on Windows
- #48183: Fix Python hermetic toolchain check for Bazel 9
- #48186: Disable `repo_contents_cache` when in-workspace for Bazel 9
- #48228: Bump `protobuf` Bazel dep to 34.1
rdesgroppes added a commit that referenced this pull request Mar 24, 2026
### What does this PR do?

Upgrades the Bazel toolchain from 8.6.0 to 9.0.1.

### Motivation

9.0.1 ships two upstream fixes that directly benefit our build:

- bazelbuild/bazel#28606: NPE when `--repo_env` is set to an env var
  that has no value — contributed by Datadog (Joseph Gette).
- bazelbuild/bazel#26842: `DefaultSyscallCache` incorrectly treated
  `BUILD` files and `build` directories as the same entry on
  case-insensitive / normalizing filesystems (e.g. Linux container on
  a macOS host), causing spurious build failures.

### Describe how you validated your changes

`bazel test //...` passes.

### Additional Notes

Groundwork landed in advance:
- #47716: Bump `rules_cc` with explicit loads for Bazel 9
- #47745: Fix `rules_cc` leftovers from #47716 for Bazel 9
- #47982: Add explicit `cc_static_library` import for Bazel 9
- #48016: Add explicit `py_binary` import for Bazel 9
- #48071: Bump `rules_foreign_cc` for Bazel 9 fixes
- #48082: Bump `rules_python` to 1.9.0 and fix misuses spotted on Windows
- #48183: Fix Python hermetic toolchain check for Bazel 9
- #48186: Disable `repo_contents_cache` when in-workspace for Bazel 9
- #48228: Bump `protobuf` Bazel dep to 34.1
gh-worker-dd-mergequeue-cf854d bot pushed a commit that referenced this pull request Mar 24, 2026
### What does this PR do?
Upgrade `bazel` from 8.6.0 to 9.0.1.

### Motivation
Bazel 9.0.1 ships upstream fixes that directly benefit our build & developer experience:
- bazelbuild/bazel#26842: `BUILD` files and `build` directories were incorrectly treated as the same entry on case-insensitive filesystems (e.g., Linux container running on a macOS host), causing spurious build failures (esp. for `rloader` we had to `gazelle`-exclude because of that),
- bazelbuild/bazel#27695: a contribution of ours (also available in 8.6.0 as bazelbuild/bazel#28367) - nice to have when sharing a folder between a Linux host and a Windows VM through `virtiofs`,
- bazelbuild/bazel#28640: another contribution of ours (@JSGette) - critical because it what preventing us from switching to Bazel 9 (ADMS config).

### Describe how you validated your changes
`bazel test //...` passes.

### Additional Notes
Groundwork landed in advance:
- #47716
- #47745
- #47982
- #48016
- #48071
- #48082
- #48183
- #48186
- #48200 (>= Bazel 9 min)
- #48201 (>= Bazel 9 min)
- #48228 (>= Bazel 9 min)

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
aya-shimizu24 pushed a commit that referenced this pull request Mar 24, 2026
### What does this PR do?
Upgrade `bazel` from 8.6.0 to 9.0.1.

### Motivation
Bazel 9.0.1 ships upstream fixes that directly benefit our build & developer experience:
- bazelbuild/bazel#26842: `BUILD` files and `build` directories were incorrectly treated as the same entry on case-insensitive filesystems (e.g., Linux container running on a macOS host), causing spurious build failures (esp. for `rloader` we had to `gazelle`-exclude because of that),
- bazelbuild/bazel#27695: a contribution of ours (also available in 8.6.0 as bazelbuild/bazel#28367) - nice to have when sharing a folder between a Linux host and a Windows VM through `virtiofs`,
- bazelbuild/bazel#28640: another contribution of ours (@JSGette) - critical because it what preventing us from switching to Bazel 9 (ADMS config).

### Describe how you validated your changes
`bazel test //...` passes.

### Additional Notes
Groundwork landed in advance:
- #47716
- #47745
- #47982
- #48016
- #48071
- #48082
- #48183
- #48186
- #48200 (>= Bazel 9 min)
- #48201 (>= Bazel 9 min)
- #48228 (>= Bazel 9 min)

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely pushed a commit that referenced this pull request Mar 27, 2026
### What does this PR do?
Upgrade `bazel` from 8.6.0 to 9.0.1.

### Motivation
Bazel 9.0.1 ships upstream fixes that directly benefit our build & developer experience:
- bazelbuild/bazel#26842: `BUILD` files and `build` directories were incorrectly treated as the same entry on case-insensitive filesystems (e.g., Linux container running on a macOS host), causing spurious build failures (esp. for `rloader` we had to `gazelle`-exclude because of that),
- bazelbuild/bazel#27695: a contribution of ours (also available in 8.6.0 as bazelbuild/bazel#28367) - nice to have when sharing a folder between a Linux host and a Windows VM through `virtiofs`,
- bazelbuild/bazel#28640: another contribution of ours (@JSGette) - critical because it what preventing us from switching to Bazel 9 (ADMS config).

### Describe how you validated your changes
`bazel test //...` passes.

### Additional Notes
Groundwork landed in advance:
- #47716
- #47745
- #47982
- #48016
- #48071
- #48082
- #48183
- #48186
- #48200 (>= Bazel 9 min)
- #48201 (>= Bazel 9 min)
- #48228 (>= Bazel 9 min)

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely pushed a commit that referenced this pull request Mar 27, 2026
### What does this PR do?
Upgrade `bazel` from 8.6.0 to 9.0.1.

### Motivation
Bazel 9.0.1 ships upstream fixes that directly benefit our build & developer experience:
- bazelbuild/bazel#26842: `BUILD` files and `build` directories were incorrectly treated as the same entry on case-insensitive filesystems (e.g., Linux container running on a macOS host), causing spurious build failures (esp. for `rloader` we had to `gazelle`-exclude because of that),
- bazelbuild/bazel#27695: a contribution of ours (also available in 8.6.0 as bazelbuild/bazel#28367) - nice to have when sharing a folder between a Linux host and a Windows VM through `virtiofs`,
- bazelbuild/bazel#28640: another contribution of ours (@JSGette) - critical because it what preventing us from switching to Bazel 9 (ADMS config).

### Describe how you validated your changes
`bazel test //...` passes.

### Additional Notes
Groundwork landed in advance:
- #47716
- #47745
- #47982
- #48016
- #48071
- #48082
- #48183
- #48186
- #48200 (>= Bazel 9 min)
- #48201 (>= Bazel 9 min)
- #48228 (>= Bazel 9 min)

Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants