Skip to content

Commit d3d2691

Browse files
rdesgroppesrdesgroppes
authored
Bump protobuf Bazel dep to 34.1. (#48228)
### What does this PR do? Following #46948, this is to update the `protobuf` Bazel module dependency from 29.1 to 34.1. ### Motivation Several transitive dependencies now require `protobuf` >= 34.0, causing `Renovate` to [fail updating](#48223 (comment)) `MODULE.bazel.lock`: > ERROR: For repository 'protobuf', the root module requires module version protobuf@29.1, but got protobuf@34.0.bcr.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off Bumping to 34.1 satisfies that constraint and also aligns with the recent: - #46948. ### Describe how you validated your changes Built `@protobuf//:protobuf` locally. ### Additional Notes - the existing patch (add `-lstdc++` to `//conditions:default` link opts) applies cleanly to 34.1 without modification, - `34.0` wouldn't be enough, since it's **strictly less than** `34.0.bcr.1`. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
1 parent 3697d3b commit d3d2691

2 files changed

Lines changed: 358 additions & 168 deletions

File tree

‎MODULE.bazel‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ bazel_dep(name = "bazel_skylib", version = "1.9.0")
4949
bazel_dep(name = "gazelle", version = "0.47.0")
5050
bazel_dep(name = "libarchive", version = "3.8.1.bcr.2")
5151
bazel_dep(name = "platforms", version = "1.0.0")
52-
bazel_dep(name = "protobuf", version = "29.1")
52+
bazel_dep(name = "protobuf", version = "34.1")
5353
single_version_override(
5454
module_name = "protobuf",
5555
patch_strip = 1,

0 commit comments

Comments
 (0)