Also set `GIT_DEPTH: 0` for `files_inventory_check` job by rdesgroppes · Pull Request #48203 · DataDog/datadog-agent

rdesgroppes · 2026-03-23T11:35:34Z

What does this PR do?

Set GIT_DEPTH: 0 and OVERRIDE_GIT_STRATEGY: clone so the job fetches the full commit history before determining the ancestor for package size comparison.

Motivation

The files inventory check was sometimes picking a wrong ancestor commit due to a shallow clone, producing spurious diffs.
Same issue fixed for the static quality gate by #44001 together with #46859.

chouquette

Thanks for noticing and fixing <3

agent-platform-auto-pr · 2026-03-23T11:39:36Z

Gitlab CI Configuration Changes

Modified Jobs

files_inventory_check

  files_inventory_check:
    allow_failure: true
    artifacts:
      expire_in: 2 weeks
      paths:
      - '**/*_size_report_*.yml'
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/linux$CI_IMAGE_LINUX_SUFFIX:$CI_IMAGE_LINUX
    needs:
    - agent_deb-x64-a7
    rules:
    - if: $E2E_COVERAGE_PIPELINE == "true"
      when: never
    - if: $CI_COMMIT_BRANCH == "main"
      when: never
    - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
      when: never
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - if: $CI_COMMIT_TAG != null
      when: never
    - changes:
        compare_to: $COMPARE_TO_BRANCH
        paths:
        - go.mod
        - go.sum
        - cmd/**/*
        - comp/**/*
        - internal/**/*
        - pkg/**/*
        - rtloader/**/*
        - tasks/**/*.py
        - deps/**/*
        - omnibus/**/*
        - .bazelrc
        - .bazelversion
        - bazel/**/*
        - BUILD.bazel
        - MODULE.bazel
        - release.json
        - test/regression/**/*
        - Dockerfiles/**/*
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - GITHUB_KEY_B64=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP key_b64)
      || exit $?; export GITHUB_KEY_B64
    - GITHUB_APP_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP app_id)
      || exit $?; export GITHUB_APP_ID
    - GITHUB_INSTALLATION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP
      installation_id) || exit $?; export GITHUB_INSTALLATION_ID
    - echo "Using agent GitHub App"
    - dda inv -- files-inventory.check ${CI_COMMIT_BRANCH} ${OMNIBUS_PACKAGE_DIR}
    stage: functional_test
    tags:
    - arch:amd64
    - specific:true
+   variables:
+     GIT_DEPTH: 0
+     OVERRIDE_GIT_STRATEGY: clone

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff0497e507

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

.gitlab/test/functional_test/files_inventory_check.yml

agent-platform-auto-pr · 2026-03-23T11:56:11Z

Files inventory check summary

File checks results against ancestor 6d7bc6df:

Results for datadog-agent_7.79.0~devel.git.57.effe4ac.pipeline.103975981-1_amd64.deb:

No change detected

### What does this PR do? Sets GIT_DEPTH to 0 and OVERRIDE_GIT_STRATEGY to "clone" so the job fetches the full commit history before determining the ancestor for package size comparison. ### Motivation The files inventory check was sometimes picking a wrong ancestor commit due to a shallow clone, producing spurious diffs (#43843). Same fix applied to the static quality gate in #44001 and #46859.

cit-pr-commenter-54b7da · 2026-03-23T15:07:51Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c45ff527-5be8-463f-81e4-7cf4a0caf3da

Baseline: 61d0ee0
Comparison: 9d72ef8
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+0.52	[-2.53, +3.57]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+0.52	[-2.53, +3.57]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+0.46	[+0.21, +0.70]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulative	memory utilization	+0.32	[+0.18, +0.47]	1	Logs
➖	quality_gate_idle	memory utilization	+0.31	[+0.26, +0.36]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.27	[+0.23, +0.31]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_delta	memory utilization	+0.19	[+0.02, +0.36]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.10	[-0.33, +0.53]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.45, +0.49]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.09, +0.10]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.00	[-0.19, +0.20]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.11, +0.11]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.19, +0.18]	1	Logs
➖	file_tree	memory utilization	-0.01	[-0.06, +0.05]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.03	[-0.41, +0.35]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.06	[-0.12, +0.00]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.07	[-0.23, +0.09]	1	Logs
➖	ddot_metrics	memory utilization	-0.13	[-0.31, +0.05]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.31	[-0.40, -0.22]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.41	[-1.98, +1.17]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.41	[-0.63, -0.19]	1	Logs
➖	ddot_logs	memory utilization	-0.72	[-0.78, -0.66]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.72	[-0.88, -0.57]	1	Logs
➖	docker_containers_memory	memory utilization	-1.53	[-1.69, -1.37]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	704 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	272.93MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	621 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	174.50MiB ≤ 175MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	2 ≤ 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	501.67MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	206.02MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	361.70 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	407.06MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

### What does this PR do? Set `GIT_DEPTH` to `0` so the job fetches the full commit history before determining the ancestor for package size comparison. ### Motivation The files inventory check was sometimes picking a wrong ancestor commit due to a shallow clone, producing spurious diffs. Same issue fixed for the static quality gate by #44001 together with #46859. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>

rdesgroppes requested a review from a team as a code owner March 23, 2026 11:35

rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 23, 2026

dd-octo-sts bot added internal Identify a non-fork PR team/agent-devx labels Mar 23, 2026

github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 23, 2026

rdesgroppes changed the title ~~Also set GIT_DEPTH to 0 for files_inventory_check job~~ Also set GIT_DEPTH: 0 for files_inventory_check job Mar 23, 2026

chouquette approved these changes Mar 23, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 23, 2026

View reviewed changes

.gitlab/test/functional_test/files_inventory_check.yml Show resolved Hide resolved

rdesgroppes force-pushed the regis.desgroppes/fix-files-inventory-git-depth branch from ff0497e to a7fb316 Compare March 23, 2026 11:53

chouetz approved these changes Mar 23, 2026

View reviewed changes

rdesgroppes force-pushed the regis.desgroppes/fix-files-inventory-git-depth branch from a7fb316 to effe4ac Compare March 23, 2026 13:02

gh-worker-dd-mergequeue-cf854d bot merged commit 9d72ef8 into main Mar 23, 2026
255 checks passed

gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/fix-files-inventory-git-depth branch March 23, 2026 14:21

github-actions bot added this to the 7.79.0 milestone Mar 23, 2026

rdesgroppes mentioned this pull request Mar 23, 2026

Disable repo_contents_cache when in-workspace for Bazel 9 #48186

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Also set `GIT_DEPTH: 0` for `files_inventory_check` job#48203

Also set `GIT_DEPTH: 0` for `files_inventory_check` job#48203
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/fix-files-inventory-git-depth

rdesgroppes commented Mar 23, 2026 •

edited

Loading

Uh oh!

chouquette left a comment

Uh oh!

agent-platform-auto-pr bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

agent-platform-auto-pr bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

cit-pr-commenter-54b7da bot commented Mar 23, 2026

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rdesgroppes commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Uh oh!

chouquette left a comment

Choose a reason for hiding this comment

Uh oh!

agent-platform-auto-pr bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Gitlab CI Configuration Changes

Modified Jobs

Changes Summary

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

agent-platform-auto-pr bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Files inventory check summary

Results for datadog-agent_7.79.0~devel.git.57.effe4ac.pipeline.103975981-1_amd64.deb:

Uh oh!

Uh oh!

cit-pr-commenter-54b7da bot commented Mar 23, 2026

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rdesgroppes commented Mar 23, 2026 •

edited

Loading

agent-platform-auto-pr bot commented Mar 23, 2026 •

edited

Loading

agent-platform-auto-pr bot commented Mar 23, 2026 •

edited

Loading