Skip to content

Bump dependency on package_metadata to 0.0.7#43843

Merged
dd-mergequeue[bot] merged 1 commit intomainfrom
aiuto/ss7
Dec 5, 2025
Merged

Bump dependency on package_metadata to 0.0.7#43843
dd-mergequeue[bot] merged 1 commit intomainfrom
aiuto/ss7

Conversation

@aiuto
Copy link
Copy Markdown
Contributor

@aiuto aiuto commented Dec 4, 2025

  • package_metadata 0.0.7 is needed for other PRs I am building and testing for making SBOMs.
  • Also remove an unneeded (and unbuildable) target in //compliance.

- Also remove an unneeded (and unbuildable) target in //compliance.
@aiuto aiuto added the changelog/no-changelog No changelog entry needed label Dec 4, 2025
@aiuto aiuto requested a review from a team as a code owner December 4, 2025 22:10
@aiuto aiuto added qa/no-code-change No code change in Agent code requiring validation ask-review Ask required teams to review this PR labels Dec 4, 2025
@github-actions github-actions bot added team/agent-build short review PR is simple enough to be reviewed quickly labels Dec 4, 2025
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 87b5e65

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${-0}$$ $${705.25}$$ < $${706.32}$$ $${-0.01}$$ $${172.9}$$ < $${173.81}$$
agent_deb_amd64_fips $${0}$$ $${700.09}$$ < $${701.16}$$ $${+0}$$ $${171.69}$$ < $${172.71}$$
agent_heroku_amd64 $${+0.89}$$ $${327.43}$$ < $${327.69}$$ $${+0.08}$$ $${87.37}$$ < $${88.19}$$
agent_msi $${+7.86}$$ $${978.7}$$ < $${982.08}$$ $${+0.01}$$ $${141.79}$$ < $${143.01}$$
agent_rpm_amd64 $${-0}$$ $${705.23}$$ < $${706.31}$$ $${-0.01}$$ $${175.94}$$ < $${176.86}$$
agent_rpm_amd64_fips $${0}$$ $${700.07}$$ < $${701.15}$$ $${+0.04}$$ $${174.07}$$ < $${174.95}$$
agent_rpm_arm64 $${0}$$ $${690.91}$$ < $${691.67}$$ $${+0.06}$$ $${159.8}$$ < $${160.7}$$
agent_rpm_arm64_fips $${0}$$ $${686.72}$$ < $${687.54}$$ $${+0.05}$$ $${159.14}$$ < $${160.1}$$
agent_suse_amd64 $${-0}$$ $${705.23}$$ < $${706.31}$$ $${-0.01}$$ $${175.94}$$ < $${176.86}$$
agent_suse_amd64_fips $${0}$$ $${700.07}$$ < $${701.15}$$ $${+0.04}$$ $${174.07}$$ < $${174.95}$$
agent_suse_arm64 $${0}$$ $${690.91}$$ < $${691.67}$$ $${+0.06}$$ $${159.8}$$ < $${160.7}$$
agent_suse_arm64_fips $${0}$$ $${686.72}$$ < $${687.54}$$ $${+0.05}$$ $${159.14}$$ < $${160.1}$$
docker_agent_amd64 $${+0}$$ $${767.57}$$ < $${768.66}$$ $${+0}$$ $${260.64}$$ < $${261.52}$$
docker_agent_arm64 $${+0}$$ $${777.53}$$ < $${778.35}$$ $${+0.01}$$ $${250.81}$$ < $${251.72}$$
docker_agent_jmx_amd64 $${0}$$ $${958.45}$$ < $${959.54}$$ $${+0}$$ $${329.28}$$ < $${330.15}$$
docker_agent_jmx_arm64 $${+0}$$ $${957.12}$$ < $${957.95}$$ $${+0}$$ $${315.43}$$ < $${316.35}$$
docker_cluster_agent_amd64 $${-0}$$ $${178.88}$$ < $${179.28}$$ $${+0}$$ $${63.18}$$ < $${63.96}$$
docker_cluster_agent_arm64 $${+0}$$ $${196.39}$$ < $${196.79}$$ $${-0}$$ $${59.89}$$ < $${60.69}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.6}$$ < $${39.3}$$ $${+0}$$ $${14.91}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.24}$$ < $${37.94}$$ $${-0.01}$$ $${14.36}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.82}$$ < $${30.53}$$ $${+0}$$ $${7.87}$$ < $${8.75}$$
dogstatsd_deb_arm64 $${0}$$ $${28.33}$$ < $${29.11}$$ $${+0}$$ $${6.81}$$ < $${7.71}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.82}$$ < $${30.53}$$ $${+0}$$ $${7.88}$$ < $${8.76}$$
dogstatsd_suse_amd64 $${0}$$ $${29.82}$$ < $${30.53}$$ $${+0}$$ $${7.88}$$ < $${8.76}$$
iot_agent_deb_amd64 $${0}$$ $${42.6}$$ < $${43.19}$$ $${-0}$$ $${11.12}$$ < $${11.98}$$
iot_agent_deb_arm64 $${0}$$ $${40.34}$$ < $${40.92}$$ $${+0}$$ $${9.58}$$ < $${10.45}$$
iot_agent_deb_armhf $${0}$$ $${40.24}$$ < $${40.86}$$ $${+0}$$ $${9.69}$$ < $${10.56}$$
iot_agent_rpm_amd64 $${0}$$ $${42.6}$$ < $${43.19}$$ $${-0}$$ $${11.14}$$ < $${12.0}$$
iot_agent_suse_amd64 $${0}$$ $${42.6}$$ < $${43.19}$$ $${-0}$$ $${11.14}$$ < $${12.0}$$

@cit-pr-commenter
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4656baec-6838-4341-921c-ce56f891a5f4

Baseline: 12bfa8a
Comparison: f26ae1b
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.51 [+0.45, +6.58] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.51 [+0.45, +6.58] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.19 [-0.05, +0.43] 1 Logs
docker_containers_memory memory utilization +0.18 [+0.10, +0.27] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.38, +0.46] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.03, +0.06] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.13, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.08, +0.07] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.00 [-0.09, +0.08] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.13, +0.12] 1 Logs
quality_gate_idle memory utilization -0.04 [-0.09, +0.01] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.06 [-0.47, +0.36] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.43, +0.31] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.21 [-0.35, -0.06] 1 Logs
ddot_metrics memory utilization -0.25 [-0.46, -0.04] 1 Logs
file_tree memory utilization -0.27 [-0.31, -0.22] 1 Logs
ddot_metrics_sum_delta memory utilization -0.34 [-0.55, -0.13] 1 Logs
otlp_ingest_logs memory utilization -0.45 [-0.54, -0.35] 1 Logs
quality_gate_idle_all_features memory utilization -0.50 [-0.56, -0.45] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.52 [-0.68, -0.37] 1 Logs
ddot_logs memory utilization -0.60 [-0.66, -0.54] 1 Logs
quality_gate_metrics_logs memory utilization -0.65 [-0.85, -0.45] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -1.85 [-3.29, -0.41] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -4.40 [-4.72, -4.09] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@aiuto
Copy link
Copy Markdown
Contributor Author

aiuto commented Dec 5, 2025

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex bot commented Dec 5, 2025

View all feedbacks in Devflow UI.

2025-12-05 05:37:56 UTC ℹ️ Start processing command /merge


2025-12-05 05:38:08 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-12-05 09:39:10 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@aiuto
Copy link
Copy Markdown
Contributor Author

aiuto commented Dec 5, 2025

/merge

@dd-devflow-routing-codex
Copy link
Copy Markdown

dd-devflow-routing-codex bot commented Dec 5, 2025

View all feedbacks in Devflow UI.

2025-12-05 14:08:32 UTC ℹ️ Start processing command /merge


2025-12-05 14:08:37 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 38m (p90).


2025-12-05 14:25:23 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit e846946 into main Dec 5, 2025
301 checks passed
@dd-mergequeue dd-mergequeue bot deleted the aiuto/ss7 branch December 5, 2025 14:25
@github-actions github-actions bot added this to the 7.75.0 milestone Dec 5, 2025
dd-mergequeue bot pushed a commit that referenced this pull request Dec 10, 2025
### What does this PR do?
It sets GIT_DEPTH to 0 to ensure that we pull the entire commit history. It also fixes ownership of the configuration yaml file. Originally the ownership was set for Gitlab job definition and not threshold config.

### Motivation
We do see sometimes SQG are using wrong ancestor commit for size comparison ([example](#43843)).


Co-authored-by: joseph.gette <joseph.gette@datadoghq.com>
rdesgroppes added a commit that referenced this pull request Mar 23, 2026
### What does this PR do?
Sets GIT_DEPTH to 0 and OVERRIDE_GIT_STRATEGY to "clone" so
the job fetches the full commit history before determining
the ancestor for package size comparison.

### Motivation
The files inventory check was sometimes picking a wrong
ancestor commit due to a shallow clone, producing spurious
diffs (#43843). Same fix applied to
the static quality gate in #44001 and
#46859.
rdesgroppes added a commit that referenced this pull request Mar 23, 2026
### What does this PR do?
Sets GIT_DEPTH to 0 and OVERRIDE_GIT_STRATEGY to "clone" so
the job fetches the full commit history before determining
the ancestor for package size comparison.

### Motivation
The files inventory check was sometimes picking a wrong
ancestor commit due to a shallow clone, producing spurious
diffs (#43843). Same fix applied to
the static quality gate in #44001 and
#46859.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants