Set GIT_DEPTH to 0 for SQG by JSGette · Pull Request #44001 · DataDog/datadog-agent

JSGette · 2025-12-09T12:54:07Z

What does this PR do?

It sets GIT_DEPTH to 0 to ensure that we pull the entire commit history. It also fixes ownership of the configuration yaml file. Originally the ownership was set for Gitlab job definition and not threshold config.

Motivation

We do see sometimes SQG are using wrong ancestor commit for size comparison (example).

agent-platform-auto-pr · 2025-12-09T13:00:06Z

Gitlab CI Configuration Changes

Modified Jobs

static_quality_gates

  static_quality_gates:
    artifacts:
      expire_in: 1 week
      paths:
      - extract_rpm_package_report
      - static_gate_report.json
      when: always
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$CI_IMAGE_DOCKER_X64_SUFFIX:$CI_IMAGE_DOCKER_X64
    needs:
    - agent_deb-x64-a7
    - agent_deb-x64-a7-fips
    - agent_rpm-x64-a7
    - agent_rpm-x64-a7-fips
    - agent_rpm-arm64-a7
    - agent_rpm-arm64-a7-fips
    - agent_suse-x64-a7
    - agent_suse-x64-a7-fips
    - agent_suse-arm64-a7
    - agent_suse-arm64-a7-fips
    - agent_heroku_deb-x64-a7
    - docker_build_agent7
    - docker_build_agent7_arm64
    - docker_build_agent7_jmx
    - docker_build_agent7_jmx_arm64
    - docker_build_cluster_agent_amd64
    - docker_build_cluster_agent_arm64
    - docker_build_cws_instrumentation_amd64
    - docker_build_cws_instrumentation_arm64
    - docker_build_dogstatsd_amd64
    - docker_build_dogstatsd_arm64
    - dogstatsd_deb-x64
    - dogstatsd_deb-arm64
    - dogstatsd_rpm-x64
    - dogstatsd_suse-x64
    - iot_agent_deb-x64
    - iot_agent_deb-arm64
    - iot_agent_deb-armhf
    - iot_agent_rpm-x64
    - iot_agent_suse-x64
    - windows_msi_and_bosh_zip_x64-a7
    retry:
      exit_codes:
      - 42
      max: 2
      when:
      - runner_system_failure
      - stuck_or_timeout_failure
      - unknown_failure
      - api_failure
      - scheduler_failure
      - stale_schedule
      - data_integrity_failure
    rules:
    - if: $E2E_COVERAGE_PIPELINE == "true"
      when: never
    - if: $CI_COMMIT_BRANCH == "main"
    - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
    - if: $CI_COMMIT_BRANCH == "main"
      when: never
    - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
      when: never
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - if: $CI_COMMIT_TAG != null
      when: never
    - when: on_success
    script:
    - DOCKER_LOGIN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DOCKER_REGISTRY_RO user)
      || exit $?
    - $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DOCKER_REGISTRY_RO token | crane auth
      login --username "$DOCKER_LOGIN" --password-stdin "$DOCKER_REGISTRY_URL"
    - EXIT="${PIPESTATUS[0]}"; if [ $EXIT -ne 0 ]; then echo "Unable to locate credentials
      needs gitlab runner restart"; exit $EXIT; fi
    - DATADOG_API_KEY="$("$CI_PROJECT_DIR"/tools/ci/fetch_secret.sh "$AGENT_API_KEY_ORG2"
      token)" || exit $?; export DATADOG_API_KEY
    - export DD_API_KEY="$DATADOG_API_KEY"
    - GITHUB_KEY_B64=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP key_b64)
      || exit $?; export GITHUB_KEY_B64
    - GITHUB_APP_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP app_id)
      || exit $?; export GITHUB_APP_ID
    - GITHUB_INSTALLATION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP
      installation_id) || exit $?; export GITHUB_INSTALLATION_ID
    - echo "Using agent GitHub App"
    - SLACK_DATADOG_AGENT_BOT_TOKEN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SLACK_AGENT
      token) || exit $?; export SLACK_DATADOG_AGENT_BOT_TOKEN
    - dda inv -- quality-gates.parse-and-trigger-gates || exit $?
    stage: functional_test
    tags:
    - arch:amd64
    - specific:true
+   variables:
+     GIT_DEPTH: 0

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.

agent-platform-auto-pr · 2025-12-09T13:34:58Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor a8cce4d

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${0}$$	$${705.37}$$ < $${706.32}$$	$${-0.01}$$	$${172.87}$$ < $${173.81}$$
✅	agent_deb_amd64_fips	$${0}$$	$${700.7}$$ < $${701.16}$$	$${-0.01}$$	$${171.88}$$ < $${172.71}$$
✅	agent_heroku_amd64	$${0}$$	$${327.46}$$ < $${327.69}$$	$${+0}$$	$${87.37}$$ < $${88.19}$$
✅	agent_msi	$${0}$$	$${979.06}$$ < $${982.08}$$	$${-0.03}$$	$${141.8}$$ < $${143.01}$$
✅	agent_rpm_amd64	$${0}$$	$${705.36}$$ < $${706.31}$$	$${+0}$$	$${175.96}$$ < $${176.86}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${700.69}$$ < $${701.15}$$	$${+0.02}$$	$${174.01}$$ < $${174.95}$$
✅	agent_rpm_arm64	$${0}$$	$${691.05}$$ < $${691.67}$$	$${+0.01}$$	$${159.76}$$ < $${160.7}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${687.27}$$ < $${687.54}$$	$${-0.03}$$	$${159.25}$$ < $${160.1}$$
✅	agent_suse_amd64	$${0}$$	$${705.36}$$ < $${706.31}$$	$${+0}$$	$${175.96}$$ < $${176.86}$$
✅	agent_suse_amd64_fips	$${0}$$	$${700.69}$$ < $${701.15}$$	$${+0.02}$$	$${174.01}$$ < $${174.95}$$
✅	agent_suse_arm64	$${0}$$	$${691.05}$$ < $${691.67}$$	$${+0.01}$$	$${159.76}$$ < $${160.7}$$
✅	agent_suse_arm64_fips	$${0}$$	$${687.27}$$ < $${687.54}$$	$${-0.03}$$	$${159.25}$$ < $${160.1}$$
✅	docker_agent_amd64	$${0}$$	$${767.7}$$ < $${768.66}$$	$${+0}$$	$${260.66}$$ < $${261.52}$$
✅	docker_agent_arm64	$${-0}$$	$${777.67}$$ < $${778.35}$$	$${-0}$$	$${250.84}$$ < $${251.72}$$
✅	docker_agent_jmx_amd64	$${-0}$$	$${958.58}$$ < $${959.54}$$	$${+0}$$	$${329.29}$$ < $${330.15}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${957.26}$$ < $${957.95}$$	$${-0}$$	$${315.47}$$ < $${316.35}$$
✅	docker_cluster_agent_amd64	$${-0}$$	$${178.9}$$ < $${179.28}$$	$${-0}$$	$${63.18}$$ < $${63.96}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${196.39}$$ < $${196.79}$$	$${+0}$$	$${59.89}$$ < $${60.69}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.71}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.65}$$ < $${39.3}$$	$${+0}$$	$${14.93}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.3}$$ < $${37.94}$$	$${-0}$$	$${14.37}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.87}$$ < $${30.53}$$	$${-0}$$	$${7.87}$$ < $${8.75}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.39}$$ < $${29.11}$$	$${+0}$$	$${6.81}$$ < $${7.71}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.87}$$ < $${30.53}$$	$${+0}$$	$${7.89}$$ < $${8.76}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.87}$$ < $${30.53}$$	$${+0}$$	$${7.89}$$ < $${8.76}$$
✅	iot_agent_deb_amd64	$${0}$$	$${42.6}$$ < $${43.19}$$	$${+0}$$	$${11.12}$$ < $${11.98}$$
✅	iot_agent_deb_arm64	$${0}$$	$${40.34}$$ < $${40.92}$$	$${-0}$$	$${9.58}$$ < $${10.45}$$
✅	iot_agent_deb_armhf	$${0}$$	$${40.25}$$ < $${40.86}$$	$${-0}$$	$${9.69}$$ < $${10.56}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${42.6}$$ < $${43.19}$$	$${-0}$$	$${11.14}$$ < $${12.0}$$
✅	iot_agent_suse_amd64	$${0}$$	$${42.6}$$ < $${43.19}$$	$${-0}$$	$${11.14}$$ < $${12.0}$$

cit-pr-commenter · 2025-12-09T13:51:54Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1c11a7ca-056d-4051-be5d-5b680895ab10

Baseline: a8cce4d
Comparison: dc23f59
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+0.19	[-2.77, +3.15]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+0.76	[-0.71, +2.22]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.46	[+0.38, +0.53]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.31	[+0.25, +0.37]	1	Logs
➖	quality_gate_idle	memory utilization	+0.28	[+0.24, +0.33]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_delta	memory utilization	+0.21	[+0.01, +0.42]	1	Logs
➖	docker_containers_cpu	% cpu utilization	+0.19	[-2.77, +3.15]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.17	[+0.08, +0.26]	1	Logs
➖	ddot_logs	memory utilization	+0.08	[+0.02, +0.14]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.03	[-0.35, +0.40]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.00	[-0.42, +0.42]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.00	[-0.13, +0.14]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.08, +0.07]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.00	[-0.38, +0.37]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.15, +0.12]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.05	[-0.10, +0.00]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.15	[-0.38, +0.08]	1	Logs
➖	ddot_metrics	memory utilization	-0.18	[-0.42, +0.05]	1	Logs
➖	file_tree	memory utilization	-0.29	[-0.36, -0.22]	1	Logs
➖	docker_containers_memory	memory utilization	-0.32	[-0.39, -0.26]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.38	[-0.42, -0.35]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-0.41	[-0.62, -0.19]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulative	memory utilization	-0.73	[-0.89, -0.58]	1	Logs
➖	otlp_ingest_metrics	memory utilization	-0.76	[-0.90, -0.61]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	lost_bytes	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

JSGette · 2025-12-10T08:31:38Z

/merge

dd-devflow-routing-codex · 2025-12-10T08:31:42Z

View all feedbacks in Devflow UI.

2025-12-10 08:31:42 UTC ℹ️ Start processing command /merge

2025-12-10 08:31:47 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 42m (p90).

2025-12-10 08:47:38 UTC ℹ️ MergeQueue: This merge request was merged

### What does this PR do? Sets GIT_DEPTH to 0 so the job fetches the full commit history before determining the ancestor for package size comparison. ### Motivation The files inventory check was sometimes picking a wrong ancestor commit due to a shallow clone, producing spurious diffs. Same issue fixed for the static quality gate in #44001.

### What does this PR do? Sets GIT_DEPTH to 0 and OVERRIDE_GIT_STRATEGY to "clone" so the job fetches the full commit history before determining the ancestor for package size comparison. ### Motivation The files inventory check was sometimes picking a wrong ancestor commit due to a shallow clone, producing spurious diffs (#43843). Same fix applied to the static quality gate in #44001 and #46859.

### What does this PR do? Set `GIT_DEPTH` to `0` so the job fetches the full commit history before determining the ancestor for package size comparison. ### Motivation The files inventory check was sometimes picking a wrong ancestor commit due to a shallow clone, producing spurious diffs. Same issue fixed for the static quality gate by #44001 together with #46859. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>

Set GIT_DEPTH to 0 for SQG

09e25cc

JSGette self-assigned this Dec 9, 2025

JSGette requested review from cmourot and dd-ddamien as code owners December 9, 2025 12:54

JSGette added the changelog/no-changelog No changelog entry needed label Dec 9, 2025

JSGette requested a review from a team as a code owner December 9, 2025 12:54

JSGette added the qa/no-code-change No code change in Agent code requiring validation label Dec 9, 2025

Set ownership correctly for SQG config

dc23f59

github-actions bot added team/agent-build short review PR is simple enough to be reviewed quickly labels Dec 9, 2025

rdesgroppes approved these changes Dec 9, 2025

View reviewed changes

dd-mergequeue bot merged commit 7332462 into main Dec 10, 2025
348 checks passed

dd-mergequeue bot deleted the jsgette/git_depth branch December 10, 2025 08:47

github-actions bot added this to the 7.75.0 milestone Dec 10, 2025

rdesgroppes mentioned this pull request Mar 23, 2026

Also set GIT_DEPTH: 0 for files_inventory_check job #48203

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set GIT_DEPTH to 0 for SQG#44001

Set GIT_DEPTH to 0 for SQG#44001
dd-mergequeue[bot] merged 2 commits intomainfrom
jsgette/git_depth

JSGette commented Dec 9, 2025

Uh oh!

agent-platform-auto-pr bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

agent-platform-auto-pr bot commented Dec 9, 2025

Info

Uh oh!

cit-pr-commenter bot commented Dec 9, 2025

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

JSGette commented Dec 10, 2025

Uh oh!

dd-devflow-routing-codex bot commented Dec 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

JSGette commented Dec 9, 2025

What does this PR do?

Motivation

Uh oh!

agent-platform-auto-pr bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Gitlab CI Configuration Changes

Modified Jobs

Changes Summary

Uh oh!

agent-platform-auto-pr bot commented Dec 9, 2025

Static quality checks

Info

Uh oh!

cit-pr-commenter bot commented Dec 9, 2025

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

JSGette commented Dec 10, 2025

Uh oh!

dd-devflow-routing-codex bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

agent-platform-auto-pr bot commented Dec 9, 2025 •

edited

Loading

dd-devflow-routing-codex bot commented Dec 10, 2025 •

edited

Loading