Use clone strategy for sqg job to get correct ancestor#46859
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom Feb 24, 2026
Merged
Use clone strategy for sqg job to get correct ancestor#46859gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
Conversation
Contributor
Gitlab CI Configuration ChangesModified Jobsstatic_quality_gates static_quality_gates:
artifacts:
expire_in: 1 week
paths:
- extract_rpm_package_report
- static_gate_report.json
when: always
image: registry.ddbuild.io/ci/datadog-agent-buildimages/docker_x64$CI_IMAGE_DOCKER_X64_SUFFIX:$CI_IMAGE_DOCKER_X64
needs:
- agent_deb-x64-a7
- agent_deb-x64-a7-fips
- agent_rpm-x64-a7
- agent_rpm-x64-a7-fips
- agent_rpm-arm64-a7
- agent_rpm-arm64-a7-fips
- agent_suse-x64-a7
- agent_suse-x64-a7-fips
- agent_suse-arm64-a7
- agent_suse-arm64-a7-fips
- agent_heroku_deb-x64-a7
- docker_build_agent7
- docker_build_agent7_arm64
- docker_build_agent7_jmx
- docker_build_agent7_jmx_arm64
- docker_build_cluster_agent_amd64
- docker_build_cluster_agent_arm64
- docker_build_cws_instrumentation_amd64
- docker_build_cws_instrumentation_arm64
- docker_build_dogstatsd_amd64
- docker_build_dogstatsd_arm64
- dogstatsd_deb-x64
- dogstatsd_deb-arm64
- dogstatsd_rpm-x64
- dogstatsd_suse-x64
- iot_agent_deb-x64
- iot_agent_deb-arm64
- iot_agent_deb-armhf
- iot_agent_rpm-x64
- iot_agent_suse-x64
- windows_msi_and_bosh_zip_x64-a7
retry:
exit_codes:
- 42
max: 2
when:
- runner_system_failure
- stuck_or_timeout_failure
- unknown_failure
- api_failure
- scheduler_failure
- stale_schedule
- data_integrity_failure
rules:
- if: $E2E_COVERAGE_PIPELINE == "true"
when: never
- if: $CI_COMMIT_BRANCH == "main"
- if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: on_success
- if: $CI_COMMIT_BRANCH == "main"
when: never
- if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
when: never
- if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
when: never
- if: $CI_COMMIT_TAG != null
when: never
- changes:
compare_to: $COMPARE_TO_BRANCH
paths:
- go.mod
- go.sum
- cmd/**/*
- comp/**/*
- internal/**/*
- pkg/**/*
- rtloader/**/*
- tasks/**/*.py
- deps/**/*
- omnibus/**/*
- .bazelrc
- .bazelversion
- bazel/**/*
- BUILD.bazel
- MODULE.bazel
- release.json
- test/regression/**/*
- Dockerfiles/**/*
- allow_failure: true
when: manual
script:
- DOCKER_LOGIN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DOCKER_REGISTRY_RO user)
|| exit $?
- $CI_PROJECT_DIR/tools/ci/fetch_secret.sh $DOCKER_REGISTRY_RO token | crane auth
login --username "$DOCKER_LOGIN" --password-stdin "$DOCKER_REGISTRY_URL"
- EXIT="${PIPESTATUS[0]}"; if [ $EXIT -ne 0 ]; then echo "Unable to locate credentials
needs gitlab runner restart"; exit $EXIT; fi
- DATADOG_API_KEY="$("$CI_PROJECT_DIR"/tools/ci/fetch_secret.sh "$AGENT_API_KEY_ORG2"
token)" || exit $?; export DATADOG_API_KEY
- export DD_API_KEY="$DATADOG_API_KEY"
- DD_APP_KEY="$("$CI_PROJECT_DIR"/tools/ci/fetch_secret.sh "$AGENT_APP_KEY_ORG2"
token)" || exit $?; export DD_APP_KEY
- GITHUB_KEY_B64=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP key_b64)
|| exit $?; export GITHUB_KEY_B64
- GITHUB_APP_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP app_id)
|| exit $?; export GITHUB_APP_ID
- GITHUB_INSTALLATION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_GITHUB_APP
installation_id) || exit $?; export GITHUB_INSTALLATION_ID
- echo "Using agent GitHub App"
- SLACK_DATADOG_AGENT_BOT_TOKEN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $SLACK_AGENT
token) || exit $?; export SLACK_DATADOG_AGENT_BOT_TOKEN
- dda inv -- quality-gates.parse-and-trigger-gates || exit $?
stage: functional_test
tags:
- arch:amd64
- specific:true
variables:
GIT_DEPTH: 0
+ OVERRIDE_GIT_STRATEGY: cloneChanges Summary
ℹ️ Diff available in the job log. |
Contributor
Static quality checks✅ Please find below the results from static quality gates 31 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
JSGette
approved these changes
Feb 24, 2026
rdesgroppes
approved these changes
Feb 24, 2026
Contributor
rdesgroppes
left a comment
There was a problem hiding this comment.
Freaking good catch, thanks @pgimalac!
rdesgroppes
added a commit
that referenced
this pull request
Mar 23, 2026
### What does this PR do? Sets GIT_DEPTH to 0 and OVERRIDE_GIT_STRATEGY to "clone" so the job fetches the full commit history before determining the ancestor for package size comparison. ### Motivation The files inventory check was sometimes picking a wrong ancestor commit due to a shallow clone, producing spurious diffs (#43843). Same fix applied to the static quality gate in #44001 and #46859.
rdesgroppes
added a commit
that referenced
this pull request
Mar 23, 2026
### What does this PR do? Sets GIT_DEPTH to 0 and OVERRIDE_GIT_STRATEGY to "clone" so the job fetches the full commit history before determining the ancestor for package size comparison. ### Motivation The files inventory check was sometimes picking a wrong ancestor commit due to a shallow clone, producing spurious diffs (#43843). Same fix applied to the static quality gate in #44001 and #46859.
gh-worker-dd-mergequeue-cf854d bot
pushed a commit
that referenced
this pull request
Mar 23, 2026
### What does this PR do? Set `GIT_DEPTH` to `0` so the job fetches the full commit history before determining the ancestor for package size comparison. ### Motivation The files inventory check was sometimes picking a wrong ancestor commit due to a shallow clone, producing spurious diffs. Same issue fixed for the static quality gate by #44001 together with #46859. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
aya-shimizu24
pushed a commit
that referenced
this pull request
Mar 24, 2026
### What does this PR do? Set `GIT_DEPTH` to `0` so the job fetches the full commit history before determining the ancestor for package size comparison. ### Motivation The files inventory check was sometimes picking a wrong ancestor commit due to a shallow clone, producing spurious diffs. Same issue fixed for the static quality gate by #44001 together with #46859. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely
pushed a commit
that referenced
this pull request
Mar 27, 2026
### What does this PR do? Set `GIT_DEPTH` to `0` so the job fetches the full commit history before determining the ancestor for package size comparison. ### Motivation The files inventory check was sometimes picking a wrong ancestor commit due to a shallow clone, producing spurious diffs. Same issue fixed for the static quality gate by #44001 together with #46859. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely
pushed a commit
that referenced
this pull request
Mar 27, 2026
### What does this PR do? Set `GIT_DEPTH` to `0` so the job fetches the full commit history before determining the ancestor for package size comparison. ### Motivation The files inventory check was sometimes picking a wrong ancestor commit due to a shallow clone, producing spurious diffs. Same issue fixed for the static quality gate by #44001 together with #46859. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use clone strategy for sqg job.
Motivation
Get the correct ancestor in this job. When using s3 strategy some part of the history can be missing.
Describe how you validated your changes
CI
Additional Notes