Skip to content

Mark query cache as non-experimental#47977

Merged
alexey-milovidov merged 1 commit intomasterfrom
rs/non-experimental-qc
May 6, 2023
Merged

Mark query cache as non-experimental#47977
alexey-milovidov merged 1 commit intomasterfrom
rs/non-experimental-qc

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Mar 24, 2023 •
edited
Loading

This PR marks the query cache as non-experimental. Must only be merged after these items:

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

The query cache can now be used for production workloads

@robot-ch-test-poll robot-ch-test-poll added the pr-feature Pull request with new product feature label Mar 24, 2023
@rschu1ze rschu1ze added the do not test disable testing on pull request label Mar 24, 2023
@rschu1ze rschu1ze force-pushed the rs/non-experimental-qc branch from 0095229 to fe92f67 Compare April 3, 2023 11:58
@alexey-milovidov

This comment was marked as outdated.

Sign in to view
@rschu1ze rschu1ze force-pushed the rs/non-experimental-qc branch 2 times, most recently from ce98d9a to d2bd74c Compare May 5, 2023 17:16
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented May 5, 2023 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 0598bfd with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟡 pending
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🔴 failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@rschu1ze rschu1ze force-pushed the rs/non-experimental-qc branch from d2bd74c to fb441cb Compare May 6, 2023 13:43
@rschu1ze rschu1ze removed the do not test disable testing on pull request label May 6, 2023
@rschu1ze rschu1ze marked this pull request as ready for review May 6, 2023 13:45
@rschu1ze rschu1ze force-pushed the rs/non-experimental-qc branch from fb441cb to 0598bfd Compare May 6, 2023 13:58
@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented May 6, 2023

@alexey-milovidov This PR makes QC non-experimental. Want to review/approve? Thanks!

@alexey-milovidov alexey-milovidov merged commit 54163b8 into master May 6, 2023
@alexey-milovidov alexey-milovidov deleted the rs/non-experimental-qc branch May 6, 2023 16:49
@alexey-milovidov alexey-milovidov self-assigned this May 6, 2023
@tsolodov tsolodov mentioned this pull request May 17, 2023
Merged
1 task
@rschu1ze rschu1ze mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-feature Pull request with new product feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rschu1ze @alexey-milovidov @robot-clickhouse @robot-ch-test-poll